c1163dff19
* EVEN MORE HARDDEL FIXES (#60228) Fixes a ton of harddels, sourced from #59996 I think this brings us down to like, ~100 per round from ~200, with only like 20 of those being proper hell failures. I've seen harddel profiles below 1 second of total cost. Feeling good. See you on the other side Makes the cryopod control computer into a weakref, never trust bee code Converts brig door timer internal lists to weakrefs Fixes a harddel caused by qdeling a motion sensitive camera after it had left its source area, jesus christ why didn't we do this already holy shit Converts the radio implant ref held by the antenna mutation to weakrefs because it isn't reliably cleaned up, makes the radio implant actually qdel its fucking radio Removes the target var from the throwing datum, it does literally nothing and just exists to cause harddels, mostly for the singularity Fixes a cable harddel sourced from things that try to enter blueprints after smoothing, but before roundstart. IE, shuttles. Removes shuttles from the blueprints Fixes emmisive blockers being added post qdel Removes some manual ghosting from cryopods, I initially did this for harddel reasons, but I figured out a better fix for that. I'm now doing it because it's got this really strange logic for like "re-entering the game" that doesn't actually link to what the ghostize proc does. We should remove this at some point Fixes robot hud objects harddeling due to hanging refs Fixes buildmode related hanging refs, I'm coming for you admin team Fixes a few instances of trying to add the forensics component post qdel, hhhhhhhhhhh Fixes some split personality harddels/weirdness Replaces a use of disconnect_duct with an init qdel hint, I suspect there's more issues with duct harddels, I've seen some odd logs about ahhh the area_contents list, but we can worry about that later Makes teleporter targets into weakrefs, properly types them as /atom Makes frequency devices into weakrefs Makes cameras remove themselves from camera nets on Destroy Makes tgui ui datums implement destroy, this means if I ever see one hang a ref to user or whatever, I know there's an error with calling close() properly. I've seen this harddel once, but not after this change so I assume there was some error with close(). IDK maybe this is a papering over? Would have to ask @ stylemistake I've seen logs of beartraps being in world post del, putting a return there just in case. The same is true of nerf darts, but I haven't really looked into that yet Makes a shoe's ref to untying alerts a weakref, yes this is needed. Moves clearing client_in_contents to the Login of the new mob. This prevents doing things like ghosting someone before a mob qdel causing harddels Fixes a harddel set sourced from adding a status effect to a qdeleted thing. Is this an error? I'm honestly not sure. Converts bsa code to weakrefs Converts the partner var of heat exchangers to weakrefs Converts camera assemblies to weakrefs Fixes some dumb behavior with ammo casings and assuming you'll be on a turf post Destroy parent call Fixes? merger related harddels, you were never cleared from your own members list, so origin objects would end up making a new list, creating harddels. Potential input from @ ninjanomnom about the logic Chasms store a static list of "falling atoms", which only exists for chasms that go somewhere else. This list wasn't being cleared of qdeleted objects, which is what happens when you fall in most chasms. Fixes this, and converts the list to weakrefs. Fixes some runtimes in both sheet code, and the weather listener element. This is here because runtime spam made testing more of a pain, didn't think it needed its own pr Fixes colorful reagent harddels sourced from reagents that were qdel'd before roundstart. I'm only like 50% sure this actually got it, but the issue may have been solved by #60174, so eh Turns the nuke op antag datum's ref to the war button into a weakref Fixes some holopad code that was not nulling refs all the time Converts camera bugs to weakrefs, this was the result of the bug being "reworked" like 6 years back without taking the existing ref clearing into account. Whole item needs a redo, but this'll do for now. Ensures that the both pulling and pullee refs are cleared on Destroy The crew monitor held all users in a non clearing list, makes that list a weakref because I hate everything Oh and I removed all sources of gas_mixture qdeletion, I'm kinda unsure on this since it's not technically supported, but any harddels from it might? indicate something going wrong with like, gas passing logic. I'd like @ MrStonedOne's thoughts, since I trust him to call me an idiot if I'm wrong. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Why it's not good for the game I crashed sybil like 10 times to get this data, I'm gonna put it to good use. Don't think you're safe sybilites, I'm coming for you. * EVEN MORE HARDDEL FIXES Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Buildmode
Code layout
Buildmode
Manager for buildmode modes. Contains logic to manage switching between each mode, and presenting a suitable user interface.
Effects
Special graphics used by buildmode modes for user interface purposes.
Buildmode Mode
Implementer of buildmode behaviors.
Existing varieties:
-
Basic
Description:
Allows creation of simple structures consisting of floors, walls, windows, and airlocks.
Controls:
-
Left click a turf:
"Upgrades" the turf based on the following rules below:
- Space -> Tiled floor
- Simulated floor -> Regular wall
- Wall -> Reinforced wall
-
Right click a turf:
"Downgrades" the turf based on the following rules below:
- Reinforced wall -> Regular wall
- Wall -> Tiled floor
- Simulated floor -> Space
-
Right click an object:
Deletes the clicked object.
-
Alt+Left click a location:
Places an airlock at the clicked location.
-
Ctrl+Left click a location:
Places a window at the clicked location.
-
-
Advanced
Description:
Creates an instance of a configurable atom path where you click.
Controls:
-
Right click on the mode selector:
Choose a path to spawn.
-
Left click a location (requires chosen path):
Place an instance of the chosen path at the location.
-
Right click an object:
Delete the object.
-
-
Fill
Description:
Creates an instance of an atom path on every tile in a chosen region.
With a special control input, instead deletes everything within the region.
Controls:
-
Right click on the mode selector:
Choose a path to spawn.
-
Left click on a region (requires chosen path):
Fill the region with the chosen path.
-
Alt+Left click on a region:
Deletes everything within the region.
-
Right click during region selection:
Cancel region selection.
-
-
Copy
Description:
Take an existing object in the world, and place duplicates with identical attributes where you click.
May not always work nicely - "deep" variables such as lists or datums may malfunction.
Controls:
-
Right click an existing object:
Select the clicked object as a template.
-
Left click a location (Requires a selected object as template):
Place a duplicate of the template at the clicked location.
-
-
Area Edit
Description:
Modifies and creates areas.
The active area will be highlighted in yellow.
Controls:
-
Right click the mode selector:
Create a new area, and make it active.
-
Right click an existing area:
Make the clicked area active.
-
Left click a turf:
When an area is active, adds the turf to the active area.
-
-
Var Edit
Description:
Allows for setting and resetting variables of objects with a click.
If the object does not have the var, will do nothing and print a warning message.
Controls:
-
Right click the mode selector:
Choose which variable to set, and what to set it to.
-
Left click an atom:
Change the clicked atom's variables as configured.
-
Right click an atom:
Reset the targeted variable to its original value in the code.
-
-
Map Generator
Description:
Fills rectangular regions with algorithmically generated content. Right click during region selection to cancel.
See the
procedural_mappingmodule for the generators themselves.Controls:
-
Right-click on the mode selector:
Select a map generator from all the generators present in the codebase.
-
Left click two corners of an area:
Use the generator to populate the region.
-
Right click during region selection:
Cancel region selection.
-
-
Throwing
Description:
Select an object with left click, and right click to throw it towards where you clicked.
Controls:
-
Left click on a movable atom:
Select the atom for throwing.
-
Right click on a location:
Throw the selected atom towards that location.
-
-
Boom
Description:
Make explosions where you click.
Controls:
-
Right click the mode selector:
Configure the explosion size.
-
Left click a location:
Cause an explosion where you clicked.
-