mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-10 08:54:15 +00:00
* PDA update (Messenger works while dead, Microwave works, etc). (#80069) This is an update that touches many more things all at once (compared to my other PRs) meant to make PDAs in general feel more consistent and not take away from one of the experiences we want to encourage: interaction between players. 1. Replaced all checks of a 'pda' with a 'modular pc'. This means technically (though not done in-game currently) other modpcs can hold an uplink, and microwaves can charge laptops. 2. Speaking of microwave, they now don't break and require deconstruction if the cell is removed mid-charge. 3. When a Mod PC is out of power, it will now allow the Messenger to work (which now also doesn't consume any additional power), if the app exists on the PC. Here's a video demonstration https://github.com/tgstation/tgstation/assets/53777086/7ae12f81-a271-49b8-95fa-2ba54d2e2d1f 4. Flashlights can't be turned on while the cell is dead 5. I replaced a bunch of program vars with ``program_flags`` and renamed ``usage_flags`` to ``can_run_on_flags``. 6. Added a debug modPC that has every app installed by default. Mafia had some issues in the past that were unknown because Mafia wasn't preinstalled with any tablet so was never in create & destroy nor in any other unit test. This was just an easy solution I had, but PDAs should get more in-depth unit tests in the future for running apps n stuff- I just wanted to make sure no other apps were broken/harddeling. Currently when a PDA dies, its only use is to reply to PDA messages sent to you, since you can still reply to them. Instead of just fixing it and telling players to cope, I thought it would be nice to allow PDA Messenger to still work, as it is a vital app. You can call it some emergency power mode or whatever, I don't really mind the reason behind why it is this way. When I made cells used more on PDAs, my main goal was to encourage upgrading your PDA and/or limiting how many apps you use at once, I did not want this to hit on players who use it as a form of interaction. This is the best of both worlds, I think. The rest of the changes is just for modularity, if some downstream wants to add tablets, phone computers, or whatever the hell else, they can still get just as far as PDAs should be able to get to, hopefully. 🆑 add: PDAs with a dead power cell are now limited to using their Messenger app. fix: Microwaves now stop charging PDAs if the cell was removed mid-charge. fix: Microwaves can now charge laptops. fix: PDA Flashlights can't be turned on while the PDA is dead. fix: You can now hold a laptop up to a camera (if it has a notekeeper app installed) like PDAs already could. /🆑 --------- Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com> * ok --------- Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
216 lines
9.4 KiB
Plaintext
216 lines
9.4 KiB
Plaintext
// /program/ files are executable programs that do things.
|
|
/datum/computer_file/program
|
|
filetype = "PRG"
|
|
/// File name. FILE NAME MUST BE UNIQUE IF YOU WANT THE PROGRAM TO BE DOWNLOADABLE FROM NTNET!
|
|
filename = "UnknownProgram"
|
|
|
|
/// Program-specific bitflags that tell the app what it runs on.
|
|
/// (PROGRAM_ALL | PROGRAM_CONSOLE | PROGRAM_LAPTOP | PROGRAM_PDA)
|
|
var/can_run_on_flags = PROGRAM_ALL
|
|
/// Program-specific bitflags that tells the ModPC what the app is able to do special.
|
|
/// (PROGRAM_REQUIRES_NTNET|PROGRAM_ON_NTNET_STORE|PROGRAM_ON_SYNDINET_STORE|PROGRAM_UNIQUE_COPY|PROGRAM_HEADER|PROGRAM_RUNS_WITHOUT_POWER)
|
|
var/program_flags = PROGRAM_ON_NTNET_STORE
|
|
///How much power running this program costs.
|
|
var/power_cell_use = PROGRAM_BASIC_CELL_USE
|
|
///List of required accesses to *run* the program. Any match will do.
|
|
///This also acts as download_access if that is not set, making this more draconic and restrictive.
|
|
var/list/run_access = list()
|
|
///List of required access to download or file host the program. Any match will do.
|
|
var/list/download_access = list()
|
|
/// User-friendly name of this program.
|
|
var/filedesc = "Unknown Program"
|
|
/// Short description of this program's function.
|
|
var/extended_desc = "N/A"
|
|
///What category this program can be found in within NTNetDownloader.
|
|
///This is required if PROGRAM_ON_NTNET_STORE or PROGRAM_ON_SYNDINET_STORE is on.
|
|
var/downloader_category = PROGRAM_CATEGORY_DEVICE
|
|
///The overlay to add ontop of the ModPC running the app while it's open.
|
|
///This is taken from the same file as the ModPC, so you can use can_run_on_flags to prevent
|
|
///the program from being used on devices that don't have sprites for it.
|
|
var/program_open_overlay = null
|
|
/// NTNet status, updated every tick by computer running this program. Don't use this for checks if NTNet works, computers do that. Use this for calculations, etc.
|
|
var/ntnet_status = 1
|
|
/// Name of the tgui interface. If this is not defined, this will not be available in NTNet.
|
|
var/tgui_id
|
|
/// Example: "something.gif" - a header image that will be rendered in computer's UI when this program is running at background. Images must also be inserted into /datum/asset/simple/headers.
|
|
var/ui_header = null
|
|
/// Font Awesome icon to use as this program's icon in the modular computer main menu. Defaults to a basic program maximize window icon if not overridden.
|
|
var/program_icon = "window-maximize-o"
|
|
/// Whether this program can send alerts while minimized or closed. Used to show a mute button per program in the file manager
|
|
var/alert_able = FALSE
|
|
/// Whether the user has muted this program's ability to send alerts.
|
|
var/alert_silenced = FALSE
|
|
/// Whether to highlight our program in the main screen. Intended for alerts, but loosely available for any need to notify of changed conditions. Think Windows task bar highlighting. Available even if alerts are muted.
|
|
var/alert_pending = FALSE
|
|
/// How well this program will help combat detomatix viruses.
|
|
var/detomatix_resistance = NONE
|
|
|
|
/datum/computer_file/program/clone()
|
|
var/datum/computer_file/program/temp = ..()
|
|
temp.run_access = run_access
|
|
temp.filedesc = filedesc
|
|
temp.program_open_overlay = program_open_overlay
|
|
temp.program_flags = program_flags
|
|
temp.can_run_on_flags = can_run_on_flags
|
|
if(program_flags & PROGRAM_UNIQUE_COPY)
|
|
if(computer)
|
|
computer.remove_file(src)
|
|
if(disk_host)
|
|
disk_host.remove_file(src)
|
|
return temp
|
|
|
|
/**
|
|
* WARNING: this proc does not work the same as normal `ui_interact`, as the
|
|
* computer takes care of opening the UI. The `datum/tgui/ui` parameter will always exist.
|
|
* This proc only serves as a callback.
|
|
*/
|
|
/datum/computer_file/program/ui_interact(mob/user, datum/tgui/ui)
|
|
SHOULD_CALL_PARENT(FALSE)
|
|
|
|
///We are not calling parent as it's handled by the computer itself, this is only called after.
|
|
/datum/computer_file/program/ui_act(action, params, datum/tgui/ui, datum/ui_state/state)
|
|
SHOULD_CALL_PARENT(FALSE)
|
|
|
|
// Relays icon update to the computer.
|
|
/datum/computer_file/program/proc/update_computer_icon()
|
|
if(computer)
|
|
computer.update_appearance()
|
|
|
|
///Attempts to generate an Ntnet log, returns the log on success, FALSE otherwise.
|
|
/datum/computer_file/program/proc/generate_network_log(text)
|
|
if(!computer || computer.obj_flags & EMAGGED)
|
|
return FALSE
|
|
return computer.add_log(text)
|
|
|
|
/**
|
|
*Runs when the device is used to attack an atom in non-combat mode using right click (secondary).
|
|
*
|
|
*Simulates using the device to read or scan something. Tap is called by the computer during pre_attack
|
|
*and sends us all of the related info. If we return TRUE, the computer will stop the attack process
|
|
*there. What we do with the info is up to us, but we should only return TRUE if we actually perform
|
|
*an action of some sort.
|
|
*Arguments:
|
|
*A is the atom being tapped
|
|
*user is the person making the attack action
|
|
*params is anything the pre_attack() proc had in the same-named variable.
|
|
*/
|
|
/datum/computer_file/program/proc/tap(atom/tapped_atom, mob/living/user, params)
|
|
return FALSE
|
|
|
|
///Makes sure a program can run on this hardware (for apps limited to tablets/computers/laptops)
|
|
/datum/computer_file/program/proc/is_supported_by_hardware(hardware_flag = NONE, loud = FALSE, mob/user)
|
|
if(!(hardware_flag & can_run_on_flags))
|
|
if(loud && computer && user)
|
|
to_chat(user, span_danger("\The [computer] flashes a \"Hardware Error - Incompatible software\" warning."))
|
|
return FALSE
|
|
return TRUE
|
|
|
|
// Called by Process() on device that runs us, once every tick.
|
|
/datum/computer_file/program/proc/process_tick(seconds_per_tick)
|
|
return TRUE
|
|
|
|
/**
|
|
* Checks if the user can run program. Only humans and silicons can operate computer. Automatically called in on_start()
|
|
* ID must be inserted into a card slot to be read. If the program is not currently installed (as is the case when
|
|
* NT Software Hub is checking available software), a list can be given to be used instead.
|
|
* Args:
|
|
* user is a ref of the mob using the device.
|
|
* loud is a bool deciding if this proc should use to_chats
|
|
* access_to_check is an access level that will be checked against the ID
|
|
* downloading: Boolean on whether it's downloading the app or not. If it is, it will check download_access instead of run_access.
|
|
* access can contain a list of access numbers to check against. If access is not empty, it will be used istead of checking any inserted ID.
|
|
*/
|
|
/datum/computer_file/program/proc/can_run(mob/user, loud = FALSE, access_to_check, downloading = FALSE, list/access)
|
|
if(user)
|
|
if(issilicon(user) && !ispAI(user))
|
|
return TRUE
|
|
if(isAdminGhostAI(user))
|
|
return TRUE
|
|
|
|
if(computer && (computer.obj_flags & EMAGGED) && (program_flags & PROGRAM_ON_SYNDINET_STORE || !downloading)) //emagged can run anything on syndinet, and can bypass execution locks, but not download.
|
|
return TRUE
|
|
|
|
if(!access_to_check)
|
|
if(downloading && length(download_access))
|
|
access_to_check = download_access
|
|
else
|
|
access_to_check = run_access
|
|
if(!length(access_to_check)) // No access requirements, allow it.
|
|
return TRUE
|
|
|
|
if(!length(access))
|
|
var/obj/item/card/id/accesscard
|
|
if(computer)
|
|
accesscard = computer.computer_id_slot?.GetID()
|
|
|
|
if(!accesscard)
|
|
if(loud && user)
|
|
to_chat(user, span_danger("\The [computer] flashes an \"RFID Error - Unable to scan ID\" warning."))
|
|
return FALSE
|
|
access = accesscard.GetAccess()
|
|
|
|
for(var/singular_access in access_to_check)
|
|
if(singular_access in access) //For loop checks every individual access entry in the access list. If the user's ID has access to any entry, then we're good.
|
|
return TRUE
|
|
|
|
if(loud && user)
|
|
to_chat(user, span_danger("\The [computer] flashes an \"Access Denied\" warning."))
|
|
return FALSE
|
|
|
|
/**
|
|
* Called on program startup.
|
|
*
|
|
* May be overridden to add extra logic. Remember to include ..() call. Return 1 on success, 0 on failure.
|
|
* When implementing new program based device, use this to run the program.
|
|
* Arguments:
|
|
* * user - The mob that started the program
|
|
**/
|
|
/datum/computer_file/program/proc/on_start(mob/living/user)
|
|
SHOULD_CALL_PARENT(TRUE)
|
|
if(can_run(user, loud = TRUE))
|
|
if(program_flags & PROGRAM_REQUIRES_NTNET)
|
|
var/obj/item/card/id/ID = computer.computer_id_slot?.GetID()
|
|
generate_network_log("Connection opened -- Program ID:[filename] User:[ID?"[ID.registered_name]":"None"]")
|
|
return TRUE
|
|
return FALSE
|
|
|
|
/**
|
|
* Kills the running program
|
|
*
|
|
* Use this proc to kill the program.
|
|
* Designed to be implemented by each program if it requires on-quit logic, such as the NTNRC client.
|
|
* Args:
|
|
* - user - If there's a user, this is the person killing the program.
|
|
**/
|
|
/datum/computer_file/program/proc/kill_program(mob/user)
|
|
SHOULD_CALL_PARENT(TRUE)
|
|
|
|
if(src == computer.active_program)
|
|
computer.active_program = null
|
|
if(computer.enabled)
|
|
computer.update_tablet_open_uis(user)
|
|
if(src in computer.idle_threads)
|
|
computer.idle_threads.Remove(src)
|
|
|
|
if(program_flags & PROGRAM_REQUIRES_NTNET)
|
|
var/obj/item/card/id/ID = computer.computer_id_slot?.GetID()
|
|
generate_network_log("Connection closed -- Program ID: [filename] User:[ID ? "[ID.registered_name]" : "None"]")
|
|
|
|
computer.update_appearance(UPDATE_ICON)
|
|
return TRUE
|
|
|
|
///Sends the running program to the background/idle threads. Header programs can't be minimized and will kill instead.
|
|
/datum/computer_file/program/proc/background_program()
|
|
SHOULD_CALL_PARENT(TRUE)
|
|
if(program_flags & PROGRAM_HEADER)
|
|
return kill_program()
|
|
|
|
computer.idle_threads.Add(src)
|
|
computer.active_program = null
|
|
|
|
computer.update_tablet_open_uis(usr)
|
|
computer.update_appearance(UPDATE_ICON)
|
|
return TRUE
|
|
|
|
#undef PROGRAM_BASIC_CELL_USE
|