mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-07 14:59:13 +00:00
146d0fd59d
first things first, back when LemonInTheDark changed the interact_range code he did a slight modification that broke the AI cards, namely, he did this (not saying its a bad change, it is actually a good change, just mentioning what change caused the issue im fixing now): now, his change does make sense, since he changed the range default to 0 instead of 1, however "null" is also used as a range, specifically for AIs, now this normally isnt an issue for the AI itself, as the AI generally gets a TRUE in its interaction checks before it gets down this deep (machines have a bypass specifically for AI), but there is one situation in which it does go this deep: AI Cards, when in an AI card the AIs interaction range is set to 0 and their interaction is disabled, thereby making it impossible for them to interact with anything, now when a player opens the card UI and enables the AIs ability to interact, this sets their range back to null, aka unlimited, the issue now however, is that since "null" is treated the same as "0", and AIs in cards dont hit the same bypasses an AI core does, Lemons change to submit a false return for 0, is also submitting false for null, meaning the AI card cannot interact with anything except the tile its on, despite having null/unlimited range.... fixed by changing the null value to infinity where it is used additionally my fix of can_interact() code apparently had the unintended side effect of not allowing rotations of machines if theres no power, i missed this entirely because thats such a specific situation, since you try rotating with APC power in most cases, it also didnt affect most machines, that said the fix was simple, just changed the proc being called to only check distance, not power. fixes #61852 and last but not least, fixes some code with the syndie bombs interactability, namely removes a redudant section, and adds a check for range, turns out there were no checks for range so you could in theory open the UI and walk away and then activate it from another location, so added a quick check to ensure you actually CAN interact with it before letting you push buttons in the UI
117 lines
3.5 KiB
Plaintext
117 lines
3.5 KiB
Plaintext
/obj/item/aicard
|
|
name = "intelliCard"
|
|
desc = "A storage device for AIs. Patent pending."
|
|
icon = 'icons/obj/aicards.dmi'
|
|
icon_state = "aicard" // aicard-full
|
|
inhand_icon_state = "electronic"
|
|
worn_icon_state = "electronic"
|
|
lefthand_file = 'icons/mob/inhands/items/devices_lefthand.dmi'
|
|
righthand_file = 'icons/mob/inhands/items/devices_righthand.dmi'
|
|
w_class = WEIGHT_CLASS_SMALL
|
|
slot_flags = ITEM_SLOT_BELT
|
|
item_flags = NOBLUDGEON
|
|
var/flush = FALSE
|
|
var/mob/living/silicon/ai/AI
|
|
|
|
/obj/item/aicard/aitater
|
|
name = "intelliTater"
|
|
desc = "A stylish upgrade (?) to the intelliCard."
|
|
icon_state = "aitater"
|
|
|
|
/obj/item/aicard/aispook
|
|
name = "intelliLantern"
|
|
desc = "A spoOoOoky upgrade to the intelliCard."
|
|
icon_state = "aispook"
|
|
|
|
/obj/item/aicard/suicide_act(mob/living/user)
|
|
user.visible_message(span_suicide("[user] is trying to upload [user.p_them()]self into [src]! That's not going to work out well!"))
|
|
return BRUTELOSS
|
|
|
|
/obj/item/aicard/pre_attack(atom/target, mob/living/user, params)
|
|
if(AI) //AI is on the card, implies user wants to upload it.
|
|
var/our_ai = AI
|
|
target.transfer_ai(AI_TRANS_FROM_CARD, user, AI, src)
|
|
if(!AI)
|
|
log_combat(user, our_ai, "uploaded", src, "to [target].")
|
|
update_appearance()
|
|
return TRUE
|
|
else //No AI on the card, therefore the user wants to download one.
|
|
target.transfer_ai(AI_TRANS_TO_CARD, user, null, src)
|
|
if(AI)
|
|
log_silicon("[key_name(user)] carded [key_name(AI)]", src)
|
|
update_appearance()
|
|
return TRUE
|
|
return ..()
|
|
|
|
/obj/item/aicard/update_icon_state()
|
|
if(!AI)
|
|
name = initial(name)
|
|
icon_state = initial(icon_state)
|
|
return ..()
|
|
name = "[initial(name)] - [AI.name]"
|
|
icon_state = "[initial(icon_state)][AI.stat == DEAD ? "-404" : "-full"]"
|
|
AI.cancel_camera()
|
|
return ..()
|
|
|
|
/obj/item/aicard/update_overlays()
|
|
. = ..()
|
|
if(!AI?.control_disabled)
|
|
return
|
|
. += "[initial(icon_state)]-on"
|
|
|
|
/obj/item/aicard/ui_state(mob/user)
|
|
return GLOB.hands_state
|
|
|
|
/obj/item/aicard/ui_interact(mob/user, datum/tgui/ui)
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "Intellicard", name)
|
|
ui.open()
|
|
|
|
/obj/item/aicard/ui_data()
|
|
var/list/data = list()
|
|
if(AI)
|
|
data["name"] = AI.name
|
|
data["laws"] = AI.laws.get_law_list(include_zeroth = TRUE, render_html = FALSE)
|
|
data["health"] = (AI.health + 100) / 2
|
|
data["wireless"] = !AI.control_disabled //todo disabled->enabled
|
|
data["radio"] = AI.radio_enabled
|
|
data["isDead"] = AI.stat == DEAD
|
|
data["isBraindead"] = AI.client ? FALSE : TRUE
|
|
data["wiping"] = flush
|
|
return data
|
|
|
|
/obj/item/aicard/ui_act(action,params)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
switch(action)
|
|
if("wipe")
|
|
if(flush)
|
|
flush = FALSE
|
|
else
|
|
var/confirm = tgui_alert(usr, "Are you sure you want to wipe this card's memory?", name, list("Yes", "No"))
|
|
if(confirm == "Yes" && !..())
|
|
flush = TRUE
|
|
if(AI && AI.loc == src)
|
|
to_chat(AI, span_userdanger("Your core files are being wiped!"))
|
|
while(AI.stat != DEAD && flush)
|
|
AI.adjustOxyLoss(5)
|
|
AI.updatehealth()
|
|
sleep(5)
|
|
flush = FALSE
|
|
. = TRUE
|
|
if("wireless")
|
|
AI.control_disabled = !AI.control_disabled
|
|
if(!AI.control_disabled)
|
|
AI.interaction_range = INFINITY
|
|
else
|
|
AI.interaction_range = 0
|
|
to_chat(AI, span_warning("[src]'s wireless port has been [AI.control_disabled ? "disabled" : "enabled"]!"))
|
|
. = TRUE
|
|
if("radio")
|
|
AI.radio_enabled = !AI.radio_enabled
|
|
to_chat(AI, span_warning("Your Subspace Transceiver has been [AI.radio_enabled ? "enabled" : "disabled"]!"))
|
|
. = TRUE
|
|
update_appearance()
|