MrMelbert b8af2429c8 Fix vote can_be_initiated mutating the active choices (#83029) ...

## About The Pull Request

Closes #83020

This proc, called *every single ui_data tick*, was mutating the vote's
list of choices. Grahhh impure procs grahhh


https://github.com/tgstation/tgstation/blob/f112369547a7da6fdafd69c1d43baf0fc6f76f77/code/datums/votes/map_vote.dm#L57-L60

Weirdly, I have no idea how this *ever* worked, even prior to my PR,
because I didn't touch this or any consuming code. It was called in the
same place, same args, etc. prior to my PR. So I have no idea.

## Changelog

🆑 Melbert
fix: Map vote should work better
/🆑

2024-05-04 12:16:04 -06:00

..

_vote_datum.dm

Vote clean up and admin additions (#82981)

2024-05-01 16:55:01 -06:00

custom_vote.dm

Vote clean up and admin additions (#82981)

2024-05-01 16:55:01 -06:00

map_vote.dm

Fix vote can_be_initiated mutating the active choices (#83029)

2024-05-04 12:16:04 -06:00

restart_vote.dm

Vote clean up and admin additions (#82981)

2024-05-01 16:55:01 -06:00

rock_the_vote.dm

Vote clean up and admin additions (#82981)

2024-05-01 16:55:01 -06:00