mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-29 02:21:44 +00:00
6b83a91956
## About The Pull Request Reverts the storage initialization refactor and all subsequent related PRs. The original PR is below our standards both for code quality and testing, and is majorly flawed at its core. This has been discussed with other maintainers and headcoder(s?) over on discord. A lot of changes from the PR could be brought over later, but in its current state it should not have been merged. - Closes #90322 - Closes #90313 - Closes #90315 - Closes #90320 - Closes #90312 - Closes #90344 ## Why It's Good For The Game This PR causes a series of major issues which cannot be resolved without either completely rewriting a lot of the original PR, or bad code. Not matching our standards is grounds for not merging a PR, and the fact that a PR should not have been merged is a reason for a revert. ## Changelog 🆑 fix: Fixed a series of storage-related bugs caused by a refactor PR. /🆑
44 lines
1.9 KiB
Plaintext
44 lines
1.9 KiB
Plaintext
/// Test storage datums
|
|
/datum/unit_test/storage
|
|
|
|
/datum/unit_test/storage/Run()
|
|
var/obj/item/big_thing = allocate(__IMPLIED_TYPE__, run_loc_floor_bottom_left)
|
|
big_thing.w_class = WEIGHT_CLASS_BULKY
|
|
var/obj/item/small_thing = allocate(__IMPLIED_TYPE__, run_loc_floor_bottom_left)
|
|
small_thing.w_class = WEIGHT_CLASS_SMALL
|
|
|
|
var/obj/item/storage/backpack/storage_item = allocate(__IMPLIED_TYPE__, run_loc_floor_bottom_left)
|
|
|
|
storage_item.atom_storage.attempt_insert(big_thing)
|
|
TEST_ASSERT_NOTEQUAL(big_thing.loc, storage_item, "A bulky item should have failed to insert into a backpack")
|
|
|
|
storage_item.atom_storage.attempt_insert(small_thing)
|
|
TEST_ASSERT_EQUAL(small_thing.loc, storage_item, "A small item should have successfully inserted into a backpack")
|
|
|
|
small_thing.update_weight_class(WEIGHT_CLASS_NORMAL)
|
|
TEST_ASSERT_EQUAL(small_thing.loc, storage_item, "A small item changed into normal size should not have ejected from the backpack")
|
|
|
|
small_thing.update_weight_class(WEIGHT_CLASS_BULKY)
|
|
TEST_ASSERT_NOTEQUAL(small_thing.loc, storage_item, "A small item changed back into bulky size should have ejected from the backpack")
|
|
|
|
/datum/unit_test/common_item_inserting
|
|
|
|
/datum/unit_test/common_item_inserting/Run()
|
|
var/obj/item/storage/backpack/bag = allocate(__IMPLIED_TYPE__, run_loc_floor_bottom_left)
|
|
var/mob/living/carbon/human/consistent/dummy = allocate(__IMPLIED_TYPE__, run_loc_floor_bottom_left)
|
|
bag.atom_storage.max_slots = INFINITY
|
|
bag.atom_storage.max_total_storage = INFINITY
|
|
|
|
var/list/common_noncombat_insertion_items = list(
|
|
/obj/item/reagent_containers/cup/rag,
|
|
/obj/item/soap,
|
|
/obj/item/card/emag,
|
|
/obj/item/detective_scanner,
|
|
)
|
|
|
|
dummy.set_combat_mode(TRUE)
|
|
for(var/item_type in common_noncombat_insertion_items)
|
|
var/obj/item/item = allocate(item_type, run_loc_floor_bottom_left)
|
|
item.melee_attack_chain(dummy, bag)
|
|
TEST_ASSERT_EQUAL(item.loc, bag, "[item_type] was unable to be inserted into a backpack on click while off combat mode")
|