mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-19 22:23:11 +00:00
ab5a4d0f99
* split area.contained_turfs up by zlevel, make init 10 seconds faster (#80941) ## About The Pull Request Situation: areas have a list of all turfs in their area. Problem: `/area/space` is an area and has a 6 to 7 digit count of turfs that has to be traversed for every turf we need to remove from it. This can take multiple byond ticks just to preform this action for a single space rune Solution: split the list by zlevel, and only search the right zlevel list when removing turfs from areas. replaces `area.get_contained_turfs()` with a few new procs: * `get_highest_zlevel()` - returns the highest zlevel the area contains turfs in. useful for use with `get_turfs_by_zlevel` * `get_turfs_by_zlevel(zlevel)` - returns a list of turfs in the area in a given zlevel. Useful for code that only cares about a specific zlevel or changes behavior based on zlevel like lighting init. * `get_turfs_from_all_zlevels()` - the replacement for `get_contained_turfs()`, renamed as such so anybody copying/cargo culting code gets a hint that a zlevel specific version might exist. Still used in for loops that type checked so byond would do that all at once * `get_zlevel_turf_lists()` - returns the area's zlevel lists of lists but only for non-empty zlevels. very useful for for loops. The area contents unit test has been rewritten to ensure any improper data triggers failures or runtimes by not having it use the helpers above (some of which ensure a list is always returned) and access the lists directly. * split area.contained_turfs up by zlevel, make init 10 seconds faster * eeyes * Update area_spawn_subsystem.dm * Unshits turf contain code slightly (#81023) Literally just implements my reviews from #80941 I am frankly a smidge pissed that the pr was merged without them being handled. No code is worth merging past known issues, and if the author is just gonna dip then that's life. I don't like privileging mso on stuff like this, especially because frankly I'm kinda mad at him rn but also because when a pr is made the onus on finishing it falls to the person who made it. Should not need to clean up after someone as a maintainer, and shouldn't normalize doing it. I'm not like mad at zypher directly mind he offered to do this too, just the idea he was espousing here. --------- Co-authored-by: Kyle Spier-Swenson <kyleshome@gmail.com> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com> Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
66 lines
2.8 KiB
Plaintext
66 lines
2.8 KiB
Plaintext
/// Trait for tracking if something already has the fake irradiation effect, so we don't waste time on effect operations if otherwise unnecessary
|
|
#define TRAIT_RADIOACTIVE_NEBULA_FAKE_IRRADIATED "radioactive_nebula_fake_irradiated"
|
|
|
|
/// Controls making objects irradiated when Radioactive Nebula is in effect.
|
|
SUBSYSTEM_DEF(radioactive_nebula)
|
|
name = "Radioactive Nebula"
|
|
flags = SS_BACKGROUND
|
|
wait = 30 SECONDS
|
|
|
|
VAR_PRIVATE
|
|
datum/station_trait/nebula/hostile/radiation/radioactive_nebula
|
|
|
|
/datum/controller/subsystem/radioactive_nebula/Initialize()
|
|
radioactive_nebula = locate() in SSstation.station_traits
|
|
if (!radioactive_nebula)
|
|
can_fire = FALSE
|
|
return SS_INIT_NO_NEED
|
|
|
|
// We don't *really* care that this happens by the time the server is ready to play.
|
|
ASYNC
|
|
irradiate_everything()
|
|
|
|
// Don't leak that the station trait has been picked
|
|
return SS_INIT_NO_MESSAGE
|
|
|
|
/// Makes something appear irradiated for the purposes of the Radioactive Nebula
|
|
/datum/controller/subsystem/radioactive_nebula/proc/fake_irradiate(atom/movable/target)
|
|
if (HAS_TRAIT(target, TRAIT_RADIOACTIVE_NEBULA_FAKE_IRRADIATED))
|
|
return
|
|
|
|
ADD_TRAIT(target, TRAIT_RADIOACTIVE_NEBULA_FAKE_IRRADIATED, REF(src))
|
|
|
|
if(iscarbon(target))//Don't actually make EVERY. SINGLE. THING. RADIOACTIVE. Just irradiate people
|
|
target.AddComponent( \
|
|
/datum/component/radioactive_exposure, \
|
|
minimum_exposure_time = NEBULA_RADIATION_MINIMUM_EXPOSURE_TIME, \
|
|
irradiation_chance_base = RADIATION_EXPOSURE_NEBULA_BASE_CHANCE, \
|
|
irradiation_chance_increment = RADIATION_EXPOSURE_NEBULA_CHANCE_INCREMENT, \
|
|
irradiation_interval = RADIATION_EXPOSURE_NEBULA_CHECK_INTERVAL, \
|
|
source = src, \
|
|
radioactive_areas = radioactive_nebula.radioactive_areas, \
|
|
)
|
|
else if(isobj(target)) //and fake the rest
|
|
//outline clashes too much with other outlines and creates pretty ugly lines
|
|
target.add_filter(GLOW_NEBULA, 2, list("type" = "drop_shadow", "color" = radioactive_nebula.nebula_radglow, "size" = 2))
|
|
|
|
/datum/controller/subsystem/radioactive_nebula/fire()
|
|
irradiate_everything()
|
|
|
|
/// Loop through radioactive space (with lag checks) and make it all radioactive!
|
|
/datum/controller/subsystem/radioactive_nebula/proc/irradiate_everything()
|
|
for (var/area/area as anything in get_areas(radioactive_nebula.radioactive_areas))
|
|
for (var/list/zlevel_turfs as anything in area.get_zlevel_turf_lists())
|
|
for (var/turf/area_turf as anything in zlevel_turfs)
|
|
for (var/atom/movable/target as anything in area_turf)
|
|
fake_irradiate(target)
|
|
|
|
CHECK_TICK
|
|
|
|
/// Remove the fake radiation. The compontent we add to mobs handles its own removal
|
|
/datum/controller/subsystem/radioactive_nebula/proc/fake_unirradiate(atom/movable/leaver)
|
|
REMOVE_TRAIT(leaver, TRAIT_RADIOACTIVE_NEBULA_FAKE_IRRADIATED, REF(src))
|
|
leaver.remove_filter(GLOW_NEBULA)
|
|
|
|
#undef TRAIT_RADIOACTIVE_NEBULA_FAKE_IRRADIATED
|