mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-18 21:53:22 +00:00
3f0b4abb8d
## About The Pull Request All usages of world.icon_size in code have been replaced with new `ICONSIZE_X`, `ICONSIZE_Y` and `ICONSIZE_ALL` defines depending on context Replaces some "32" magic numbers with the defines A few bits of code have been modified to split up x/y math as well ## Why It's Good For The Game Magic number bad, code more readable, code more flexible and I'm told there's an access cost to doing world.icon_size so minor performance gains ## Changelog 🆑 tonty code: made some code relating to the world's icon size more readable /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
42 lines
1.7 KiB
Plaintext
42 lines
1.7 KiB
Plaintext
/**
|
|
* Creates a mirage effect allowing you to see around the world border, by adding the opposite side to its vis_contents.
|
|
*/
|
|
/datum/element/mirage_border
|
|
|
|
/datum/element/mirage_border/Attach(datum/target, turf/target_turf, direction, range=world.view)
|
|
. = ..()
|
|
if(!isturf(target))
|
|
return ELEMENT_INCOMPATIBLE
|
|
#ifdef TESTING
|
|
// This is a highly used proc, and these error states never occur, so limit it to testing.
|
|
// If something goes wrong it will runtime anyway.
|
|
if(!target_turf || !istype(target_turf) || !direction)
|
|
stack_trace("[type] improperly attached with the following args: target=\[[target_turf]\], direction=\[[direction]\], range=\[[range]\]")
|
|
return ELEMENT_INCOMPATIBLE
|
|
#endif
|
|
|
|
var/atom/movable/mirage_holder/holder = new(target)
|
|
|
|
var/x = target_turf.x
|
|
var/y = target_turf.y
|
|
var/z = clamp(target_turf.z, 1, world.maxz)
|
|
var/turf/southwest = locate(clamp(x - (direction & WEST ? range : 0), 1, world.maxx), clamp(y - (direction & SOUTH ? range : 0), 1, world.maxy), z)
|
|
var/turf/northeast = locate(clamp(x + (direction & EAST ? range : 0), 1, world.maxx), clamp(y + (direction & NORTH ? range : 0), 1, world.maxy), z)
|
|
holder.vis_contents += block(southwest, northeast)
|
|
if(direction & SOUTH)
|
|
holder.pixel_y -= ICON_SIZE_Y * range
|
|
if(direction & WEST)
|
|
holder.pixel_x -= ICON_SIZE_X * range
|
|
|
|
/datum/element/mirage_border/Detach(atom/movable/target)
|
|
. = ..()
|
|
var/atom/movable/mirage_holder/held = locate() in target.contents
|
|
if(held)
|
|
qdel(held)
|
|
|
|
INITIALIZE_IMMEDIATE(/atom/movable/mirage_holder)
|
|
// Using /atom/movable because this is a heavily used path
|
|
/atom/movable/mirage_holder
|
|
name = "Mirage holder"
|
|
mouse_opacity = MOUSE_OPACITY_TRANSPARENT
|