mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-24 16:41:48 +00:00
077e2d4eee
* Makes update_icon_updates_onmob more robust (#75324) Safeguards against #74965 happening in the future. Noticed a bunch of these were using ITEM_SLOT_HANDS. This is incorrect, as the element already automatically updates held items. grep'd it to catch future instances. Likewise, a number of objects weren't passing slot_flags to the element, meaning it wasn't actually updating those things properly when they were being worn. I've simplified this so now the element will automatically update all slot_flags, and passing an additional slot to the element when being added is only needed for additional slots that might need to be updated. This also means if slot_flags change, the element will now update correctly as well. 🆑 ShizCalev code: The update_icon_updates_onmob element will now automatically update all slots in an item's slot_flags var. This does fix multiple things that weren't updating properly. Passing a slot to the element is now only necessary if you want to add additional slots to be updated. /🆑 * Makes update_icon_updates_onmob more robust --------- Co-authored-by: ShizCalev <ShizCalev@users.noreply.github.com>
30 lines
1.1 KiB
Plaintext
30 lines
1.1 KiB
Plaintext
//update_icon() may change the onmob icons
|
|
//Very good name, I know
|
|
/datum/element/update_icon_updates_onmob
|
|
element_flags = ELEMENT_BESPOKE
|
|
argument_hash_start_idx = 2
|
|
///The ITEM_SLOT_X flags to update on the parent mob in additon to the item's slot_flags. (Ex: Passing ITEM_SLOT_HANDCUFFED for sneakers will update the handcuff overlays in addition to ITEM_SLOT_FEET's overlays when their icon changes.)
|
|
var/update_flags = NONE
|
|
///Should the element call [/mob/proc/update_body()] in addition to clothing updates?
|
|
var/update_body = FALSE
|
|
|
|
/datum/element/update_icon_updates_onmob/Attach(datum/target, flags, body = FALSE)
|
|
. = ..()
|
|
if(!isitem(target))
|
|
return ELEMENT_INCOMPATIBLE
|
|
RegisterSignal(target, COMSIG_ATOM_UPDATED_ICON, PROC_REF(update_onmob))
|
|
update_flags = flags
|
|
update_body = body
|
|
|
|
/datum/element/update_icon_updates_onmob/proc/update_onmob(obj/item/target)
|
|
SIGNAL_HANDLER
|
|
|
|
if(ismob(target.loc))
|
|
var/mob/M = target.loc
|
|
if(M.is_holding(target))
|
|
M.update_held_items()
|
|
else
|
|
M.update_clothing((target.slot_flags|update_flags))
|
|
if(update_body)
|
|
M.update_body()
|