mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-20 14:45:05 +00:00
45d520f4df
## About The Pull Request Another batch of changes to examine, ideas being courtesy of Melbert and Swanni. When examining an item you will now see tags with tooltips elaborating on their meaning instead of having each property displayed in a separate line. Additionally, examines now use fieldsets, saving a line previously spent on displaying an item's name and instead putting it directly into the top outline. Embedding and slapcrafting also display their properties as tags, and combat info now displays item's sharpness. Here are some examples, each tag previously taking up its own line.    Additionally, protection classes now better elaborate on items' temperature protection properties and tell you the exact temperatures that an item can withstand  ## Why It's Good For The Game Tags are a very intuitive system used in many games and we could benefit from it too. Compressing seven lines of text into one while retaining readability and all information within by using tooltips will majorly cut down on chat space used by examines. ## Changelog 🆑 refactor: Refactored how examines display item properties. A lot of them are now displayed as tags that you can hover over to receive details about, like item size, resistances and materials an object is made of. qol: Protection classes now better elaborate on thermal resistances of items, displaying the exact temperatures they can protect you from. /🆑
125 lines
4.7 KiB
Plaintext
125 lines
4.7 KiB
Plaintext
/**
|
|
*
|
|
* The purpose of this element is to widely provide the ability to examine an object and determine its stats, with the ability to add
|
|
* additional notes or information based on type or other factors
|
|
*
|
|
*/
|
|
/datum/element/weapon_description
|
|
element_flags = ELEMENT_BESPOKE
|
|
argument_hash_start_idx = 2
|
|
|
|
// Additional proc to be run for specific object types
|
|
var/attached_proc
|
|
|
|
/datum/element/weapon_description/Attach(datum/target, attached_proc)
|
|
. = ..()
|
|
if(!isitem(target)) // Do not attach this to anything that isn't an item
|
|
return ELEMENT_INCOMPATIBLE
|
|
RegisterSignal(target, COMSIG_ATOM_EXAMINE, PROC_REF(warning_label))
|
|
RegisterSignal(target, COMSIG_TOPIC, PROC_REF(topic_handler))
|
|
// Don't perform the assignment if there is nothing to assign, or if we already have something for this bespoke element
|
|
if(attached_proc && !src.attached_proc)
|
|
src.attached_proc = attached_proc
|
|
|
|
/datum/element/weapon_description/Detach(datum/target)
|
|
. = ..()
|
|
UnregisterSignal(target, list(COMSIG_ATOM_EXAMINE, COMSIG_TOPIC))
|
|
|
|
/**
|
|
*
|
|
* This proc is called when the user examines an object with the associated element. This produces a hyperlinked
|
|
* text line provided that the given item meets the weapon-determining criteria (Sufficient force or notes)
|
|
*
|
|
* Arguments:
|
|
* * source - Object being examined, cast into an item variable
|
|
* * user - Unused
|
|
* * examine_texts - The output text list of the original examine function
|
|
*/
|
|
/datum/element/weapon_description/proc/warning_label(obj/item/item, mob/user, list/examine_texts)
|
|
SIGNAL_HANDLER
|
|
|
|
if(item.force >= 5 || item.throwforce >= 5 || item.override_notes || item.offensive_notes || attached_proc) /// Only show this tag for items that could feasibly be weapons, shields, or those that have special notes
|
|
examine_texts += span_notice("<a href='?src=[REF(item)];examine=1'>See combat information.</a>")
|
|
|
|
/**
|
|
*
|
|
* Details the stats of the examined weapon
|
|
*
|
|
* This function is called when the user clicks the hyperlink provided by
|
|
* warning_label(). It calls build_label_text() and outputs its return value to the user
|
|
*
|
|
* Arguments:
|
|
* * source - Object being examined, sent to build_label_text()
|
|
* * href-list - List provided by the href of input values, used to know what hyperlinked action is being attempted
|
|
*/
|
|
|
|
/datum/element/weapon_description/proc/topic_handler(atom/source, user, href_list)
|
|
SIGNAL_HANDLER
|
|
|
|
if(href_list["examine"])
|
|
to_chat(user, span_notice(examine_block("[build_label_text(source)]")))
|
|
|
|
/**
|
|
*
|
|
* Compiles a warning label detailing various statistics of the examined weapon
|
|
*
|
|
* This function is called by the "examine" function of Topic(), and compiles a number of relevant
|
|
* weapon stats into a message that is then shown to the user
|
|
* Arguments:
|
|
* * source - The object whose stats are being examined
|
|
*/
|
|
/datum/element/weapon_description/proc/build_label_text(obj/item/source)
|
|
var/list/readout = list() // Readout is used to store the text block output to the user so it all can be sent in one message
|
|
|
|
// Doesn't show the base notes for items that have the override notes variable set to true
|
|
if(!source.override_notes)
|
|
if (source.sharpness & SHARP_EDGED)
|
|
readout += "It's sharp and could cause bleeding wounds."
|
|
if (source.sharpness & SHARP_POINTY)
|
|
readout += "It's pointy and could cause piercing wounds."
|
|
// Make sure not to divide by 0 on accident
|
|
if(source.force > 0)
|
|
readout += "It takes about [span_warning("[HITS_TO_CRIT(source.force)] melee hit\s")] to take down an enemy."
|
|
else
|
|
readout += "It does not deal noticeable melee damage."
|
|
|
|
if(source.throwforce > 0)
|
|
readout += "It takes about [span_warning("[HITS_TO_CRIT(source.throwforce)] throwing hit\s")] to take down an enemy."
|
|
else
|
|
readout += "It does not deal noticeable throwing damage."
|
|
if(source.armour_penetration > 0 || source.block_chance > 0)
|
|
readout += "It has [span_warning("[weapon_tag_convert(source.armour_penetration)]")] armor-piercing capability and [span_warning("[weapon_tag_convert(source.block_chance)]")] blocking capability."
|
|
// Custom manual notes
|
|
if(source.offensive_notes)
|
|
readout += source.offensive_notes
|
|
|
|
// Check if we have an additional proc, if so, add it to the readout
|
|
if(attached_proc)
|
|
readout += call(source, attached_proc)()
|
|
|
|
// Finally bringing the fields together
|
|
return readout.Join("\n")
|
|
|
|
/**
|
|
*
|
|
* Converts percentile based stats to an adjective appropriate for the
|
|
* examined warning label
|
|
*
|
|
* Arguments:
|
|
* * tag_val: The value of the item to be added to the tag
|
|
*/
|
|
/datum/element/weapon_description/proc/weapon_tag_convert(tag_val)
|
|
switch(tag_val)
|
|
if(0)
|
|
return "NO"
|
|
if(1 to 25)
|
|
return "LITTLE"
|
|
if(26 to 50)
|
|
return "AVERAGE"
|
|
if(51 to 75)
|
|
return "ABOVE-AVERAGE"
|
|
if(76 to INFINITY)
|
|
return "EXCELLENT"
|
|
else
|
|
return "WEIRD"
|