Files
Bubberstation/code/modules/atmospherics/machinery/components/binary_devices/valve.dm
SkyratBot 4d6935de5a [MIRROR] Add valve opening sound to manual valve (#28232)
* Add valve opening sound to manual valve (#84049)

## About The Pull Request
Adds a squeaky turning sound and hissing sound to opening valve
## Why It's Good For The Game

https://github.com/tgstation/tgstation/assets/92416224/9213a1bd-9bf9-4e49-97b2-0ceb2830a4ad

## Changelog
🆑
sound: added squeaky turn and gas hissing sound to gas valve
/🆑

* Add valve opening sound to manual valve

---------

Co-authored-by: FinancialGoose <92416224+TheBoondock@users.noreply.github.com>
2024-06-18 00:27:39 +01:00

196 lines
6.5 KiB
Plaintext

/*
It's like a regular ol' straight pipe, but you can turn it on and off.
*/
#define MANUAL_VALVE "m"
#define DIGITAL_VALVE "d"
/obj/machinery/atmospherics/components/binary/valve
icon_state = "mvalve_map-3"
name = "manual valve"
desc = "A pipe with a valve that can be used to disable flow of gas through it."
can_unwrench = TRUE
shift_underlay_only = FALSE
interaction_flags_machine = INTERACT_MACHINE_OFFLINE | INTERACT_MACHINE_OPEN //Intentionally no allow_silicon flag
pipe_flags = PIPING_CARDINAL_AUTONORMALIZE | PIPING_BRIDGE
construction_type = /obj/item/pipe/binary
pipe_state = "mvalve"
custom_reconcilation = TRUE
use_power = NO_POWER_USE
///Type of valve (manual or digital), used to set the icon of the component in update_icon_nopipes()
var/valve_type = MANUAL_VALVE
///Bool to stop interactions while the opening/closing animation is going
var/switching = FALSE
/obj/machinery/atmospherics/components/binary/valve/update_icon_nopipes(animation = FALSE)
normalize_cardinal_directions()
if(animation)
flick("[valve_type]valve_[on][!on]-[set_overlay_offset(piping_layer)]", src)
playsound(src, 'sound/effects/valve_opening.ogg', 50)
icon_state = "[valve_type]valve_[on ? "on" : "off"]-[set_overlay_offset(piping_layer)]"
/**
* Called by finish_interact(), switch between open and closed, reconcile the air between two pipelines
*/
/obj/machinery/atmospherics/components/binary/valve/proc/set_open(to_open)
if(on == to_open)
return
SEND_SIGNAL(src, COMSIG_VALVE_SET_OPEN, to_open)
. = on
on = to_open
if(on)
playsound(src, 'sound/effects/gas_hissing.ogg', 50)
update_icon_nopipes()
update_parents()
var/datum/pipeline/parent1 = parents[1]
parent1.reconcile_air()
investigate_log("was opened by [usr ? key_name(usr) : "a remote signal"]", INVESTIGATE_ATMOS)
balloon_alert_to_viewers("valve opened")
vent_movement |= VENTCRAWL_ALLOWED
else
update_icon_nopipes()
investigate_log("was closed by [usr ? key_name(usr) : "a remote signal"]", INVESTIGATE_ATMOS)
balloon_alert_to_viewers("valve closed")
vent_movement &= ~VENTCRAWL_ALLOWED
// This is what handles the actual functionality of combining 2 pipenets when the valve is open
// Basically when a pipenet updates it will consider both sides to be the same for the purpose of the gas update
/obj/machinery/atmospherics/components/binary/valve/return_pipenets_for_reconcilation(datum/pipeline/requester)
. = ..()
if(!on)
return
. |= parents[1]
. |= parents[2]
/obj/machinery/atmospherics/components/binary/valve/interact(mob/user)
add_fingerprint(usr)
if(switching)
return
update_icon_nopipes(TRUE)
switching = TRUE
addtimer(CALLBACK(src, PROC_REF(finish_interact)), 1 SECONDS)
/**
* Called by iteract() after a 1 second timer, calls toggle(), allows another interaction with the component.
*/
/obj/machinery/atmospherics/components/binary/valve/proc/finish_interact()
set_open(!on)
switching = FALSE
/obj/machinery/atmospherics/components/binary/valve/digital // can be controlled by AI
icon_state = "dvalve_map-3"
name = "digital valve"
desc = "A digitally controlled valve."
valve_type = DIGITAL_VALVE
pipe_state = "dvalve"
interaction_flags_machine = INTERACT_MACHINE_ALLOW_SILICON | INTERACT_MACHINE_OFFLINE | INTERACT_MACHINE_OPEN | INTERACT_MACHINE_OPEN_SILICON
/obj/machinery/atmospherics/components/binary/valve/digital/Initialize(mapload)
. = ..()
AddComponent(/datum/component/usb_port, list(/obj/item/circuit_component/digital_valve))
/obj/item/circuit_component/digital_valve
display_name = "Digital Valve"
desc = "The interface for communicating with a digital valve."
var/obj/machinery/atmospherics/components/binary/valve/digital/attached_valve
/// Opens the digital valve
var/datum/port/input/open
/// Closes the digital valve
var/datum/port/input/close
/// Whether the valve is currently open
var/datum/port/output/is_open
/// Sent when the valve is opened
var/datum/port/output/opened
/// Sent when the valve is closed
var/datum/port/output/closed
/obj/item/circuit_component/digital_valve/populate_ports()
open = add_input_port("Open", PORT_TYPE_SIGNAL)
close = add_input_port("Close", PORT_TYPE_SIGNAL)
is_open = add_output_port("Is Open", PORT_TYPE_NUMBER)
opened = add_output_port("Opened", PORT_TYPE_SIGNAL)
closed = add_output_port("Closed", PORT_TYPE_SIGNAL)
/obj/item/circuit_component/digital_valve/register_usb_parent(atom/movable/shell)
. = ..()
if(istype(shell, /obj/machinery/atmospherics/components/binary/valve/digital))
attached_valve = shell
RegisterSignal(attached_valve, COMSIG_VALVE_SET_OPEN, PROC_REF(handle_valve_toggled))
/obj/item/circuit_component/digital_valve/unregister_usb_parent(atom/movable/shell)
UnregisterSignal(attached_valve, COMSIG_VALVE_SET_OPEN)
attached_valve = null
return ..()
/obj/item/circuit_component/digital_valve/proc/handle_valve_toggled(datum/source, on)
SIGNAL_HANDLER
is_open.set_output(on)
if(on)
opened.set_output(COMPONENT_SIGNAL)
else
closed.set_output(COMPONENT_SIGNAL)
/obj/item/circuit_component/digital_valve/input_received(datum/port/input/port)
if(!attached_valve)
return
if(COMPONENT_TRIGGERED_BY(open, port) && !attached_valve.on)
attached_valve.set_open(TRUE)
if(COMPONENT_TRIGGERED_BY(close, port) && attached_valve.on)
attached_valve.set_open(FALSE)
/obj/machinery/atmospherics/components/binary/valve/digital/update_icon_nopipes(animation)
if(!is_operational)
normalize_cardinal_directions()
icon_state = "dvalve_nopower-[set_overlay_offset(piping_layer)]"
return
return..()
/obj/machinery/atmospherics/components/binary/valve/layer2
piping_layer = 2
icon_state = "mvalve_map-2"
/obj/machinery/atmospherics/components/binary/valve/layer4
piping_layer = 4
icon_state = "mvalve_map-4"
/obj/machinery/atmospherics/components/binary/valve/on
on = TRUE
/obj/machinery/atmospherics/components/binary/valve/on/layer2
piping_layer = 2
icon_state = "mvalve_map-2"
/obj/machinery/atmospherics/components/binary/valve/on/layer4
piping_layer = 4
icon_state = "mvalve_map-4"
/obj/machinery/atmospherics/components/binary/valve/digital/layer2
piping_layer = 2
icon_state = "dvalve_map-2"
/obj/machinery/atmospherics/components/binary/valve/digital/layer4
piping_layer = 4
icon_state = "dvalve_map-4"
/obj/machinery/atmospherics/components/binary/valve/digital/on
on = TRUE
/obj/machinery/atmospherics/components/binary/valve/digital/on/layer2
piping_layer = 2
icon_state = "dvalve_map-2"
/obj/machinery/atmospherics/components/binary/valve/digital/on/layer4
piping_layer = 4
icon_state = "dvalve_map-4"
#undef MANUAL_VALVE
#undef DIGITAL_VALVE