mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-15 20:22:07 +00:00
Fixes #86784
## About The Pull Request
Although some of the issues found were a direct result from #86692
(c698196766), there was still 40% of
length-related issues that wouldn't be covered anyways that are fixed in
this PR. I.E.:
* Name inputs without `MAX_NAME_LEN`
* Desc inputs without `MAX_DESC_LEN`
* Plaque inputs without `MAX_PLAQUE_LEN`
* Some people just screwed up the arguments so it would prefill
something like "40" in the `default` var because they didn't name their
vars.
To help me audit I added a lot of `max_length` named arguments to help
people understand it better. I think it might be kinder to have a
wrapper that handles adding `MAX_MESSAGE_LEN` in a lot of these cases
but I think there is some reason for a coder to be cognitive about input
texts? Let me know what you think. I didn't update anything
admin-related from what I can recall, let me know if anything needs to
be unlimited again.
## Why It's Good For The Game
The change to `INFINITY` notwithstanding, there were still an abundance
of issues that we needed to check up on. A lot of these are filtered on
down the line but it is clear that there needs to be something to catch
these issues. Maybe we could lint to make `max_length` a mandatory
argument? I don't know if that's necessary at all but I think that the
limit should be set by the invoker due to the wide arrangement of cases
that this proc could be used in.
This could all be a big nothingburger if the aforementioned PR is
reverted but a big chunk of cases fixed in this PR need to be fixed
regardless of that since people could put in 1024 character names for
stuff like guardians (or more now with the change). Consider this
"revert agnostic".
## Changelog
🆑
fix: A lot of instances where you could fill in 1024-character names
(normal limit is 42) have been patched out, along with too-long plaque
names, too-long descriptions, and more.
/🆑
185 lines
5.7 KiB
Plaintext
185 lines
5.7 KiB
Plaintext
///Global GPS_list. All GPS components get saved in here for easy reference.
|
|
GLOBAL_LIST_EMPTY(GPS_list)
|
|
///GPS component. Atoms that have this show up on gps. Pretty simple stuff.
|
|
/datum/component/gps
|
|
var/gpstag = "COM0"
|
|
var/tracking = TRUE
|
|
var/emped = FALSE
|
|
|
|
/datum/component/gps/Initialize(_gpstag = "COM0")
|
|
if(!isatom(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
gpstag = _gpstag
|
|
GLOB.GPS_list += src
|
|
|
|
/datum/component/gps/Destroy()
|
|
GLOB.GPS_list -= src
|
|
return ..()
|
|
|
|
/datum/component/gps/kheiral_cuffs
|
|
|
|
/datum/component/gps/kheiral_cuffs/Initialize(_gpstag = "COM0")
|
|
. = ..()
|
|
RegisterSignal(parent, COMSIG_ITEM_DROPPED, PROC_REF(deactivate_kheiral_cuffs))
|
|
|
|
/datum/component/gps/kheiral_cuffs/proc/deactivate_kheiral_cuffs(datum/source)
|
|
SIGNAL_HANDLER
|
|
qdel(src)
|
|
|
|
///GPS component subtype. Only gps/item's can be used to open the UI.
|
|
/datum/component/gps/item
|
|
var/updating = TRUE //Automatic updating of GPS list. Can be set to manual by user.
|
|
var/global_mode = TRUE //If disabled, only GPS signals of the same Z level are shown
|
|
/// UI state of GPS, altering when it can be used.
|
|
var/datum/ui_state/state = null
|
|
|
|
/datum/component/gps/item/Initialize(_gpstag = "COM0", emp_proof = FALSE, state = null, overlay_state = "working")
|
|
. = ..()
|
|
if(. == COMPONENT_INCOMPATIBLE || !isitem(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
|
|
if(isnull(state))
|
|
state = GLOB.default_state
|
|
src.state = state
|
|
|
|
var/atom/A = parent
|
|
if(overlay_state)
|
|
A.add_overlay(overlay_state)
|
|
A.name = "[initial(A.name)] ([gpstag])"
|
|
RegisterSignal(parent, COMSIG_ITEM_ATTACK_SELF, PROC_REF(interact))
|
|
if(!emp_proof)
|
|
RegisterSignal(parent, COMSIG_ATOM_EMP_ACT, PROC_REF(on_emp_act))
|
|
RegisterSignal(parent, COMSIG_ATOM_EXAMINE, PROC_REF(on_examine))
|
|
RegisterSignal(parent, COMSIG_CLICK_ALT, PROC_REF(on_click_alt))
|
|
|
|
///Called on COMSIG_ITEM_ATTACK_SELF
|
|
/datum/component/gps/item/proc/interact(datum/source, mob/user)
|
|
SIGNAL_HANDLER
|
|
|
|
if(user)
|
|
INVOKE_ASYNC(src, PROC_REF(ui_interact), user)
|
|
|
|
///Called on COMSIG_ATOM_EXAMINE
|
|
/datum/component/gps/item/proc/on_examine(datum/source, mob/user, list/examine_list)
|
|
SIGNAL_HANDLER
|
|
|
|
examine_list += span_notice("Alt-click to switch it [tracking ? "off":"on"].")
|
|
|
|
///Called on COMSIG_ATOM_EMP_ACT
|
|
/datum/component/gps/item/proc/on_emp_act(datum/source, severity, protection)
|
|
SIGNAL_HANDLER
|
|
if(protection & EMP_PROTECT_SELF)
|
|
return
|
|
emped = TRUE
|
|
var/atom/A = parent
|
|
A.cut_overlay("working")
|
|
A.add_overlay("emp")
|
|
addtimer(CALLBACK(src, PROC_REF(reboot)), 300, TIMER_UNIQUE|TIMER_OVERRIDE) //if a new EMP happens, remove the old timer so it doesn't reactivate early
|
|
SStgui.close_uis(src) //Close the UI control if it is open.
|
|
|
|
///Restarts the GPS after getting turned off by an EMP.
|
|
/datum/component/gps/item/proc/reboot()
|
|
emped = FALSE
|
|
var/atom/A = parent
|
|
A.cut_overlay("emp")
|
|
A.add_overlay("working")
|
|
|
|
///Calls toggletracking
|
|
/datum/component/gps/item/proc/on_click_alt(datum/source, mob/user)
|
|
SIGNAL_HANDLER
|
|
|
|
toggletracking(user)
|
|
return CLICK_ACTION_SUCCESS
|
|
|
|
///Toggles the tracking for the gps
|
|
/datum/component/gps/item/proc/toggletracking(mob/user)
|
|
if(!user.can_perform_action(parent))
|
|
return //user not valid to use gps
|
|
if(emped)
|
|
to_chat(user, span_warning("It's busted!"))
|
|
return
|
|
var/atom/A = parent
|
|
if(tracking)
|
|
A.cut_overlay("working")
|
|
to_chat(user, span_notice("[parent] is no longer tracking, or visible to other GPS devices."))
|
|
tracking = FALSE
|
|
else
|
|
A.add_overlay("working")
|
|
to_chat(user, span_notice("[parent] is now tracking, and visible to other GPS devices."))
|
|
tracking = TRUE
|
|
|
|
/datum/component/gps/item/ui_interact(mob/user, datum/tgui/ui)
|
|
if(emped)
|
|
to_chat(user, span_hear("[parent] fizzles weakly."))
|
|
return
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "Gps")
|
|
ui.open()
|
|
ui.set_autoupdate(updating)
|
|
|
|
/datum/component/gps/item/ui_state(mob/user)
|
|
return state
|
|
|
|
/datum/component/gps/item/ui_data(mob/user)
|
|
var/list/data = list()
|
|
data["power"] = tracking
|
|
data["tag"] = gpstag
|
|
data["updating"] = updating
|
|
data["globalmode"] = global_mode
|
|
if(!tracking || emped) //Do not bother scanning if the GPS is off or EMPed
|
|
return data
|
|
|
|
var/turf/curr = get_turf(parent)
|
|
data["currentArea"] = "[get_area_name(curr, TRUE)]"
|
|
data["currentCoords"] = "[curr.x], [curr.y], [curr.z]"
|
|
|
|
var/list/signals = list()
|
|
data["signals"] = list()
|
|
|
|
for(var/gps in GLOB.GPS_list)
|
|
var/datum/component/gps/G = gps
|
|
if(G.emped || !G.tracking || G == src)
|
|
continue
|
|
var/turf/pos = get_turf(G.parent)
|
|
if(!pos || !global_mode && pos.z != curr.z)
|
|
continue
|
|
var/list/signal = list()
|
|
signal["entrytag"] = G.gpstag //Name or 'tag' of the GPS
|
|
signal["coords"] = "[pos.x], [pos.y], [pos.z]"
|
|
if(pos.z == curr.z) //Distance/Direction calculations for same z-level only
|
|
signal["dist"] = max(get_dist(curr, pos), 0) //Distance between the src and remote GPS turfs
|
|
signal["degrees"] = round(get_angle(curr, pos)) //0-360 degree directional bearing, for more precision.
|
|
signals += list(signal) //Add this signal to the list of signals
|
|
data["signals"] = signals
|
|
return data
|
|
|
|
/datum/component/gps/item/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
|
|
switch(action)
|
|
if("rename")
|
|
var/atom/parentasatom = parent
|
|
var/a = tgui_input_text(usr, "Enter the desired tag", "GPS Tag", gpstag, max_length = 20)
|
|
if (QDELETED(ui) || ui.status != UI_INTERACTIVE)
|
|
return
|
|
if (!a)
|
|
return
|
|
|
|
gpstag = a
|
|
. = TRUE
|
|
usr.log_message("renamed [parentasatom] to \"[initial(parentasatom.name)] ([gpstag])\".", LOG_GAME)
|
|
parentasatom.name = "[initial(parentasatom.name)] ([gpstag])"
|
|
|
|
if("power")
|
|
toggletracking(usr)
|
|
. = TRUE
|
|
if("updating")
|
|
updating = !updating
|
|
. = TRUE
|
|
if("globalmode")
|
|
global_mode = !global_mode
|
|
. = TRUE
|