Lucy a2a43e2851 Fix some new dreamchecker lints (#91844) ...

## About The Pull Request

https://github.com/SpaceManiac/SpacemanDMM/pull/435 added a new
dreamchecker lint, for SDMM `set` statements not at the top of the proc.

While this lint isn't in the current SDMM _release_, I was testing it
out earlier and saw these issues, so might as well fix them before they
even become an issue.

i also fixed a useless variable in moon heretic code that was right next
to the incorrectly placed `SIGNAL_HANDLER`

## Why It's Good For The Game


https://github.com/user-attachments/assets/5b063f41-32f3-490a-b0a3-199ca8147ec3

## Changelog

No player-facing changes.

2025-06-27 16:16:12 -06:00

..

actionspeed

…

admin

Telecomms Update: Ability to change existing radio channels and create new ones (#91647)

2025-06-28 01:19:18 +10:00

antagonists

Fix some new dreamchecker lints (#91844)

2025-06-27 16:16:12 -06:00

art

Ghosts can't haunt canvases (#91759)

2025-06-22 17:18:31 +00:00

assembly

Telecomms Update: Ability to change existing radio channels and create new ones (#91647)

2025-06-28 01:19:18 +10:00

asset_cache

Fix the dozen or so lingering spritesheet errors caused by GAGS map icons (#91469)

2025-06-06 20:30:33 -04:00

atmospherics

Makes vendors created from flatpacks start empty to prevent duping (#91670)

2025-06-20 20:15:41 +00:00

autowiki

Simplifies fish traits inheritability a little (#90014)

2025-03-22 11:39:39 +01:00

awaymissions

Re-refactors batons / Refactors attack chain force modifiers (#90809)

2025-05-19 13:32:12 +10:00

balloon_alert

Balloon alerts don't balloon alert for non-runechat users (#91441)

2025-06-06 23:12:31 -04:00

basketball

Fixes dunking (#91769)

2025-06-26 13:29:53 -05:00

bitrunning

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

buildmode

Sets prettier to run on the repo (#91379)

2025-05-29 21:23:59 -07:00

capture_the_flag

Mutation code cleanup, mutations now have sources to avoid concurrency problems. (#91346)

2025-06-08 13:57:10 +02:00

cards

You can now read what cards are in a hand of cards + a related bugfix (#91279)

2025-05-22 12:57:35 -04:00

cargo

Makes vendors created from flatpacks start empty to prevent duping (#91670)

2025-06-20 20:15:41 +00:00

chatter

…

client

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

clothing

Telecomms Update: Ability to change existing radio channels and create new ones (#91647)

2025-06-28 01:19:18 +10:00

deathmatch

Mutation code cleanup, mutations now have sources to avoid concurrency problems. (#91346)

2025-06-08 13:57:10 +02:00

debugging

fix byond-tracy not actually setting trace_path (#90964)

2025-05-09 17:34:58 -07:00

detectivework

Part 4: Storage Improvements (#90783)

2025-05-02 23:25:58 +02:00

discord

Unfucks /datum/browse code (#89994)

2025-04-25 17:36:34 -04:00

economy

Re-refactors batons / Refactors attack chain force modifiers (#90809)

2025-05-19 13:32:12 +10:00

emoji

IconForge: rust-g Spritesheet Generation (#89478)

2025-03-03 14:58:27 +01:00

emote_panel

…

engineering/tools

Fix multitool arrow hard delete (#91114)

2025-05-14 14:58:07 -07:00

error_handler

Unfucks /datum/browse code (#89994)

2025-04-25 17:36:34 -04:00

escape_menu

Planecube Optimizations and Job Security: Part One (#91696)

2025-06-18 21:00:23 -07:00

events

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

experisci

Re-refactors batons / Refactors attack chain force modifiers (#90809)

2025-05-19 13:32:12 +10:00

explorer_drone

Removes un-needed calls to RefreshParts() (#91564)

2025-06-19 06:16:56 +02:00

fishing

Fix some new dreamchecker lints (#91844)

2025-06-27 16:16:12 -06:00

flufftext

Cleans up mood and mood-related code (#90162)

2025-03-24 13:53:03 +01:00

food_and_drinks

Makes vendors created from flatpacks start empty to prevent duping (#91670)

2025-06-20 20:15:41 +00:00

forensics

Audits wash/cleaning signals + refactors wash() to ensure no needless mob updates occur (#91259)

2025-06-02 18:54:53 +00:00

hallucination

Telecomms Update: Ability to change existing radio channels and create new ones (#91647)

2025-06-28 01:19:18 +10:00

holiday

Adds Goth Day (May 22) as a Holiday (#91222)

2025-05-22 09:46:01 -07:00

holodeck

Re-refactors batons / Refactors attack chain force modifiers (#90809)

2025-05-19 13:32:12 +10:00

hydroponics

Removes un-needed calls to RefreshParts() (#91564)

2025-06-19 06:16:56 +02:00

instruments

Re-refactors batons / Refactors attack chain force modifiers (#90809)

2025-05-19 13:32:12 +10:00

interview

Interviews now lets you see centcom bans directly (#90423)

2025-04-06 21:06:58 +02:00

jobs

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

keybindings

Sets prettier to run on the repo (#91379)

2025-05-29 21:23:59 -07:00

language

Adds Common Second Language quirk, tweaks to partial understanding (#90614)

2025-04-21 04:18:05 +01:00

library

Adds a new halloween species: Spirits (#90711)

2025-06-22 10:02:06 +02:00

lighting

The big fix for pixel_x and pixel_y use cases. (#90124)

2025-03-28 14:18:45 +00:00

loadout

Adds automatic GAGS icon generation for mapping and the loadout menu (#90940)

2025-05-24 15:21:02 -07:00

logging

update rust-g to 3.9.0 and use formatted_timestamp for human_readable_timestamp (#91121)

2025-05-14 14:56:37 -07:00

lootpanel

…

lost_crew

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

mafia

Adds Greyscale Trenchcoats/Blazers (+ toggleable trenchcoats) (#90563)

2025-04-13 08:21:50 -04:00

manufactorio

Crafting refactor, implementing materials (#89465)

2025-06-01 16:37:43 -07:00

mapfluff

Adds some throwing datum nullchecks (#91720)

2025-06-20 11:25:16 -06:00

mapping

Adds a wall dent mapping helper (#91484)

2025-06-07 00:06:39 -04:00

meteors

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

mining

Telecomms Update: Ability to change existing radio channels and create new ones (#91647)

2025-06-28 01:19:18 +10:00

mob

Fix some new dreamchecker lints (#91844)

2025-06-27 16:16:12 -06:00

mob_spawn

Sanitizes ghost spawners' names when adding them to GLOB.mob_spawners because \improper is still a pain in the ass (#91692)

2025-06-19 16:08:31 -06:00

mod

Telecomms Update: Ability to change existing radio channels and create new ones (#91647)

2025-06-28 01:19:18 +10:00

modular_computers

Fix some new dreamchecker lints (#91844)

2025-06-27 16:16:12 -06:00

movespeed

Flying mobs no longer have 3x worse damage slowdown (#91710)

2025-06-20 11:25:40 -06:00

NTNet

…

pai

Re-refactors batons / Refactors attack chain force modifiers (#90809)

2025-05-19 13:32:12 +10:00

paperwork

Rebalances wound determination values, wounding escalation and wound armor to hopefully be less explosive (#91099)

2025-06-19 17:49:59 +02:00

photography

Adds a new halloween species: Spirits (#90711)

2025-06-22 10:02:06 +02:00

plumbing

Removes REAGENT_NOSPLIT flag (#91526)

2025-06-14 19:59:32 +02:00

point

The big fix for pixel_x and pixel_y use cases. (#90124)

2025-03-28 14:18:45 +00:00

power

Prevents solar panel assemblies from being anchored on an occupied tile or on each other (#91613)

2025-06-23 15:52:25 +01:00

procedural_mapping

Sets prettier to run on the repo (#91379)

2025-05-29 21:23:59 -07:00

projectiles

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

reagents

Rebalances wound determination values, wounding escalation and wound armor to hopefully be less explosive (#91099)

2025-06-19 17:49:59 +02:00

recycling

Stacks check for invalid amounts (#91656)

2025-06-18 15:28:35 +02:00

religion

Adds a new halloween species: Spirits (#90711)

2025-06-22 10:02:06 +02:00

requests

Refactor GLOB.admin/debug/fun_state into cached /datum/ui_state/admin_state instances (#89417)

2025-02-17 00:54:00 +01:00

research

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

security_levels

PDA Alert Level Readout (#89173)

2025-03-13 12:25:57 +01:00

shuttle

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

spatial_grid

…

spells

Mob ckey sanity check now respects insano aghost code (#91517)

2025-06-08 15:09:54 -06:00

station_goals

Mutation code cleanup, mutations now have sources to avoid concurrency problems. (#91346)

2025-06-08 13:57:10 +02:00

surgery

correct message for dental implants insertion (#91782)

2025-06-26 06:57:18 +02:00

tgchat

Sets prettier to run on the repo (#91379)

2025-05-29 21:23:59 -07:00

tgs

Sets prettier to run on the repo (#91379)

2025-05-29 21:23:59 -07:00

tgui

Mutation code cleanup, mutations now have sources to avoid concurrency problems. (#91346)

2025-06-08 13:57:10 +02:00

tgui_input

makes various uis more compatible with high dpi monitors, adds a preference for smaller windows (#90418)

2025-04-06 21:54:57 +02:00

tgui_panel

Prevents protected audio from crashing the server with no survivors (#90975)

2025-05-04 16:39:43 +00:00

tooltip

Sets prettier to run on the repo (#91379)

2025-05-29 21:23:59 -07:00

transport

Makes vendors created from flatpacks start empty to prevent duping (#91670)

2025-06-20 20:15:41 +00:00

tutorials

You can now interact with held mobs beside wearing them (feat: "minor" melee attack chain cleanup) (#90080)

2025-04-23 20:18:26 +00:00

unit_tests

Dynamic Rework (#91290)

2025-06-25 17:36:10 -07:00

uplink

Updates the mech ammo duffel bags into two separate types for each kind of mech. Each with equivalent ammunition and the toolbelt. (#91711)

2025-06-21 03:12:29 +02:00

vehicles

Definitely fixes Phazons for realzies (#91763)

2025-06-27 14:40:59 +02:00

vending

Makes vendors created from flatpacks start empty to prevent duping (#91670)

2025-06-20 20:15:41 +00:00

visuals

…

wiremod

Telecomms Update: Ability to change existing radio channels and create new ones (#91647)

2025-06-28 01:19:18 +10:00

zombie

Rebalances wound determination values, wounding escalation and wound armor to hopefully be less explosive (#91099)

2025-06-19 17:49:59 +02:00