mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-18 18:47:53 +01:00
edd0b68a54
## About The Pull Request This PR improves motorized wheelchairs in the following ways: - On initialize, motorized wheelchairs will have the most basic possible stock parts inserted. This resolves a bug where motorized wheelchairs spawned by admins or other means (mail, mapping) were completely worthless, as they had no stock parts in them and you could not insert better ones. When crafted, these basic parts are deleted and replaced with the correct ones. - Power cells are now part of the motorized wheelchair recipe, instead of being inserted after. - When deconstructed or destroyed, motorized wheelchairs now drop their power cell on the floor with everything else instead of deleting it from existence. - Miscellaneous old code has been tidied up, removing one-letter var names, pointless code duplication, and the like. ## Why It's Good For The Game I've been talking to Dalm about this, and wheelchairs are in dire need of some improvements. Tidying up the mess that is the motorized wheelchair seemed like a good place to start. Firstly, it's good for motorized wheelchairs to function as expected when not specifically crafted by hand. This is helpful to admins, mappers, and anyone else who might have reason to make one of these appear. It's also good that all the parts in the wheelchair drop on the ground when destroyed, as there's no particular reason power cells should be lost. As for power cells being included in the recipe - it's not obvious at a glance that you _need_ to insert a power cell after crafting, until you try to drive your new wheelchair around. This extra step of annoyance is now avoided by making it required to stick one in when you build the thing. ## Changelog 🆑 fix: Motorized wheelchairs will no longer spawn in a bugged state where they have no parts and can't be upgraded. fix: Motorized wheelchairs will drop their power cell when destroyed or deconstructed. qol: Power cells are now inserted into motorized wheelchairs as part of the crafting recipe, instead of as an extra step afterwards. /🆑 --------- Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com>