mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-08 07:18:17 +00:00
b116ec2789
* TGUI replaces Radial menu for Plumbing RCD (#71569) **About the pull request** Radial menu's replaced with TGUI window for all plumbing RCD's https://user-images.githubusercontent.com/110812394/204481973-8f6d62c0-9288-4165-bce7-ee8bfec95bee.mp4 **Why it's good for the game** **1. Faster Navigation** - Old System: It had 3 radial menus' ->To select type of device to build ->To select the colour of fluid ducts ->To select the layer of devices 3 menus for one system makes navigation between them annoying for e.g.: to create a red fluid duct of layer 5 you have to open all these 3 menus & cycling through the radial menu by clicking the next button is time consuming when you have a large number of items - New System: with just one window open it's as simple as 3 clicks and your done just like the RPD **2. Always available** - Old System: When you select an option inside a radial menu the menu closes so you have to reopen it again to change a setting - New System: open the window drag it to the side and it will always be there for you **3. Just easier for our eyes** - Old System: Moving my eyes in a circle across the menu only to find out i have to click Next and circle my eyes again honestly makes my head spin - New System: The menu options are small enough to be viewed all at once & helps me see what I need more easily **4. Consistency** Both the RPD & plumbing all have similar concepts i.e., pipes, devices, layers & colours it only makes sense they should have similar interfaces. Also categorizing the items into tabs can help with explaining what each item does **Conclusion** Just because the radial menu looks attractive shouldn't mean it must be used everywhere, it only makes sense to use it when the number of options of an item is small enough to be displayed on the screen all at once for e.g., modules in a Mod suit. If the user has to click the next button to cycle through the item's, it defeats the purpose of the radial menu and makes the user work more to find his settings **Side Note :** removed unused code in RapidPipeDispenser.js **ChangeLog** 🆑 add: plumbing constructor TGUI, just like Rapid Pipe Dispensers del: plumbing constructor radials code: categories for each item /🆑 Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com> Co-authored-by: Jeremiah <42397676+jlsnow301@ users.noreply.github.com> Co-authored-by: Time-Green <timkoster1@ hotmail.com> * TGUI replaces Radial menu for Plumbing RCD Co-authored-by: SyncIt21 <110812394+SyncIt21@users.noreply.github.com> Co-authored-by: Mothblocks <35135081+Mothblocks@ users.noreply.github.com> Co-authored-by: Jeremiah <42397676+jlsnow301@ users.noreply.github.com> Co-authored-by: Time-Green <timkoster1@ hotmail.com>
54 lines
1.8 KiB
Plaintext
54 lines
1.8 KiB
Plaintext
///it splits the reagents however you want. So you can "every 60 units, 45 goes left and 15 goes straight". The side direction is EAST, you can change this in the component
|
|
/obj/machinery/plumbing/splitter
|
|
name = "chemical splitter"
|
|
desc = "A chemical splitter for smart chemical factorization. Waits till a set of conditions is met and then stops all input and splits the buffer evenly or other in two ducts."
|
|
icon_state = "splitter"
|
|
active_power_usage = BASE_MACHINE_ACTIVE_CONSUMPTION * 2
|
|
buffer = 100
|
|
density = FALSE
|
|
///category for plumbing RCD
|
|
category="Distribution"
|
|
|
|
///constantly switches between TRUE and FALSE. TRUE means the batch tick goes straight, FALSE means the next batch goes in the side duct.
|
|
var/turn_straight = TRUE
|
|
///how much we must transfer straight. note input can be as high as 10 reagents per process, usually
|
|
var/transfer_straight = 5
|
|
///how much we must transfer to the side
|
|
var/transfer_side = 5
|
|
//the maximum you can set the transfer to
|
|
var/max_transfer = 9
|
|
|
|
/obj/machinery/plumbing/splitter/Initialize(mapload, bolt, layer)
|
|
. = ..()
|
|
AddComponent(/datum/component/plumbing/splitter, bolt, layer)
|
|
|
|
/obj/machinery/plumbing/splitter/ui_interact(mob/user, datum/tgui/ui)
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "ChemSplitter", name)
|
|
ui.open()
|
|
|
|
/obj/machinery/plumbing/splitter/ui_data(mob/user)
|
|
var/list/data = list()
|
|
data["straight"] = transfer_straight
|
|
data["side"] = transfer_side
|
|
data["max_transfer"] = max_transfer
|
|
return data
|
|
|
|
/obj/machinery/plumbing/splitter/ui_act(action, params)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
. = TRUE
|
|
switch(action)
|
|
if("set_amount")
|
|
var/direction = params["target"]
|
|
var/value = clamp(text2num(params["amount"]), 1, max_transfer)
|
|
switch(direction)
|
|
if("straight")
|
|
transfer_straight = value
|
|
if("side")
|
|
transfer_side = value
|
|
else
|
|
return FALSE
|