mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-21 03:59:59 +01:00
Dani GloreandGitHub
495fde6a2c
## About The Pull Request This PR adds two new config options for quirks: - *Flag* `DISABLE_QUIRK_POINTS` - When enabled, disables quirk points balancing. - When enabled, players can select positive quirks without first selecting negative ones. - When enabled, the quirk points balance visually hides itself on the Quirks page. - *Number* `MAX_POSITIVE_QUIRKS` - Limits the maximum quantity of positive quirks which players can select using the Character Preferences page. - I ported this from the old `MAX_QUIRKS` define. - When set to `0`, players won't be able to select any positive quirks, and they won't appear on the Quirks page. - When set to `-1`, players will be able to select any quantity of positive quirks. - When commented-out or undefined, the default is `6`. - When set to `0` or `-1`, the positive quirk balance visually hides itself on the Quirks page. ## Why It's Good For The Game There is some downstream repositories asking for the quirks system to be configurable. Additionally, I always find myself tweaking these values on my own private servers and I thought it would be nice to share my edits. Usually I was simply commenting-out sections of this code in order to get the same result, so it helps to have an official way to disable quirk points. ## Changelog 🆑 A.C.M.O. config: Added two new config flags for quirks, DISABLE_QUIRK_POINTS and MAX_POSITIVE_QUIRKS. /🆑
105 lines
3.1 KiB
Plaintext
105 lines
3.1 KiB
Plaintext
/// Middleware to handle quirks
|
|
/datum/preference_middleware/quirks
|
|
var/tainted = FALSE
|
|
|
|
action_delegations = list(
|
|
"give_quirk" = PROC_REF(give_quirk),
|
|
"remove_quirk" = PROC_REF(remove_quirk),
|
|
)
|
|
|
|
/datum/preference_middleware/quirks/get_ui_static_data(mob/user)
|
|
if (preferences.current_window != PREFERENCE_TAB_CHARACTER_PREFERENCES)
|
|
return list()
|
|
|
|
var/list/data = list()
|
|
|
|
data["selected_quirks"] = get_selected_quirks()
|
|
|
|
return data
|
|
|
|
/datum/preference_middleware/quirks/get_ui_data(mob/user)
|
|
var/list/data = list()
|
|
|
|
if (tainted)
|
|
tainted = FALSE
|
|
data["selected_quirks"] = get_selected_quirks()
|
|
|
|
return data
|
|
|
|
/datum/preference_middleware/quirks/get_constant_data()
|
|
var/list/quirk_info = list()
|
|
|
|
var/list/quirks = SSquirks.get_quirks()
|
|
|
|
var/max_positive_quirks = CONFIG_GET(number/max_positive_quirks)
|
|
var/positive_quirks_disabled = max_positive_quirks == 0
|
|
for (var/quirk_name in quirks)
|
|
var/datum/quirk/quirk = quirks[quirk_name]
|
|
if(positive_quirks_disabled && initial(quirk.value) > 0)
|
|
continue
|
|
|
|
var/datum/quirk_constant_data/constant_data = GLOB.all_quirk_constant_data[quirk]
|
|
var/list/datum/preference/customization_options = constant_data?.get_customization_data()
|
|
|
|
quirk_info[sanitize_css_class_name(quirk_name)] = list(
|
|
"description" = initial(quirk.desc),
|
|
"icon" = initial(quirk.icon),
|
|
"name" = quirk_name,
|
|
"value" = initial(quirk.value),
|
|
"customizable" = constant_data?.is_customizable(),
|
|
"customization_options" = customization_options,
|
|
)
|
|
|
|
return list(
|
|
"max_positive_quirks" = max_positive_quirks,
|
|
"quirk_info" = quirk_info,
|
|
"quirk_blacklist" = GLOB.quirk_string_blacklist,
|
|
"points_enabled" = !CONFIG_GET(flag/disable_quirk_points),
|
|
)
|
|
|
|
/datum/preference_middleware/quirks/on_new_character(mob/user)
|
|
tainted = TRUE
|
|
|
|
/datum/preference_middleware/quirks/proc/give_quirk(list/params, mob/user)
|
|
var/quirk_name = params["quirk"]
|
|
|
|
var/list/new_quirks = preferences.all_quirks | quirk_name
|
|
if (SSquirks.filter_invalid_quirks(new_quirks) != new_quirks)
|
|
// If the client is sending an invalid give_quirk, that means that
|
|
// something went wrong with the client prediction, so we should
|
|
// catch it back up to speed.
|
|
preferences.update_static_data(user)
|
|
return TRUE
|
|
|
|
preferences.all_quirks = new_quirks
|
|
preferences.character_preview_view?.update_body()
|
|
|
|
return TRUE
|
|
|
|
/datum/preference_middleware/quirks/proc/remove_quirk(list/params, mob/user)
|
|
var/quirk_name = params["quirk"]
|
|
|
|
var/list/new_quirks = preferences.all_quirks - quirk_name
|
|
if ( \
|
|
!(quirk_name in preferences.all_quirks) \
|
|
|| SSquirks.filter_invalid_quirks(new_quirks) != new_quirks \
|
|
)
|
|
// If the client is sending an invalid remove_quirk, that means that
|
|
// something went wrong with the client prediction, so we should
|
|
// catch it back up to speed.
|
|
preferences.update_static_data(user)
|
|
return TRUE
|
|
|
|
preferences.all_quirks = new_quirks
|
|
preferences.character_preview_view?.update_body()
|
|
|
|
return TRUE
|
|
|
|
/datum/preference_middleware/quirks/proc/get_selected_quirks()
|
|
var/list/selected_quirks = list()
|
|
|
|
for (var/quirk in preferences.all_quirks)
|
|
selected_quirks += sanitize_css_class_name(quirk)
|
|
|
|
return selected_quirks
|