mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
a9cabfabb6
* Fixes Define Sanity (#77845) ## About The Pull Request Hey there, This was broken in an update from #74573 (3902973978), the RegEx was only catching a fraction of the cases it was meant to be. This is what we were finding on 74573 version of the RegEx:  This is what we should be finding for all of the cases that `define_sanity` will need to check for:  This is what was broken as a consequence:  As stated in the introductory PR #74333 (ccef887efe), it's not the end of the world if we miss unmanaged local defines, but it's still useful to have this as a maintainability tool to ensure that everything remains as clean as it possibly can. I wish we could do the whole matching method like the aforementioned PR supposed could happen, but it simply doesn't appear to work the way we want it to. ## Changelog Nothing player facing. I tried to experiment with `UNLINT()` but I got absolutely ganked by getting the regex to work, so the fix for the FA Icon file may not be super duper great unfortunately. Let me know if you have a showstopper idea, this is just a stopguard so this PR can get merged and I don't have to keep talking about unmanaged local defines while reviewing PRs. * Fixes Define Sanity --------- Co-authored-by: san7890 <the@san7890.com>