mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-26 09:32:21 +00:00
5a4c87a9fc
About The Pull Request Rewrites the entire preferences menu in tgui. Rewrites the entire backend to be built upon datumized preferences, rather than constant additions to the preferences base datum. Splits game preferences into its own window. Antagonists are now split into their individual rulesets. You can now be a roundstart heretic without signing up for latejoin heretic, as an example. This iteration matches parity, and provides very little new functionality, but adding anything new will be much easier. Fixes #60823 Fixes #28907 Fixes #44887 Fixes #59912 Fixes #58458 Fixes #59181 Major TODOs Quirk icons, from @Fikou (with some slight adjustments from me) Lore text, from @EOBGames (4/6, need moths and then ethereal lore from @AMonkeyThatCodes) Heavy documentation on how one would add new preferences, species, jobs, etc A lot of specialized testing so that people's real data don't get corrupted Changelog cl Mothblocks, Floyd on lots of the design refactor: The preferences menu has been completely rewritten in tgui. refactor: The "Stop Sounds" verb has been moved to OOC. /cl
52 lines
2.1 KiB
Plaintext
52 lines
2.1 KiB
Plaintext
/// Requires all preferences to implement required methods.
|
|
/datum/unit_test/preferences_implement_everything
|
|
|
|
/datum/unit_test/preferences_implement_everything/Run()
|
|
var/datum/preferences/preferences = new
|
|
var/mob/living/carbon/human/human = allocate(/mob/living/carbon/human)
|
|
|
|
for (var/preference_type in GLOB.preference_entries)
|
|
var/datum/preference/preference = GLOB.preference_entries[preference_type]
|
|
if (preference.savefile_identifier == PREFERENCE_CHARACTER)
|
|
preference.apply_to_human(human, preference.create_informed_default_value(preferences))
|
|
|
|
if (istype(preference, /datum/preference/choiced))
|
|
var/datum/preference/choiced/choiced_preference = preference
|
|
choiced_preference.init_possible_values()
|
|
|
|
// Smoke-test is_valid
|
|
preference.is_valid(TRUE)
|
|
preference.is_valid("string")
|
|
preference.is_valid(100)
|
|
preference.is_valid(list(1, 2, 3))
|
|
|
|
/// Requires all preferences to have a valid, unique savefile_identifier.
|
|
/datum/unit_test/preferences_valid_savefile_key
|
|
|
|
/datum/unit_test/preferences_valid_savefile_key/Run()
|
|
var/list/known_savefile_keys = list()
|
|
|
|
for (var/preference_type in GLOB.preference_entries)
|
|
var/datum/preference/preference = GLOB.preference_entries[preference_type]
|
|
if (!istext(preference.savefile_key))
|
|
Fail("[preference_type] has an invalid savefile_key.")
|
|
|
|
if (preference.savefile_key in known_savefile_keys)
|
|
Fail("[preference_type] has a non-unique savefile_key `[preference.savefile_key]`!")
|
|
|
|
known_savefile_keys += preference.savefile_key
|
|
|
|
/// Requires all main features have a main_feature_name
|
|
/datum/unit_test/preferences_valid_main_feature_name
|
|
|
|
/datum/unit_test/preferences_valid_main_feature_name/Run()
|
|
for (var/preference_type in GLOB.preference_entries)
|
|
var/datum/preference/choiced/preference = GLOB.preference_entries[preference_type]
|
|
if (!istype(preference))
|
|
continue
|
|
|
|
if (preference.category != PREFERENCE_CATEGORY_FEATURES && preference.category != PREFERENCE_CATEGORY_CLOTHING)
|
|
continue
|
|
|
|
TEST_ASSERT(!isnull(preference.main_feature_name), "Preference [preference_type] does not have a main_feature_name set!")
|