mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 09:42:29 +00:00
999bde8f84
## About The Pull Request Most screen alerts that use the midnight hud style no longer have the button baked in their icon. Other screen alerts with their own background or shape (robot and mech alerts, atmos, heretic buffs or debuffs etc.) are not affected. Also updated a couple sprites but didn't spend too much time on them. Mostly reusing existing assets. Montage of how the alerts look on threee different hud styles (Operative, Trasen-Knox, Detective, ALSO I FIXED THE BUCKLED ALERT ALREADY): <img width="293" height="323" alt="image" src="https://github.com/user-attachments/assets/3a2b972b-aa5a-4c27-a454-c8c39acf6e20" /> It looks only a smidge iffy on the syndicate since the top and bottom borders aren't layered over all the overlays, but it isn't something to worry about in this PR. ## Why It's Good For The Game Screen alerts always had the midnight hud button baked in their icon states (now overlays), which completely disregard the player's hud setting, much unlike action alerts buttons. Melbert has also said that it'd be nice if the code for action buttons could also be used in screen alerts and viceversa, to slim things down. That's obviously not what I'm doing today, but having most of the screen alerts already without the baked background will surely help if we ever pursue that objective. ## Changelog 🆑 refactor: Refactored screen alerts a little. Most should now fit the player's hud style. Report any issue. imageadd: A few screen alerts have been polished/updated a little. /🆑
78 lines
3.5 KiB
Plaintext
78 lines
3.5 KiB
Plaintext
/// These tests perform no behavior of their own, and have their tests offloaded onto other procs.
|
|
/// This is useful in cases like in build_appearance_list where we want to know if any fail,
|
|
/// but is not useful to right a test for.
|
|
/// This file exists so that you can change any of these to TEST_FOCUS and only check for that test.
|
|
/// For example, change /datum/unit_test/focus_only/invalid_overlays to TEST_FOCUS(/datum/unit_test/focus_only/invalid_overlays),
|
|
/// and you will only test the check for invalid overlays in appearance building.
|
|
/datum/unit_test/focus_only
|
|
|
|
/// Checks that every created emissive has a valid icon_state
|
|
/datum/unit_test/focus_only/invalid_emissives
|
|
|
|
/// Checks that every overlay passed into build_appearance_list exists in the icon
|
|
/datum/unit_test/focus_only/invalid_overlays
|
|
|
|
/// Checks that every screen alert with an overlay icon state is valid
|
|
/datum/unit_test/focus_only/screen_alert_overlay
|
|
|
|
/// Checks that every icon sent to the research_designs spritesheet is valid
|
|
/datum/unit_test/focus_only/invalid_research_designs
|
|
|
|
/// Checks that every icon sent to vending machines is valid
|
|
/datum/unit_test/focus_only/invalid_vending_machine_icon_states
|
|
|
|
/// Checks that space does not initialize multiple times
|
|
/datum/unit_test/focus_only/multiple_space_initialization
|
|
|
|
/// Checks that smoothing_groups and canSmoothWith are properly sorted in /atom/Initialize
|
|
/datum/unit_test/focus_only/sorted_smoothing_groups
|
|
|
|
/// Checks that floor tiles are properly mapped to broken/burnt
|
|
/datum/unit_test/focus_only/valid_turf_states
|
|
|
|
/// Checks that nightvision eyes have a full set of color lists
|
|
/datum/unit_test/focus_only/nightvision_color_cutoffs
|
|
|
|
/// Ensures that items that got the nullrod_core element with the chaptain_spawnable arg can be selected by the chaplain
|
|
/datum/unit_test/focus_only/nullrod_variants
|
|
|
|
/// Checks that no light shares a tile/pixel offsets with another
|
|
/datum/unit_test/focus_only/stacked_lights
|
|
|
|
/// Checks for bad icon / icon state setups in cooking crafting menu
|
|
/datum/unit_test/focus_only/bad_cooking_crafting_icons
|
|
|
|
/// Ensures openspace never spawns on the bottom of a z stack
|
|
/datum/unit_test/focus_only/openspace_clear
|
|
|
|
/// Checks to ensure that variables expected to exist in a job datum (for config reasons) actually exist
|
|
/datum/unit_test/focus_only/missing_job_datum_variables
|
|
|
|
/// Checks that the contents of the fish_counts list are also present in fish_table
|
|
/datum/unit_test/focus_only/fish_sources_tables
|
|
|
|
/**
|
|
* This will tell us if we forgot to properly set the stable population for any fish.
|
|
* Fish with a stable population of one or less need to have either the mateless or crossbreeder trait, or be compatible with
|
|
* other fish types with a higher stable population.
|
|
*/
|
|
/datum/unit_test/focus_only/fish_population
|
|
|
|
/// Checks that maploaded mobs with either the `atmos_requirements` or `body_temp_sensitive`
|
|
/datum/unit_test/focus_only/atmos_and_temp_requirements
|
|
|
|
/// Ensures only whitelisted planes can have TOPDOWN_LAYERing, and vis versa
|
|
/datum/unit_test/focus_only/topdown_filtering
|
|
|
|
/// Catches any invalid footstep types set for humans
|
|
/datum/unit_test/focus_only/humanstep_validity
|
|
|
|
/// Checks icon states generated at runtime are valid
|
|
/datum/unit_test/focus_only/runtime_icon_states
|
|
|
|
/// Checks that foodtypes are the same for food whether it's spawned or crafted (with the exact required types)
|
|
/datum/unit_test/focus_only/check_foodtypes
|
|
|
|
///Checks that items have roughly the same materials whenever spawned via processing/microwaving/baking etc. or any other mean.
|
|
/datum/unit_test/focus_only/check_materials_when_processed
|