mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
5f80128fa9
## About The Pull Request it's - conjunction of "it" and "is" its - possessive form of "it" grammar is hard, and there were a lot of places where "it's" was used where it shouldn't have been. i went and painstakingly searched the entire repository for these instances, spending a few hours on it. i completely ignored the changelog archive, and i may have missed some outliers. most player-facing ones should be corrected, though ## Why It's Good For The Game proper grammar is good ## Changelog 🆑 spellcheck: Numerous instances of "it's" have been properly replaced with "its" /🆑
100 lines
5.1 KiB
Plaintext
100 lines
5.1 KiB
Plaintext
/// Makes sure items with defined inhand_icon_states... actually have icons that exist!
|
|
/datum/unit_test/defined_inhand_icon_states
|
|
var/static/list/possible_icon_states = list()
|
|
var/fallback_log_message
|
|
var/unset_inhand_var_message
|
|
/// additional_inhands_location is for downstream modularity support. as an example, for skyrat's usage, set additional_inhands_location = "modular_skyrat/master_files/icons/mob/inhands/"
|
|
/// Make sure this location is also present in tools/deploy.sh
|
|
/// If you need additional paths ontop of this second one, you can add another generate_possible_icon_states_list("your/folder/path/inhands/") below the if(additional_inhands_location) block in Run(), and make sure to add that path to tools/deploy.sh as well.
|
|
var/additional_inhands_location = null
|
|
|
|
/datum/unit_test/defined_inhand_icon_states/proc/generate_possible_icon_states_list(directory_path)
|
|
if(!directory_path)
|
|
directory_path = "icons/mob/inhands/"
|
|
for(var/file_path in flist(directory_path))
|
|
if(findtext(file_path, ".dmi"))
|
|
for(var/sprite_icon in icon_states("[directory_path][file_path]", 1)) //2nd arg = 1 enables 64x64+ icon support, otherwise you'll end up with "sword0_1" instead of "sword"
|
|
possible_icon_states[sprite_icon] += list("[directory_path][file_path]")
|
|
else
|
|
possible_icon_states += generate_possible_icon_states_list("[directory_path][file_path]")
|
|
|
|
/datum/unit_test/defined_inhand_icon_states/Run()
|
|
generate_possible_icon_states_list()
|
|
if(additional_inhands_location)
|
|
generate_possible_icon_states_list(additional_inhands_location)
|
|
|
|
//Add EVEN MORE paths if needed here!
|
|
//generate_possible_icon_states_list("your/folder/path/inhands/")
|
|
|
|
for(var/obj/item/item_path as anything in subtypesof(/obj/item))
|
|
if(initial(item_path.item_flags) & ABSTRACT)
|
|
continue
|
|
|
|
var/skip_left
|
|
var/skip_right
|
|
if(initial(item_path.greyscale_colors)) //greyscale stuff has its own unit test.
|
|
skip_left = initial(item_path.greyscale_config_inhand_left)
|
|
skip_right = initial(item_path.greyscale_config_inhand_right)
|
|
if(skip_left && skip_right)
|
|
continue
|
|
|
|
var/lefthand_file = initial(item_path.lefthand_file)
|
|
var/righthand_file = initial(item_path.righthand_file)
|
|
|
|
var/held_icon_state = initial(item_path.inhand_icon_state)
|
|
if(!held_icon_state)
|
|
var/base_icon_state = initial(item_path.icon_state)
|
|
if(!isnull(base_icon_state) && lefthand_file && righthand_file) //Suggest inhand icons that match with the icon_state var.
|
|
var/missing_var_message
|
|
if(base_icon_state in possible_icon_states)
|
|
for(var/file_place in possible_icon_states[base_icon_state])
|
|
missing_var_message += (missing_var_message ? " & '[file_place]'" : " - Possible matching sprites for \"[base_icon_state]\" found in: '[file_place]'")
|
|
unset_inhand_var_message += "\n\t[item_path] does not have an inhand_icon_state value[missing_var_message]"
|
|
continue
|
|
|
|
var/match_message
|
|
if(held_icon_state in possible_icon_states)
|
|
for(var/file_place in possible_icon_states[held_icon_state])
|
|
match_message += (match_message ? " & '[file_place]'" : " - Matching sprite found in: '[file_place]'")
|
|
|
|
if(!(skip_left || skip_right) && !lefthand_file && !righthand_file)
|
|
TEST_FAIL("Missing both icon files for [item_path].\n\tinhand_icon_state = \"[held_icon_state]\"[match_message]")
|
|
continue
|
|
|
|
var/missing_left
|
|
var/left_fallback
|
|
if(!skip_left)
|
|
if(!lefthand_file)
|
|
TEST_FAIL("Missing left inhand icon file for [item_path].\n\tinhand_icon_state = \"[held_icon_state]\"[match_message]")
|
|
else
|
|
missing_left = !icon_exists(lefthand_file, held_icon_state)
|
|
if(missing_left && icon_exists(lefthand_file, ""))
|
|
left_fallback = TRUE
|
|
|
|
var/missing_right
|
|
var/right_fallback
|
|
if(!skip_right)
|
|
if(!righthand_file)
|
|
TEST_FAIL("Missing right inhand icon file for [item_path].\n\tinhand_icon_state = \"[held_icon_state]\"[match_message]")
|
|
else
|
|
missing_right = !icon_exists(righthand_file, held_icon_state)
|
|
if(missing_right && icon_exists(righthand_file, ""))
|
|
right_fallback = TRUE
|
|
|
|
if(missing_right && missing_left)
|
|
if(!match_message && right_fallback && left_fallback)
|
|
fallback_log_message += "\n\t[item_path] has invalid value, using fallback icon.\n\tinhand_icon_state = \"[held_icon_state]\""
|
|
continue
|
|
TEST_FAIL("Missing inhand sprites for [item_path] in both '[lefthand_file]' & '[righthand_file]'.\n\tinhand_icon_state = \"[held_icon_state]\"[match_message]")
|
|
else if(missing_left)
|
|
TEST_FAIL("Missing left inhand sprite for [item_path] in '[lefthand_file]'[left_fallback ? ", using fallback icon" : null].\n\tinhand_icon_state = \"[held_icon_state]\"[match_message]")
|
|
else if(missing_right)
|
|
TEST_FAIL("Missing right inhand sprite for [item_path] in '[righthand_file]'[right_fallback ? ", using fallback icon" : null].\n\tinhand_icon_state = \"[held_icon_state]\"[match_message]")
|
|
|
|
if(fallback_log_message)
|
|
TEST_FAIL("Invalid inhand_icon_state values should be set to null if there isn't a valid icon.[fallback_log_message]")
|
|
|
|
if(unset_inhand_var_message)
|
|
log_test("\tNotice - Possible inhand icon matches found. It is best to be explicit with inhand sprite values.[unset_inhand_var_message]")
|
|
|