mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-11 17:35:05 +00:00
a3451b7fe4
## About The Pull Request The gist is that people thought that this was a boolean value, which was fucked up. It's not a boolean value, it accepts anything between 0 and 2. So, let's re-arrange the checks and framework, give it some descriptive defines, just so people know what the fuck "2" actually does. `DOOR_DEFAULT_CHECKS` (0) does stuff normally, `DOOR_FORCED_CHECKS` 1 typically just checking if we aren't emagged shut or something (i suppose it could happen), and `DOOR_BYPASS_CHECKS` (2) means that we just get the fucking door open if it isn't physically sealed shut/open somehow. I don't know if `forced` has ever _been_ a boolean, but for some reason people thought it was. I also enforced boolean returns instead of passing back null. This did not matter for close() but i think it's silly to have a TRUE/null dichotomy so that was also touched up. ## Why It's Good For The Game Much better to read, less confusing, less stupid. It's been irritating me for a while now, so let's just implement it now. Had to make a few awkward concessions in order to fit this into the current code framework, but it should be a lot nicer. I also shuffled the order of some code around because certain placements didn't make any sense (early returns not being in the right spot for an early return). ## Changelog Nothing that should concern players.