mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
a3ef71fe18
## About The Pull Request Thankfully not as many bugs or oversights as I previously thought, but enough to hammer them out all at once. This fixes some incorrect or missing item descriptions, a few research item names, and a very important bugfix with the weapon conversion kits. - Updates description for Renoster shotgun, and Rengo rifle, as they had the incorrect magazine size listed. - Adds descriptions for Carbine and Battle Rifle conversion kits. - Makes the Carbine and Battle Rifle conversion kits not give a full free mag on crafting. - Makes the Carbine, Battle Rifle, and Shaytan SMG conversion crafts require the gun not have a magazine inserted, and the bolt be open to craft. - Fixes lathe description and name for Stardust / Advanced Anti Riot shells, homogenizes name as "Less-Lethal" - Fixes description on Stardust ammo box. - Pedantic nitpick renaming WT-550 rubber mags from "Less-Than-Lethal" to "Less-Lethal", as that was the only use of the term "Less-Than-Lethal" with any firearm. - Updates Shaytan gun description to not be a copy of the conversion kit description. (provided by @Offwrldr / Bangle) - Updates Shaytan conversion kit name and description in the sec lathe. - Updates all shotgun ammo boxes to show the proper max ammo count (which is now 7) - Reduces cost of Honkshot from 100cr to 25cr (as it now is properly overridden) - Standardizes all shotgun ammo boxes to hold 7 rounds (dropping scatterlaser, hunter, flechette, dragon's breath, hornet's nest, stardust, pulse slug, and scatter ion from 15 rounds per box, and honkshot from 35 rounds per box). ## Why It's Good For The Game As for the descriptions and names, fixing stuff that is blatantly incorrect or misleading is good. As for the conversion crafts, giving people free ammo and magazines is anywhere from an unfortunate oversight, to outright boo-boo-busted. Consistency for ammo boxes is also good (alongside accurate descriptions), and I checked with a maintainer in the discord before updating ammo box values. ## Proof Of Testing I'm not taking screenshots of descriptions in the lathe, or of items. If it complies, they're accurate. I do have a video showing the crafts requiring the guns to have no magazine, and be open bolt though. https://github.com/user-attachments/assets/9c8313c4-274d-4e7d-9211-7938f595c42f ## Changelog 🆑 Impish_Delights, Bangle fix: Romulus Carbine, and Romulus Battle-Rifle crafts no longer give free loaded magazines. balance: All shotgun ammo boxes now hold 7 rounds. Honkshot is now 25cr from cargo, down from 100cr. code: Romulus Carbine, Romulus Battle-Rifle, and Romulus Shaytan kit now require gun to be empty, and locked open to craft. spellcheck: Fixes description for Rengo rifle, Renoster shotgun, Stardust/AAR cartridge box, and Romulus Carbine and Battle-Rifle conversion kits. spellcheck: Homogonizes description for Stardust/AAR ammo, and Beanbag slug ammo as "Less-Lethal" spellcheck: Changes WT-550 rubber mag to be "Less-Lethal" instead of "Less-Than_Lethal" spellcheck: Updates Shaytan SMG description, and conversion kit name and description in the security lathe. spellcheck: Updates all shotgun ammo boxes to be accurate. /🆑 --------- Co-authored-by: Bangle <140950607+Offwrldr@users.noreply.github.com>