cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-25 08:34:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
ad34d5341ebc87ff405da7e999aab4e98a2f3644
Bubberstation/code/game/objects/structures/training_machine.dm
John Willard 1674f25725 New Medical job: The Coroner (#75065) 
## About The Pull Request

HackMD: https://hackmd.io/RE9uRwSYSjCch17-OQ4pjQ?view

Feedback link: https://tgstation13.org/phpBB/viewtopic.php?f=10&t=33972

Adds a Coroner job to the game, they work in the Medical department and
have their office in the Morgue.
I was inspired to make this after I had played my first round on
Paradise and messed around in there. The analyzer is copied from there
(https://github.com/ParadiseSS13/Paradise/pull/20957), and their
jumpsuit is also mostly stolen from it (i just copied the color scheme
onto our own suits).

Coroners can perform autopsies on people to see their stats, like this

![image](https://user-images.githubusercontent.com/53777086/235369225-805d482c-56c0-441c-9ef8-a42d0a0192bc.png)

They have access to Medbay, and on lowpop will get Pharmacy (to make
their own formaldehyde). They also have their own Secure Morgue access
for their office (doubles as a surgery room because they are edgelords
or whatever) and the secure morgue trays.

Secure Morgue trays spawn with their beepers off and is only accessible
by them, the CMO, and HoS. It's used to morgue Antagonists. Security's
own morgue trays have been removed.

The job in action


https://cdn.discordapp.com/attachments/950489581151735849/1102297675669442570/2023-04-30_14-16-06.mp4

### Surgery changes

Autopsies are a Surgery, and I tried to intertwine this with the
Dissection surgery.
Dissections and Autopsies both require the Autopsy scanner to perform
them, however you can only perform one on any given body. Dissections
are for experiments, Autopsies is for the paper of information.

Dissected bodies now also give a ~20% surgery speed boost, this was
added at the request of Fikou as a way to encourage Doctors to let the
Coroner do their job before reviving a body.
I also remember the Medical skill, which allowed Doctors to do surgery
faster on people, and I hope that this can do something like that
WITHOUT adding the potential for exploiting, which led to the skill's
downfall.

### Morgue Improvements

Morgue trays are no longer named with pens, they instead will steal the
name of the last bodybag to be put in them.

Morgue trays are also removed from Brig Medical areas and Robotics, now
they have to bring their corpses to the Morgue where the Coroner can
keep track and ensure records are properly updated.

### Sprite credits

I can't fit it all in the Changelog, so this is who made what

McRamon
- Autopsy scanner

Tattax 
- Table clock sprites and in-hands

CoiledLamb
- Coroner jumpsuits & labcoats (inhand, on sprite, and their respective
alternatives)
- Coroner gloves
- CoronerDrobe (the vending machine)

## Why It's Good For The Game

This is mostly explained in the hackmd, but the goal of this is:

1. Increase the use of the Medical Records console.
2. Add a new and interesting way for Detectives to uncover mysteries.
3. Add a more RP-flavored role in Medical that still has mechanics tied
behind it.

## Changelog

🆑 JohnFulpWillard, sprites by McRamon, tattax, and Lamb
add: The Coroner, a new Medical role revolving around dead corpses and
autopsies.
add: The Coroner's Autopsy Scanner, used for discovering the cause for
someone's death, listing their wounds, the causes of them, their
reagents, and diseases (including stealth ones!)
qol: Morgue Trays are now named after the bodybags inside of them.
balance: The morgue now has 'Secure' morgue trays which by default don't
beep.
balance: Security Medical area and Robotics no longer have their own
morgue trays.
balance: Dissected bodies now have faster surgery speed. Autopsies also
count as dissections, however they're mutually exclusive.
/🆑

---------

Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
2023-05-05 21:31:28 -04:00

423 lines
14 KiB
Plaintext
Raw Blame History

#define MIN_RANGE 1
#define MIN_SPEED 1
#define MAX_RANGE 7
#define MAX_SPEED 10
#define HITS_TO_KILL 9
#define MIN_ATTACK_DELAY 10
#define MAX_ATTACK_DELAY 15
/**
* Machine that runs around wildly so people can practice clickin on things
*
* Can have a mob buckled on or a obj/item/target attached. Movement controlled by SSFastProcess,
* movespeed controlled by cooldown macros. Can attach obj/item/target, obj/item/training_toolbox, and can buckle mobs to this.
*/
/obj/structure/training_machine
name = "AURUMILL-Brand MkII. Personnel Training Machine"
desc = "Used for combat training simulations. Accepts standard training targets. A pair of buckling straps are attached."
icon = 'icons/obj/objects.dmi'
icon_state = "training_machine"
can_buckle = TRUE
buckle_lying = 0
max_integrity = 200
///Is the machine moving? Setting this to FALSE will automatically call stop_moving()
var/moving = FALSE
///The distance the machine is allowed to roam from its starting point
var/range = 1
///A random spot within range that the trainer is trying to reach
var/turf/target_position
///The turf the machine was on when it was activated
var/turf/starting_turf
///Delay between process() calls. Cannot be higher than MAX_SPEED. Smaller value represents faster movement.
var/move_speed = 1
///Reference to a potentially attached object, either a target, trainer toolbox, or syndicate toolbox
var/obj/attached_item
///Helper for timing attacks when emagged
COOLDOWN_DECLARE(attack_cooldown)
///Cooldown macro to control how fast this will move. Used in process()
COOLDOWN_DECLARE(move_cooldown)
/**
* Called on qdel(), so we don't want a cool explosion to happen
*/
/obj/structure/training_machine/Destroy()
remove_attached_item()
return ..()
/**
* Called on a normal destruction, so we have a cool explosion and toss whatever's attached
*/
/obj/structure/training_machine/atom_destruction(damage_flag)
remove_attached_item(throwing = TRUE)
explosion(src, light_impact_range = 1, flash_range = 2)
return ..()
/obj/structure/training_machine/ui_state(mob/user)
return GLOB.physical_state
/obj/structure/training_machine/ui_interact(mob/user, datum/tgui/ui)
ui = SStgui.try_update_ui(user, src, ui)
if(!ui)
ui = new(user, src, "TrainingMachine", name)
ui.open()
/**
* Send data to the UI
*
* Include's the machine's movement range, speed, and whether or not it's active
*/
/obj/structure/training_machine/ui_data(mob/user)
var/list/data = list()
data["range"] = range
data["movespeed"] = move_speed
data["moving"] = moving
return data
/**
* Control the attached variables.
*
* Will not respond if moving and emagged, so once you set it to go it can't be stopped!
*/
/obj/structure/training_machine/ui_act(action, params)
. = ..()
if(.)
return
if (moving && obj_flags & EMAGGED)
visible_message(span_warning("The [src]'s control panel fizzles slightly."))
return
switch(action)
if("toggle")
toggle()
. = TRUE
if("range")
var/range_input = params["range"]
range = clamp(range_input, MIN_RANGE, MAX_RANGE)
. = TRUE
if("movespeed")
var/range_input = params["movespeed"]
move_speed = clamp(range_input, MIN_SPEED, MAX_SPEED)
. = TRUE
/obj/structure/training_machine/attack_hand(mob/user, list/modifiers)
ui_interact(user)
/**
* Called when the machien is attacked by something
*
* Meant for attaching an item to the machine, should only be a training toolbox or target. If emagged, the
* machine will gain an auto-attached syndicate toolbox, so in that case we shouldn't be able to swap it out
*/
/obj/structure/training_machine/attackby(obj/item/target, mob/living/user)
if (user.combat_mode)
return ..()
if (!istype(target, /obj/item/training_toolbox) && !istype(target, /obj/item/target))
return ..()
if (obj_flags & EMAGGED)
to_chat(user, span_warning("The toolbox is somehow stuck on! It won't budge!"))
return
attach_item(target)
to_chat(user, span_notice("You attach \the [attached_item] to the training device."))
playsound(src, SFX_RUSTLE, 50, TRUE)
/**
* Attach an item to the machine
*
* This proc technically works with any obj. Currently is only used for objects of type item/target and item/training_toolbox
* Will make the attached item appear visually on the machine
* Arguments
* * target - The object to attach
*/
/obj/structure/training_machine/proc/attach_item(obj/target)
remove_attached_item()
attached_item = target
attached_item.forceMove(src)
attached_item.vis_flags |= VIS_INHERIT_ID | VIS_INHERIT_PLANE
vis_contents += attached_item
RegisterSignal(attached_item, COMSIG_PARENT_QDELETING, PROC_REF(on_attached_delete))
handle_density()
/**
* Called when the attached item is deleted.
*
* Cleans up behavior for when the attached item is deleted or removed.
*/
/obj/structure/training_machine/proc/on_attached_delete()
SIGNAL_HANDLER
UnregisterSignal(attached_item, COMSIG_PARENT_QDELETING)
vis_contents -= attached_item
attached_item.vis_flags &= ~(VIS_INHERIT_ID | VIS_INHERIT_PLANE)
attached_item = null
handle_density()
/**
* Remove the attached item from the machine
*
* Called when a user removes the item by hand or by swapping it out with another, when the machine breaks, or
* when the machine is emagged.
* Arguments
* * user - The peson , if any, removing the attached item
* * throwing - If we should make the item fly off the machine
*/
/obj/structure/training_machine/proc/remove_attached_item(mob/user, throwing = FALSE)
if (!attached_item)
return
if (istype(attached_item, /obj/item/storage/toolbox/syndicate))
UnregisterSignal(attached_item, COMSIG_PARENT_QDELETING)
qdel(attached_item)
else if (user)
INVOKE_ASYNC(user, TYPE_PROC_REF(/mob, put_in_hands), attached_item)
else
attached_item.forceMove(drop_location())
if (throwing && !QDELETED(attached_item)) //Fun little thing where we throw out the old attached item when emagged
//We do a QDELETED check here because we don't want to throw the syndi toolbox, if it exists
var/destination = get_edge_target_turf(get_turf(src), pick(GLOB.alldirs))
attached_item.throw_at(destination, 4, 1)
on_attached_delete()
/obj/structure/training_machine/AltClick(mob/user)
. = ..()
if(!user.can_perform_action(src, NEED_DEXTERITY|FORBID_TELEKINESIS_REACH|ALLOW_RESTING))
return
if(has_buckled_mobs())
user_unbuckle_mob(buckled_mobs[1], user)
return
if (!attached_item)
return
if (obj_flags & EMAGGED)
to_chat(user, span_warning("The toolbox is somehow stuck on! It won't budge!"))
return
to_chat(user, span_notice("You remove \the [attached_item] from the training device."))
remove_attached_item(user)
playsound(src, SFX_RUSTLE, 50, TRUE)
/**
* Toggle the machine's movement
*/
/obj/structure/training_machine/proc/toggle()
if (moving)
stop_moving()
else
start_moving()
/**
* Stop the machine's movement
*
* Will call STOP_PROCESSING, play a sound, and say an appropriate message
* Arguments
* * Message - the message the machine says when stopping
*/
/obj/structure/training_machine/proc/stop_moving(message = "Ending training simulation.")
moving = FALSE
starting_turf = null
say(message)
playsound(src,'sound/machines/synth_no.ogg',50,FALSE)
STOP_PROCESSING(SSfastprocess, src)
/**
* Start the machine's movement
*
* Says a message, plays a sound, then starts processing
*/
/obj/structure/training_machine/proc/start_moving()
moving = TRUE
starting_turf = get_turf(src)
say("Beginning training simulation.")
playsound(src,'sound/machines/triple_beep.ogg',50,FALSE)
START_PROCESSING(SSfastprocess, src)
/**
* Main movement method for the machine
*
* Handles movement using SSFastProcess. Moves randomly, point-to-point, in an area centered around wherever it started.
* Will only move if the move_cooldown cooldown macro is finished.
* If it can't find a place to go, it will stop moving.
*/
/obj/structure/training_machine/process()
if(!COOLDOWN_FINISHED(src, move_cooldown))
return
var/turf/current_turf = get_turf(src)
if (!moving || !starting_turf || isspaceturf(current_turf))
stop_moving()
return
if (current_turf == target_position) //We've reached our target turf, now find a new one
target_position = null
if (!target_position)
target_position = find_target_position()
if (!target_position)
stop_moving("ERROR! Cannot calculate suitable movement path.")
var/turf/nextStep = get_step_towards(src, target_position)
if (!Move(nextStep, get_dir(src, nextStep)))
target_position = null //We couldn't move towards the target turf, so find a new target turf
try_attack()
COOLDOWN_START(src, move_cooldown, max(MAX_SPEED - move_speed, 1))
/**
* Find a suitable turf to move towards
*/
/obj/structure/training_machine/proc/find_target_position()
var/list/turfs = list()
for(var/turf/potential_turf in view(range, starting_turf))
if (potential_turf.is_blocked_turf() || potential_turf == target_position)
continue
turfs += potential_turf
if (!length(turfs))
return
return pick(turfs)
/**
* Try to attack a nearby mob
*
* Called whenever the machine moves, this will look for mobs adjacent to the machine to attack.
* Will attack with either a training toolbox (if attached), or a much more deadly syndicate toolbox (if emagged).
* A cooldown macro (attack_cooldown) ensures it doesn't attack too quickly
*/
/obj/structure/training_machine/proc/try_attack()
if (!attached_item || istype(attached_item, /obj/item/target))
return
if (!COOLDOWN_FINISHED(src, attack_cooldown))
return
var/list/targets
for(var/mob/living/carbon/target in oview(1, get_turf(src))) //Find adjacent target
if (target.stat == CONSCIOUS && target.Adjacent(src))
LAZYADD(targets, target)
var/mob/living/carbon/target = pick(targets)
if (!target)
return
do_attack_animation(target, null, attached_item)
if (obj_flags & EMAGGED)
target.apply_damage(attached_item.force, BRUTE, BODY_ZONE_CHEST, attacking_item = attached_item)
playsound(src, 'sound/weapons/smash.ogg', 15, TRUE)
COOLDOWN_START(src, attack_cooldown, rand(MIN_ATTACK_DELAY, MAX_ATTACK_DELAY))
/**
* Make sure the machine can't be walked through if something is attached
*/
/obj/structure/training_machine/proc/handle_density()
if(length(buckled_mobs) || attached_item)
set_density(TRUE)
else
set_density(FALSE)
/obj/structure/training_machine/buckle_mob(mob/living/M, force = FALSE, check_loc = TRUE)
. = ..()
if (istype(attached_item, /obj/item/target))
return FALSE
/obj/structure/training_machine/post_buckle_mob()
handle_density()
return ..()
/obj/structure/training_machine/post_unbuckle_mob()
handle_density()
return ..()
/**
* Emagging causes a deadly, unremovable syndicate toolbox to be attached to the machine
*/
/obj/structure/training_machine/emag_act(mob/user)
. = ..()
if (obj_flags & EMAGGED)
return
obj_flags |= EMAGGED
remove_attached_item(throwing = TRUE) //Toss out the old attached item!
attach_item(new /obj/item/storage/toolbox/syndicate(src))
to_chat(user, span_warning("You override the training machine's safety protocols, and activate its realistic combat feature. A toolbox pops out of a slot on the top."))
playsound(src, 'sound/machines/click.ogg', 50, TRUE)
add_overlay("evil_trainer")
/obj/structure/training_machine/examine(mob/user)
. = ..()
var/has_buckled_mob = has_buckled_mobs()
if(has_buckled_mob)
. += span_notice("<b>Alt-Click to unbuckle \the [buckled_mobs[1]]</b>")
if (obj_flags & EMAGGED)
. += span_warning("It has a dangerous-looking toolbox attached to it, and the control panel is smoking sightly...")
else if (!has_buckled_mob && attached_item) //Can't removed the syndicate toolbox!
. += span_notice("<b>Alt-Click to remove \the [attached_item]</b>")
. += span_notice("<b>Click to open control interface.</b>")
/**
* Device that simply counts the number of times you've hit a mob or target with. Looks like a toolbox but isn't.
*
* Also has a 'Lap' function for keeping track of hits made at a certain point. Also, looks kinda like his grace for laughs and pranks.
*/
/obj/item/training_toolbox
name = "Training Toolbox"
desc = "AURUMILL-Brand Baby's First Training Toolbox. A digital display on the back keeps track of hits made by the user. Second toolbox sold separately!"
icon = 'icons/obj/storage/toolbox.dmi'
icon_state = "gold"
inhand_icon_state = "toolbox_gold"
lefthand_file = 'icons/mob/inhands/equipment/toolbox_lefthand.dmi'
righthand_file = 'icons/mob/inhands/equipment/toolbox_righthand.dmi'
flags_1 = CONDUCT_1
force = 0
throwforce = 0
throw_speed = 2
throw_range = 7
w_class = WEIGHT_CLASS_BULKY
///Total number of hits made against a valid target
var/total_hits = 0
///Number of hits made since the Lap button (alt-click) was last pushed
var/lap_hits = 0
/obj/item/training_toolbox/afterattack(atom/target, mob/living/user, proximity)
. = ..()
if (!proximity || target == user || !user.combat_mode)
return
if (check_hit(target))
user.changeNext_move(CLICK_CD_MELEE)
/**
* Check if we should increment the hit counter
*
* Increments the 'hit' counter if the target we're attacking is a mob, target, or training machine with an attached item.
* Will beep every 9 hits, as 9 hits usually signifies a KO with a normal toolbox
* Arguments
* * target - the atom we're hitting
*/
/obj/item/training_toolbox/proc/check_hit(atom/target)
var/target_is_machine = istype(target, /obj/structure/training_machine)
if (!ismob(target) && !istype(target, /obj/item/target) && !target_is_machine)
return FALSE
if (target_is_machine)
var/obj/structure/training_machine/trainer = target
if (!trainer.attached_item)
return FALSE
total_hits++
lap_hits++
playsound(src,'sound/weapons/smash.ogg',50,FALSE)
if (lap_hits % HITS_TO_KILL == 0)
playsound(src,'sound/machines/twobeep.ogg',25,FALSE)
return TRUE
/obj/item/training_toolbox/throw_impact(atom/hit_atom, datum/thrownthing/throwingdatum)
. = ..()
if (!.)
check_hit(hit_atom)
/obj/item/training_toolbox/AltClick(mob/user)
. = ..()
if(!can_interact(user))
return
to_chat(user, span_notice("You push the 'Lap' button on the toolbox's display."))
lap_hits = initial(lap_hits)
/obj/item/training_toolbox/examine(mob/user)
. = ..()
if(!in_range(src, user) && !isobserver(user))
. += span_notice("You can see a display on the back. You'll need to get closer to read it, though.")
return
. += span_notice("A display on the back reads:")
. += span_notice("Total Hits: <b>[total_hits]</b>")
if (lap_hits != total_hits)
. += span_notice("Current Lap: <b>[lap_hits]</b>")
. += span_notice("<b>Alt-Click to 'Lap' the hit counter.</b>")
#undef MIN_RANGE
#undef MIN_SPEED
#undef MAX_RANGE
#undef MAX_SPEED
#undef HITS_TO_KILL
#undef MIN_ATTACK_DELAY
#undef MAX_ATTACK_DELAY
Reference in New Issue View Git Blame Copy Permalink