mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-25 16:45:42 +00:00
dc0dce4430
* Fixes some bad `investigate_log`s causing runtimes in somewhat important places (#72152) ## About The Pull Request Fixes #72150 ``` [2022-12-21 19:35:38.178] runtime error: Cannot execute null.investigate log(). - proc name: narsie act (/mob/living/narsie_act) - source file: living_defense.dm,438 - usr: null - src: Featherbottom (/mob/living/simple_animal/chicken) - src.loc: the grass patch (147,154,2) (/turf/open/floor/grass) - call stack: - Featherbottom (/mob/living/simple_animal/chicken): narsie act() ``` Removes `usr` from Nar'Sie act and Singularity act logs I don't know why these were set to log in `usr`, when A. `usr` is likely not the person getting gibbed B. `usr` is unreliable Case in point: `usr` is some random person who probably helped invoke the Nar'sie rune (no idea how it choses), if they get deleted for whatever reason, `usr` seems to clear to `null` (?), which causes a `null` use and the above runtime  I also peeked around for other improper use of `usr` logs. Most of them were in `ui_act` code, which is whatever. Some where in places which had a passed user, so I replaced them. And one was in a place with no `user` passed, so I just added some sanity checking. ## Why It's Good For The Game These are really bad places to runtime error ## Changelog 🆑 Melbert fix: Nar'Sie will no longer bring upon the construct apocalypse when they encounter a chicken after one of the invokers were destroyed fix: The Singularity should no longer stop gibbing people when whoever created it was destroyed /🆑 * Fixes some bad `investigate_log`s causing runtimes in somewhat important places Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
