Files
Bubberstation/code/modules/hallucination
SkyratBot 4d85883b27 [MIRROR] Fixes a bug where your mother would delete your species after calling you a disappointment, rendering you a broken husk of a mob [MDB IGNORE] (#24445)
* Fixes a bug where your mother would delete your species after calling you a disappointment, rendering you a broken husk of a mob (#79098)

## About The Pull Request

Yep. So I was investigating why a player was weirdly unable to equip
things, or do a lot of stuff. And encountered in the runtime logs that
_their species datum was deleted_. How? Well...the answer is...your
mother.

---

So the hallucination of 'your mother' uses the hallucinator's species
datum to create itself here:

07096ffcad/code/modules/hallucination/mother.dm (L80)

Which then calls set_species, but it passes _your actual species datum
in as an arg_

07096ffcad/code/__HELPERS/dynamic_human_icon_gen.dm (L12)

which leads to the mob _having your species datum_

07096ffcad/code/datums/dna.dm (L512)

Then when mother goes away and deletes herself, so does your species
datum. Leaving the hallucinator extremely broken, bugged, and
humiliated.

@ MrMelbert maybe letting people `set_species()` using an instantiated
species datum was a mistake...lol.

## Why It's Good For The Game

Nerfs your mother. She is too powerful!

## Changelog

🆑
fix: Fixes a bug where your mother would delete your species after
calling you a disappointment, rendering you a broken husk of a mob
/🆑

* Fixes a bug where your mother would delete your species after calling you a disappointment, rendering you a broken husk of a mob

---------

Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
2023-10-19 17:20:47 -07:00
..