Files
Bubberstation/code/modules/bitrunning/objects/quantum_console.dm
John Willard fa31403353 LateInitialize is not allowed to call parent anymore (#82540)
## About The Pull Request

I've seen a few cases in the past where LateInitialize is done cause of
the init return value being set to do so for no real reason, I thought I
should try to avoid that by ensuring LateInitialize isn't ever called
without overriding.

This fixes a ton of machine's LateInitialize not calling parent
(mechpad, door buttons, message monitor, a lot of tram machines,
abductor console, holodeck computer & disposal bin), avoiding having to
set itself up to be connected to power. If they were intended to not
connect to power, they should be using ``NO_POWER_USE`` instead.

Also removes a ton of returns to LateInit when it's already getting it
from parent regardless (many cases of that in machine code).

## Why It's Good For The Game

I think this is better for coding standard reasons as well as just
making sure we're not calling this proc on things that does absolutely
nothing with them. A machine not using power can be seen evidently not
using power with ``NO_POWER_USE``, not so much if it's LateInitialize
not calling parent.

## Changelog

🆑
fix: Mech pads, door buttons, message monitors, tram machines, abductor
consoles & holodeck computers now use power.
/🆑
2024-04-08 22:15:07 -06:00

102 lines
2.8 KiB
Plaintext

/obj/machinery/computer/quantum_console
name = "quantum console"
circuit = /obj/item/circuitboard/computer/quantum_console
icon_keyboard = "mining"
icon_screen = "bitrunning"
req_access = list(ACCESS_MINING)
/// The server this console is connected to.
var/datum/weakref/server_ref
/obj/machinery/computer/quantum_console/Initialize(mapload, obj/item/circuitboard/circuit)
. = ..()
desc = "Even in the distant year [CURRENT_STATION_YEAR], Nanostrasen is still using REST APIs. How grim."
/obj/machinery/computer/quantum_console/post_machine_initialize()
. = ..()
find_server()
/obj/machinery/computer/quantum_console/ui_interact(mob/user, datum/tgui/ui)
. = ..()
if(!is_operational)
return
ui = SStgui.try_update_ui(user, src, ui)
if(!ui)
ui = new(user, src, "QuantumConsole")
ui.open()
/obj/machinery/computer/quantum_console/ui_data()
var/list/data = list()
var/obj/machinery/quantum_server/server = find_server()
if(isnull(server))
data["connected"] = FALSE
return data
data["connected"] = TRUE
data["generated_domain"] = server.generated_domain?.key
data["occupants"] = length(server.avatar_connection_refs)
data["points"] = server.points
data["randomized"] = server.domain_randomized
data["ready"] = server.is_ready && server.is_operational
data["scanner_tier"] = server.scanner_tier
data["retries_left"] = length(server.exit_turfs) - server.retries_spent
data["broadcasting"] = server.broadcasting
data["broadcasting_on_cd"] = !COOLDOWN_FINISHED(server, broadcast_toggle_cd)
return data
/obj/machinery/computer/quantum_console/ui_static_data(mob/user)
var/list/data = list()
var/obj/machinery/quantum_server/server = find_server()
if(isnull(server))
return data
data["available_domains"] = SSbitrunning.get_available_domains(server.scanner_tier, server.points)
data["avatars"] = server.get_avatar_data()
return data
/obj/machinery/computer/quantum_console/ui_act(action, list/params, datum/tgui/ui)
. = ..()
if(.)
return TRUE
var/obj/machinery/quantum_server/server = find_server()
if(isnull(server))
return FALSE
switch(action)
if("random_domain")
server.cold_boot_map(server.get_random_domain_id())
return TRUE
if("refresh")
ui.send_full_update()
return TRUE
if("set_domain")
server.cold_boot_map(params["id"])
return TRUE
if("stop_domain")
server.begin_shutdown(usr)
return TRUE
if("broadcast")
server.toggle_broadcast()
return TRUE
return FALSE
/// Attempts to find a quantum server.
/obj/machinery/computer/quantum_console/proc/find_server()
var/obj/machinery/quantum_server/server = server_ref?.resolve()
if(server)
return server
for(var/direction in GLOB.cardinals)
var/obj/machinery/quantum_server/nearby_server = locate(/obj/machinery/quantum_server, get_step(src, direction))
if(nearby_server)
server_ref = WEAKREF(nearby_server)
return nearby_server