mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-14 19:51:59 +00:00
a7ca4b83cb
## About The Pull Request This PR makes the computer console's print feature work on a signal instead of wasting paper every string update, changes the flashlight color change to do the same, fixes the on/off signal not turning the console on, and fixes the signal for the console turning off not functioning. ## Why It's Good For The Game Besides the bug fixes, this makes the console components more consistent with every other circuit component. The refactor is to prevent worrying about nulls for colors or errors because of early returns. ## Changelog 🆑 fix: computers with no lights can now turn on using the on/off signal fix: RGB lights on PDA circuits now use a signal fix: the is_off signal now works on consoles fix: printing text on a console component now uses a signal refactor: each input signal in console circuits now have their own proc /🆑
97 lines
3.6 KiB
Plaintext
97 lines
3.6 KiB
Plaintext
///A simple circuit component compatible with stationary consoles, laptops and PDAs, independent from programs.
|
|
/obj/item/circuit_component/modpc
|
|
display_name = "Modular Computer"
|
|
desc = "Circuit for basic functions of a modular computer."
|
|
var/obj/item/modular_computer/computer
|
|
///Turns the PC on/off
|
|
var/datum/port/input/on_off
|
|
///Determines the text to be printed
|
|
var/datum/port/input/print_text
|
|
/// Print when triggered
|
|
var/datum/port/input/print
|
|
|
|
///Sent when turned on
|
|
var/datum/port/output/is_on
|
|
///Sent when shut down
|
|
var/datum/port/output/is_off
|
|
|
|
///Toggles lights on and off. Also RGB.
|
|
var/datum/port/input/lights
|
|
var/datum/port/input/red
|
|
var/datum/port/input/green
|
|
var/datum/port/input/blue
|
|
var/datum/port/input/set_color
|
|
|
|
/obj/item/circuit_component/modpc/register_shell(atom/movable/shell)
|
|
. = ..()
|
|
if(istype(shell, /obj/item/modular_computer))
|
|
computer = shell
|
|
else if(istype(shell, /obj/machinery/modular_computer))
|
|
var/obj/machinery/modular_computer/console = shell
|
|
computer = console.cpu
|
|
|
|
if(isnull(computer))
|
|
return
|
|
|
|
RegisterSignal(computer, COMSIG_MODULAR_COMPUTER_TURNED_ON, PROC_REF(computer_on))
|
|
RegisterSignal(computer, COMSIG_MODULAR_COMPUTER_SHUT_DOWN, PROC_REF(computer_off))
|
|
|
|
/**
|
|
* Some mod pc have lights while some don't, but populate_ports()
|
|
* is called before we get to know which object this has attahed to,
|
|
* I hope you're cool with me doing it here.
|
|
*/
|
|
if(computer.has_light && isnull(lights))
|
|
lights = add_input_port("Toggle Lights", PORT_TYPE_SIGNAL, trigger = PROC_REF(toggle_flashlight))
|
|
red = add_input_port("Red", PORT_TYPE_NUMBER)
|
|
green = add_input_port("Green", PORT_TYPE_NUMBER)
|
|
blue = add_input_port("Blue", PORT_TYPE_NUMBER)
|
|
set_color = add_input_port("Set Color", PORT_TYPE_SIGNAL, trigger = PROC_REF(set_flashlight_color))
|
|
|
|
/obj/item/circuit_component/modpc/unregister_shell(atom/movable/shell)
|
|
if(computer)
|
|
UnregisterSignal(computer, list(COMSIG_MODULAR_COMPUTER_TURNED_ON, COMSIG_MODULAR_COMPUTER_SHUT_DOWN))
|
|
computer = null
|
|
return ..()
|
|
|
|
/obj/item/circuit_component/modpc/populate_ports()
|
|
on_off = add_input_port("Turn On/Off", PORT_TYPE_SIGNAL, trigger = PROC_REF(toggle_power))
|
|
print_text = add_input_port("Print Text", PORT_TYPE_STRING)
|
|
print = add_input_port("Print", PORT_TYPE_SIGNAL, trigger = PROC_REF(print_text))
|
|
|
|
is_on = add_output_port("Turned On", PORT_TYPE_SIGNAL)
|
|
is_off = add_output_port("Shut Down", PORT_TYPE_SIGNAL)
|
|
|
|
/obj/item/circuit_component/modpc/pre_input_received(datum/port/input/port)
|
|
if(isnull(computer))
|
|
return
|
|
if(COMPONENT_TRIGGERED_BY(print_text, port))
|
|
print.set_value(html_encode(trim(print.value, MAX_PAPER_LENGTH)))
|
|
|
|
/obj/item/circuit_component/modpc/proc/print_text(datum/source)
|
|
if(computer.enabled)
|
|
computer.print_text(print_text.value)
|
|
|
|
/obj/item/circuit_component/modpc/proc/toggle_power(datum/source)
|
|
if(computer.enabled)
|
|
INVOKE_ASYNC(computer, TYPE_PROC_REF(/obj/item/modular_computer, shutdown_computer))
|
|
else
|
|
INVOKE_ASYNC(computer, TYPE_PROC_REF(/obj/item/modular_computer, turn_on))
|
|
|
|
/obj/item/circuit_component/modpc/proc/toggle_flashlight(datum/source)
|
|
computer.toggle_flashlight()
|
|
|
|
/obj/item/circuit_component/modpc/proc/set_flashlight_color(datum/source)
|
|
red.set_value(clamp(red.value, 0, 255))
|
|
blue.set_value(clamp(blue.value, 0, 255))
|
|
green.set_value(clamp(green.value, 0, 255))
|
|
computer.set_flashlight_color(rgb(red.value || 0, green.value || 0, blue.value || 0))
|
|
|
|
/obj/item/circuit_component/modpc/proc/computer_on(datum/source, mob/user)
|
|
SIGNAL_HANDLER
|
|
is_on.set_output(COMPONENT_SIGNAL)
|
|
|
|
/obj/item/circuit_component/modpc/proc/computer_off(datum/source, loud)
|
|
SIGNAL_HANDLER
|
|
is_off.set_output(COMPONENT_SIGNAL)
|