mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-28 01:51:46 +00:00
3f0b4abb8d
## About The Pull Request All usages of world.icon_size in code have been replaced with new `ICONSIZE_X`, `ICONSIZE_Y` and `ICONSIZE_ALL` defines depending on context Replaces some "32" magic numbers with the defines A few bits of code have been modified to split up x/y math as well ## Why It's Good For The Game Magic number bad, code more readable, code more flexible and I'm told there's an access cost to doing world.icon_size so minor performance gains ## Changelog 🆑 tonty code: made some code relating to the world's icon size more readable /🆑 --------- Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
52 lines
1.7 KiB
Plaintext
52 lines
1.7 KiB
Plaintext
// Stuff that is relatively "core" and is used in other defines/helpers
|
|
|
|
/**
|
|
* The game's world.icon_size. \
|
|
* Ideally divisible by 16. \
|
|
* Ideally a number, but it
|
|
* can be a string ("32x32"), so more exotic coders
|
|
* will be sad if you use this in math.
|
|
*/
|
|
#define ICON_SIZE_ALL 32
|
|
/// The X/Width dimension of ICON_SIZE. This will more than likely be the bigger axis.
|
|
#define ICON_SIZE_X 32
|
|
/// The Y/Height dimension of ICON_SIZE. This will more than likely be the smaller axis.
|
|
#define ICON_SIZE_Y 32
|
|
|
|
//Returns the hex value of a decimal number
|
|
//len == length of returned string
|
|
#define num2hex(X, len) num2text(X, len, 16)
|
|
|
|
//Returns an integer given a hex input, supports negative values "-ff"
|
|
//skips preceding invalid characters
|
|
#define hex2num(X) text2num(X, 16)
|
|
|
|
/// Stringifies whatever you put into it.
|
|
#define STRINGIFY(argument) #argument
|
|
|
|
/// subtypesof(), typesof() without the parent path
|
|
#define subtypesof(typepath) ( typesof(typepath) - typepath )
|
|
|
|
/// Until a condition is true, sleep
|
|
#define UNTIL(X) while(!(X)) stoplag()
|
|
|
|
/// Sleep if we haven't been deleted
|
|
/// Otherwise, return
|
|
#define SLEEP_NOT_DEL(time) \
|
|
if(QDELETED(src)) { \
|
|
return; \
|
|
} \
|
|
sleep(time);
|
|
|
|
/// Takes a datum as input, returns its ref string
|
|
#define text_ref(datum) ref(datum)
|
|
|
|
// Refs contain a type id within their string that can be used to identify byond types.
|
|
// Custom types that we define don't get a unique id, but this is useful for identifying
|
|
// types that don't normally have a way to run istype() on them.
|
|
#define TYPEID(thing) copytext(REF(thing), 4, 6)
|
|
|
|
/// A null statement to guard against EmptyBlock lint without necessitating the use of pass()
|
|
/// Used to avoid proc-call overhead. But use sparingly. Probably pointless in most places.
|
|
#define EMPTY_BLOCK_GUARD ;
|