mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-30 11:01:35 +00:00
17d39f7af0
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> As the title says. Upgrades the menu and allows you to create action button shortcuts.    Additionally, bots can now select the radio channel if they have one. Lowers the cooldown for voice lines. ## Why It's Good For The Game <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> Being able to more conveniently send a voice line by pressing a button without needing to open up an interface and navigate to the correct line will make using these a lot easier in relevant situations. Voice line cooldowns are lowered a bit just to make voice lines easier to use in relevant situations. I.e. 'Extinguishing fire' -> 5 seconds later -> 'Fire extinguished' Abuse should generally just be punished by the admins, the cooldown doesn't need to be too lengthy. ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and it's effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> 🆑 qol: Bots can now bind voice lines to an action slot. Lowers cooldown for all bot voicelines to 5 seconds. /🆑 <!-- Both 🆑's are required for the changelog to work! You can put your name to the right of the first 🆑 if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
119 lines
4.8 KiB
Plaintext
119 lines
4.8 KiB
Plaintext
//// COOLDOWN SYSTEMS
|
|
/*
|
|
* We have 2 cooldown systems: timer cooldowns (divided between stoppable and regular) and world.time cooldowns.
|
|
*
|
|
* When to use each?
|
|
*
|
|
* * Adding a commonly-checked cooldown, like on a subsystem to check for processing
|
|
* * * Use the world.time ones, as they are cheaper.
|
|
*
|
|
* * Adding a rarely-used one for special situations, such as giving an uncommon item a cooldown on a target.
|
|
* * * Timer cooldown, as adding a new variable on each mob to track the cooldown of said uncommon item is going too far.
|
|
*
|
|
* * Triggering events at the end of a cooldown.
|
|
* * * Timer cooldown, registering to its signal.
|
|
*
|
|
* * Being able to check how long left for the cooldown to end.
|
|
* * * Either world.time or stoppable timer cooldowns, depending on the other factors. Regular timer cooldowns do not support this.
|
|
*
|
|
* * Being able to stop the timer before it ends.
|
|
* * * Either world.time or stoppable timer cooldowns, depending on the other factors. Regular timer cooldowns do not support this.
|
|
*/
|
|
|
|
|
|
/*
|
|
* Cooldown system based on an datum-level associative lazylist using timers.
|
|
*/
|
|
|
|
//INDEXES
|
|
#define COOLDOWN_BORG_SELF_REPAIR "borg_self_repair"
|
|
#define COOLDOWN_EXPRESSPOD_CONSOLE "expresspod_console"
|
|
|
|
//Mecha cooldowns
|
|
#define COOLDOWN_MECHA_MESSAGE "mecha_message"
|
|
#define COOLDOWN_MECHA_EQUIPMENT(type) ("mecha_equip_[type]")
|
|
#define COOLDOWN_MECHA_MELEE_ATTACK "mecha_melee"
|
|
#define COOLDOWN_MECHA_SMOKE "mecha_smoke"
|
|
#define COOLDOWN_MECHA_SKYFALL "mecha_skyfall"
|
|
#define COOLDOWN_MECHA_MISSILE_STRIKE "mecha_missile_strike"
|
|
#define COOLDOWN_MECHA_CABIN_SEAL "mecha_cabin_seal"
|
|
|
|
//car cooldowns
|
|
#define COOLDOWN_CAR_HONK "car_honk"
|
|
|
|
//clown car cooldowns
|
|
#define COOLDOWN_CLOWNCAR_RANDOMNESS "clown_car_randomness"
|
|
|
|
// item cooldowns
|
|
#define COOLDOWN_SIGNALLER_SEND "cooldown_signaller_send"
|
|
#define COOLDOWN_TOOL_SOUND "cooldown_tool_sound"
|
|
|
|
//circuit cooldowns
|
|
#define COOLDOWN_CIRCUIT_SOUNDEMITTER "circuit_soundemitter"
|
|
#define COOLDOWN_CIRCUIT_SPEECH "circuit_speech"
|
|
#define COOLDOWN_CIRCUIT_PATHFIND_SAME "circuit_pathfind_same"
|
|
#define COOLDOWN_CIRCUIT_PATHFIND_DIF "circuit_pathfind_different"
|
|
#define COOLDOWN_CIRCUIT_TARGET_INTERCEPT "circuit_target_intercept"
|
|
#define COOLDOWN_CIRCUIT_VIEW_SENSOR "circuit_view_sensor"
|
|
|
|
// mob cooldowns
|
|
#define COOLDOWN_YAWN_PROPAGATION "yawn_propagation_cooldown"
|
|
|
|
// admin verb cooldowns
|
|
#define COOLDOWN_INTERNET_SOUND "internet_sound"
|
|
|
|
//Shared cooldowns for actions
|
|
#define MOB_SHARED_COOLDOWN_1 (1<<0)
|
|
#define MOB_SHARED_COOLDOWN_2 (1<<1)
|
|
#define MOB_SHARED_COOLDOWN_3 (1<<2)
|
|
#define MOB_SHARED_COOLDOWN_BOT_ANNOUNCMENT (1<<3)
|
|
|
|
//TIMER COOLDOWN MACROS
|
|
|
|
#define COMSIG_CD_STOP(cd_index) "cooldown_[cd_index]"
|
|
#define COMSIG_CD_RESET(cd_index) "cd_reset_[cd_index]"
|
|
|
|
#define TIMER_COOLDOWN_START(cd_source, cd_index, cd_time) LAZYSET(cd_source.cooldowns, cd_index, addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(end_cooldown), cd_source, cd_index), cd_time))
|
|
|
|
/// Checks if a timer based cooldown is NOT finished.
|
|
#define TIMER_COOLDOWN_RUNNING(cd_source, cd_index) LAZYACCESS(cd_source.cooldowns, cd_index)
|
|
|
|
/// Checks if a timer based cooldown is finished.
|
|
#define TIMER_COOLDOWN_FINISHED(cd_source, cd_index) (!TIMER_COOLDOWN_RUNNING(cd_source, cd_index))
|
|
|
|
#define TIMER_COOLDOWN_END(cd_source, cd_index) LAZYREMOVE(cd_source.cooldowns, cd_index)
|
|
|
|
/*
|
|
* Stoppable timer cooldowns.
|
|
* Use indexes the same as the regular tiemr cooldowns.
|
|
* They make use of the TIMER_COOLDOWN_RUNNING() and TIMER_COOLDOWN_END() macros the same, just not the TIMER_COOLDOWN_START() one.
|
|
* A bit more expensive than the regular timers, but can be reset before they end and the time left can be checked.
|
|
*/
|
|
|
|
#define S_TIMER_COOLDOWN_START(cd_source, cd_index, cd_time) LAZYSET(cd_source.cooldowns, cd_index, addtimer(CALLBACK(GLOBAL_PROC, GLOBAL_PROC_REF(end_cooldown), cd_source, cd_index), cd_time, TIMER_STOPPABLE))
|
|
|
|
#define S_TIMER_COOLDOWN_RESET(cd_source, cd_index) reset_cooldown(cd_source, cd_index)
|
|
|
|
#define S_TIMER_COOLDOWN_TIMELEFT(cd_source, cd_index) (timeleft(TIMER_COOLDOWN_RUNNING(cd_source, cd_index)))
|
|
|
|
|
|
/*
|
|
* Cooldown system based on storing world.time on a variable, plus the cooldown time.
|
|
* Better performance over timer cooldowns, lower control. Same functionality.
|
|
*/
|
|
|
|
#define COOLDOWN_DECLARE(cd_index) var/##cd_index = 0
|
|
|
|
#define STATIC_COOLDOWN_DECLARE(cd_index) var/static/##cd_index = 0
|
|
|
|
#define COOLDOWN_START(cd_source, cd_index, cd_time) (cd_source.cd_index = world.time + (cd_time))
|
|
|
|
//Returns true if the cooldown has run its course, false otherwise
|
|
#define COOLDOWN_FINISHED(cd_source, cd_index) (cd_source.cd_index <= world.time)
|
|
|
|
#define COOLDOWN_RESET(cd_source, cd_index) cd_source.cd_index = 0
|
|
|
|
#define COOLDOWN_STARTED(cd_source, cd_index) (cd_source.cd_index != 0)
|
|
|
|
#define COOLDOWN_TIMELEFT(cd_source, cd_index) (max(0, cd_source.cd_index - world.time))
|