mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-27 17:41:50 +00:00
3c7005a37c
## About The Pull Request This helps clean up my favorite helper proc in the whole codebase, `notify_ghosts()`. The notify_suiciders, ignore_mapload, and flashwindow args are GONE. They have been replaced with the notify_flags bitflag argument. This was intended to make deadchat announcements a bitflag argument too, but those got reverted right before I originally wanted to submit this PR. The on-screen popup now shows the notification body when you hover it with your mouse again. The format is now `[notify_ghosts message] -- [click action (orbit/jump/play)]` Every single `notify_ghosts()` call has been changed to multiline format and has been given trailing commas. Pretty! ## Why It's Good For The Game Cleans up a proc that is very popular and going through a lot of changes at the time. Allows for further flexibility when this proc inevitably gets tweaked or improved. 12 -> 10 args is an improvement, and it doesn't impact the helper's flexibility at all. ## Changelog 🆑 Rhials code: The notify_ghosts proc has been cleaned up. Please report any abnormal changes in deadchat notification behavior. qol: The on-screen deadchat popups now contain the notification blurb when hovered with your mouse again. /🆑
13 lines
714 B
Plaintext
13 lines
714 B
Plaintext
// Various flags for notify_ghosts ghost popups.
|
|
/// Determines if the notification will not run if called during mapload.
|
|
#define GHOST_NOTIFY_IGNORE_MAPLOAD (1<<0)
|
|
/// Determines if the notification will flash the Byond window.
|
|
#define GHOST_NOTIFY_FLASH_WINDOW (1<<1)
|
|
/// Determines if the notification will notify suiciders.
|
|
#define GHOST_NOTIFY_NOTIFY_SUICIDERS (1<<2)
|
|
|
|
/// The default set of flags to be passed into a notify_ghosts call.
|
|
#define NOTIFY_CATEGORY_DEFAULT (GHOST_NOTIFY_FLASH_WINDOW | GHOST_NOTIFY_IGNORE_MAPLOAD | GHOST_NOTIFY_NOTIFY_SUICIDERS)
|
|
/// The default set of flags, without the flash_window flag.
|
|
#define NOTIFY_CATEGORY_NOFLASH (NOTIFY_CATEGORY_DEFAULT & ~GHOST_NOTIFY_FLASH_WINDOW)
|