mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-27 17:41:50 +00:00
3ee9d58423
## About The Pull Request Post revs win now ends the shift. Does some misc code cleanup of stuff that annoyed me while I was reading code. Implements revs win ending the shift via a new global used in `/datum/game_mode/proc/check_finished(force_ending)` that is set to TRUE when revs win. The rev station charter has been removed (for lack of anywhere else good to put it trivially). The bedsheet has been incorporated into the Post-Revolutionary Fervor station trait. It replaces Captain bedsheets when this station trait rolls.  **This is all untested, and I'm not sure if I'm able to test this on local. Please carefully review code changes or consider testmerging over fullmerging.** ## Why It's Good For The Game Quoting myself from https://tgstation13.org/phpBB/viewtopic.php?f=85&t=33860 > I have no issues with post-revs loss. It's simple, everyone knows where they stand and it works well. Please keep it. > > I have issues with post-revs win. Too complex; not intuitive; too many factions; no way to identify which faction a player belongs to ICly; difficult to administrate as a result. > >... > >Without a good code solution improving post-revs win, I would remove it while retaining current post-revs lose if such an option was available to me as headmin. > >If my quibbles with it were dealt with, I would happily vote in favour of re-introducing post-revs win. It's not an ideologicial opposition, just a practical one. This can really be summarised as: Revs refuses to end even after the revolution wins and the revolution is over. There's exiled heads, the sec team, mindshielded non-revs, non-revs, ex-revs and ex-headrevs. Generally exiled heads and the sec team buddy up as a single faction. Ex-revs and ex-headrevs are the same. But mindshielded crew and non-mindshielded crew sit in an awkward limbo, where mindshielded crew aren't anti-revs, and the non-mindshielded non-rev crew aren't rev-sided. Mindshields also do nothing about the ex-antag status. Since the simplest solution to this problem is ending on post-revs win, that's the one I've gone for. ## Changelog 🆑 del: Revolution has been reverted back to old behaviour. The round once again ends when the revolution is successful. The round continues as normal if the revolution fails. add: When the station is rolled in a state of Post-Revolutionary Fervor, the Captain will find their bedsheets replaced with an anti-Nanotrasen variant. /🆑
15 lines
402 B
Plaintext
15 lines
402 B
Plaintext
/// Rev deconverted because the station won.
|
|
#define DECONVERTER_STATION_WIN "gamemode_station_win"
|
|
|
|
/// Rev deconverted via borging.
|
|
#define DECONVERTER_BORGED "rev_removed_by_borging"
|
|
|
|
/// How often to check for promoting up new revheads.
|
|
#define HEAD_UPDATE_PERIOD 300
|
|
|
|
/// Revs won the revolution.
|
|
#define REVOLUTION_VICTORY 1
|
|
|
|
/// The heads of staff beat the revolution.
|
|
#define STATION_VICTORY 2
|