Bubberstation

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-26 09:03:37 +00:00

Files

SkyratBot bcd36f46c0 [MIRROR] Fixes a bug with the immerse element [MDB IGNORE] (#23073 )

* Fixes a bug with the immerse element (#77585)

## About The Pull Request

What it says on the tin. This runtime was caught downstream in an away
mission unit test where a mob is placed in a water turf.

![image](https://github.com/tgstation/tgstation/assets/13398309/8123321d-8bf4-4186-a63d-944080ad9f8a)

Basically the immerse overlay wasn't being added the very first time it
was created, because it wasn't being returned by
`generate_vis_overlay()`. Derp.

It went unnoticed because the overlays are cached and so every
subsequent `add_immerse_overlay()` works fine. And I guess upstream
doesn't have any mobs that spawn in water during tests so it was never
caught.

Also stops `on_init_or_entered()` from needlessly being called twice in
the case of a movable atom in water being initialized before the water
turf. The signal `COMSIG_ATOM_AFTER_SUCCESSFUL_INITIALIZED_ON` already
sees to that.

## Why It's Good For The Game

Fixes a bug

## Changelog

🆑
fix: fixes immerse overlays not being added the first time a mob enters
a water turf
/🆑

* Fixes a bug with the immerse element

---------

Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>

2023-08-14 08:14:40 -04:00

__DEFINES

[MIRROR] guns' projectile damage multiplier reflected in examines, gives guns a vareditable projectile wound bonus modifier [MDB IGNORE] (#23049 )

2023-08-12 23:26:38 -04:00

__HELPERS

[MIRROR] Adds a unit test for client colours. [MDB IGNORE] (#23038 )

2023-08-12 10:15:53 -04:00

_globalvars

[MIRROR] Spiders don't automatically grant an antag datum [MDB IGNORE] (#23029 )

2023-08-12 00:17:56 -04:00

_js

…