Files
Bubberstation/code/datums/components/construction.dm
LemonInTheDark ae5a4f955d Pulls apart the vestiges of components still hanging onto signals (#75914)
## About The Pull Request

Signals were initially only usable with component listeners, which while
no longer the case has lead to outdated documentation, names, and a
similar location in code.

This pr pulls the two apart. Partially because mso thinks we should, but
also because they really aren't directly linked anymore, and having them
in this midstate just confuses people.

[Renames comp_lookup to listen_lookup, since that's what it
does](102b79694f)

[Moves signal procs over to their own
file](33d07d01fd)

[Renames the PREQDELETING and QDELETING comsigs to drop the parent bit
since they can hook to more then just comps
now](335ea4ad08)

[Does something similar to the attackby comsigs (PARENT ->
ATOM)](210e57051d)

[And finally passes over the examine
signals](65917658fb)

## Why It's Good For The Game

Code makes more sense, things are better teased apart, s just good imo

## Changelog
🆑
refactor: Pulled apart the last vestiges of names/docs directly linking
signals to components
/🆑
2023-06-09 06:14:31 +00:00

158 lines
4.1 KiB
Plaintext

/datum/component/construction
var/list/steps
var/result
var/index = 1
var/desc
/datum/component/construction/Initialize()
if(!isatom(parent))
return COMPONENT_INCOMPATIBLE
RegisterSignal(parent, COMSIG_ATOM_EXAMINE, PROC_REF(examine))
RegisterSignal(parent, COMSIG_ATOM_ATTACKBY, PROC_REF(action))
update_parent(index)
/datum/component/construction/proc/examine(datum/source, mob/user, list/examine_list)
SIGNAL_HANDLER
if(desc)
examine_list += desc
/datum/component/construction/proc/on_step()
if(index > steps.len)
spawn_result()
else
update_parent(index)
/datum/component/construction/proc/action(datum/source, obj/item/I, mob/living/user)
SIGNAL_HANDLER
ASYNC //This proc will never actually sleep, it calls do_after with a time of 0.
. = check_step(I, user)
return .
/datum/component/construction/proc/update_index(diff)
index += diff
on_step()
/datum/component/construction/proc/check_step(obj/item/I, mob/living/user)
var/diff = is_right_key(I)
if(diff && custom_action(I, user, diff))
update_index(diff)
return TRUE
return FALSE
/datum/component/construction/proc/is_right_key(obj/item/I) // returns index step
var/list/L = steps[index]
if(check_used_item(I, L["key"]))
return FORWARD //to the first step -> forward
else if(check_used_item(I, L["back_key"]))
return BACKWARD //to the last step -> backwards
return FALSE
/datum/component/construction/proc/check_used_item(obj/item/I, key)
if(!key)
return FALSE
if(ispath(key) && istype(I, key))
return TRUE
else if(I.tool_behaviour == key)
return TRUE
return FALSE
/datum/component/construction/proc/custom_action(obj/item/I, mob/living/user, diff)
var/target_index = index + diff
var/list/current_step = steps[index]
var/list/target_step
if(target_index > 0 && target_index <= steps.len)
target_step = steps[target_index]
. = TRUE
if(I.tool_behaviour)
. = I.use_tool(parent, user, 0, volume=50)
else if(diff == FORWARD)
switch(current_step["action"])
if(ITEM_DELETE)
. = user.transferItemToLoc(I, parent)
if(.)
qdel(I)
if(ITEM_MOVE_INSIDE)
. = user.transferItemToLoc(I, parent)
// Using stacks
else
if(isstack(I))
. = I.use_tool(parent, user, 0, volume=50, amount=current_step["amount"])
// Going backwards? Undo the last action. Drop/respawn the items used in last action, if any.
if(. && diff == BACKWARD && target_step && !target_step["no_refund"])
var/target_step_key = target_step["key"]
switch(target_step["action"])
if(ITEM_DELETE)
new target_step_key(drop_location())
if(ITEM_MOVE_INSIDE)
var/obj/item/located_item = locate(target_step_key) in parent
if(located_item)
located_item.forceMove(drop_location())
else
if(ispath(target_step_key, /obj/item/stack))
new target_step_key(drop_location(), target_step["amount"])
/datum/component/construction/proc/spawn_result()
// Some constructions result in new components being added.
if(ispath(result, /datum/component))
parent.AddComponent(result)
qdel(src)
else if(ispath(result, /atom))
new result(drop_location())
qdel(parent)
/datum/component/construction/proc/update_parent(step_index)
var/list/step = steps[step_index]
var/atom/parent_atom = parent
if(step["desc"])
desc = step["desc"]
if(step["icon_state"])
parent_atom.icon_state = step["icon_state"]
/datum/component/construction/proc/drop_location()
var/atom/parent_atom = parent
return parent_atom.drop_location()
// Unordered construction.
// Takes a list of part types, to be added in any order, as steps.
// Calls spawn_result() when every type has been added.
/datum/component/construction/unordered/check_step(obj/item/I, mob/living/user)
for(var/typepath in steps)
if(istype(I, typepath) && custom_action(I, user, typepath))
steps -= typepath
on_step()
return TRUE
return FALSE
/datum/component/construction/unordered/on_step()
if(!steps.len)
spawn_result()
else
update_parent(steps.len)
/datum/component/construction/unordered/update_parent(steps_left)
return
/datum/component/construction/unordered/custom_action(obj/item/I, mob/living/user, typepath)
return TRUE