mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-14 19:51:59 +00:00
c1d68698fb
Productionizes #80615. The core optimization is this: ```patch - var/hint = to_delete.Destroy(arglist(args.Copy(2))) // Let our friend know they're about to get fucked up. + var/hint = to_delete.Destroy(force) // Let our friend know they're about to get fucked up. ``` We avoid a heap allocation in the form of copying the args over to a new list. A/B testing shows this results in 33% better overtime, and in a real round shaving off a full second of self time and 0.4 seconds of overtime--both of these would be doubled in the event this is merged as the new proc was only being run 50% of the time.
88 lines
2.6 KiB
Plaintext
88 lines
2.6 KiB
Plaintext
/// Minimum duration between pulses for the radioactive emitter component.
|
|
/// This is chosen arbitrarily. It can theoretically go down to 0.1 SECONDS but god please don't
|
|
#define MIN_PULSE_COOLDOWN 0.5 SECONDS
|
|
|
|
/**
|
|
* # Radioactive Emitter
|
|
*
|
|
* Simple component that you can attach to something to make it emit radiation pulses over time.
|
|
*/
|
|
/datum/component/radioactive_emitter
|
|
dupe_mode = COMPONENT_DUPE_UNIQUE_PASSARGS
|
|
|
|
/// The actual cooldown between rad pulses
|
|
COOLDOWN_DECLARE(rad_pulse_cooldown)
|
|
|
|
/// The length of the cooldown between radiation pulses
|
|
var/cooldown_time = 5 SECONDS
|
|
/// How far the radiation pulses aggregate with other radiation pulses (see: [proc/radiation_pulse])
|
|
var/range = 1
|
|
/// How much radiation protection threshold is passed to the radiation pulse (see: [proc/radiation_pulse])
|
|
var/threshold = RAD_MEDIUM_INSULATION
|
|
/// Optional - What is shown on examine of the parent?
|
|
var/examine_text
|
|
|
|
/datum/component/radioactive_emitter/Initialize(
|
|
cooldown_time = 5 SECONDS,
|
|
range = 1,
|
|
threshold = RAD_MEDIUM_INSULATION,
|
|
examine_text,
|
|
)
|
|
|
|
if(!isturf(parent) && !ismovable(parent))
|
|
return COMPONENT_INCOMPATIBLE
|
|
|
|
src.cooldown_time = max(cooldown_time, MIN_PULSE_COOLDOWN)
|
|
src.range = range
|
|
src.threshold = threshold
|
|
src.examine_text = examine_text
|
|
|
|
// We process on fastprocess even though we're on a cooldown based system.
|
|
// Easier to handle edits to the cooldown duration, prevents timer spam for short cooldown emitters
|
|
START_PROCESSING(SSfastprocess, src)
|
|
|
|
/datum/component/radioactive_emitter/Destroy(force)
|
|
STOP_PROCESSING(SSfastprocess, src)
|
|
return ..()
|
|
|
|
/datum/component/radioactive_emitter/RegisterWithParent()
|
|
RegisterSignal(parent, COMSIG_ATOM_EXAMINE, PROC_REF(on_examine))
|
|
|
|
/datum/component/radioactive_emitter/UnregisterFromParent()
|
|
UnregisterSignal(parent, COMSIG_ATOM_EXAMINE)
|
|
|
|
/datum/component/radioactive_emitter/InheritComponent(
|
|
datum/component/new_comp,
|
|
i_am_original,
|
|
cooldown_time = 5 SECONDS,
|
|
range = 1,
|
|
threshold = RAD_NO_INSULATION,
|
|
examine_text,
|
|
)
|
|
|
|
if(!i_am_original)
|
|
return
|
|
|
|
// Only care about modifying our rad wave argument.
|
|
src.cooldown_time = cooldown_time
|
|
src.range = range
|
|
src.threshold = threshold
|
|
// Don't touch examine text or whatever else.
|
|
|
|
/datum/component/radioactive_emitter/process(seconds_per_tick)
|
|
if(!COOLDOWN_FINISHED(src, rad_pulse_cooldown))
|
|
return
|
|
|
|
COOLDOWN_START(src, rad_pulse_cooldown, cooldown_time)
|
|
radiation_pulse(parent, range, threshold)
|
|
|
|
/datum/component/radioactive_emitter/proc/on_examine(datum/source, mob/user, list/examine_list)
|
|
SIGNAL_HANDLER
|
|
|
|
if(!examine_text)
|
|
return
|
|
|
|
examine_list += examine_text
|
|
|
|
#undef MIN_PULSE_COOLDOWN
|