mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 09:42:29 +00:00
2d74a86353
About The Pull Request This PR removes speech message and span hooks from dna, mutations, pierrot throat disease, species, tongues, masks, hats, held items, brain traumas and a carbon proc overload handling tonguelessness. Tonguelessness is now handled by tongue removal registering for the speech signal and the hook being deregistered by having a tongue put in. Also cleans up some /atom/movable/proc/get_spans() overloads that called the empty parent or overloaded the parent to do the exact same thing as the parent proc did. Also cleans up calls to radio.talk_into() where the caller would often, as a result of copypasta, provide the proc with fresh copies of the proc's default values for proc args, and makes say_quote() better by giving it a default spans value so that none of the callers have to provide the same default one. Why It's Good For The Game Changelog cl Naksu code: Cleaned up saycode /cl * start with this * oh man this looks so good * hats are dead * /obj/item/proc/speechModification is dead * brain traumas and get_held_item_speechspans() are dead * these should be static * unfortunately we still need this * /mob/living/carbon/treat_message(message) is kill * clean up get_spans() * dunk get_spans, modifies_speech for brain traumas, some superfluous static stuff * move stuff around * return values