mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-22 15:05:11 +00:00
c44e22c5da
* Industrial lift should no longer phase through floors and ceilings (#63067) About The Pull Request There was no check to see if there was a ceiling above the elevator, so you could always go up if you wanted to, you just couldn't go down. There was also an issue where if the menu was opened and any change was made either up or down, it wouldn't be taken into account by the lift and it would do it anyway. That means that the top level could become unsuitable by someone blocking it off and the elevator wouldn't care. Finally, should fix the issue where the radial menu doesn't update when the lift move, causing you to be able to make illegal moves because there was no sanity checks. Now there is some sanity checks, and the menu will additionally close if the elevator has moved since you opened it. Just click on it again to open it once more. I also ended up documenting some of the code there while I was there, and improved a few variable names because they didn't follow coding standards. Why It's Good For The Game Going through floors and ceilings was in general a pretty bad thing about elevators. Now it shouldn't happen anymore. Changelog cl GoldenAlpharex fix: Elevators are no longer defying the laws of physics and therefore can no longer phase through ceilings or floors. fix: When an individual is interacting with an elevator and said elevator is moved, their menu will be closed if they weren't the one to cause that move, to prevent more physics-defying operations. code: Improved the industrial lift code by adding documentation and trying to enforce the coding standards in there while I was at it. /cl * Industrial lift should no longer phase through floors and ceilings Co-authored-by: GoldenAlpharex <58045821+GoldenAlpharex@users.noreply.github.com>