mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-11 10:11:09 +00:00
* Updates message for HREF Dock Exploit (#77891) ## About The Pull Request Hey there,  This message randomly popped up while I was adminning, and it was completely dogshit useless (as well as not being an HREF exploit since Snowdin was loaded and you should be expected to do that, but that's indicative of a harder bug). Let's yeet the `message_admins()` portion (as well as make it actually actable information rather than just 'Unknown' and give it an actual follow jump button) and if then if we don't have a client, stack_trace (in case people want to make basic mobs keymash to send shuttles in the future). ## Why It's Good For The Game This is completely useless and confusing. It's not even an HREF exploit because this behavior is completely intended. It's more helpful to coders now too because this thing failing isn't just locked to admin-only logs, it stack traces (which is publically available). ## Changelog 🆑 admin: The "HREF Dock Exploit" message should now contain a bit more usable information (such as a jump link) so you can investigate if something is really going wacky with shuttles. /🆑 --------- Co-authored-by: Gallyus <5572280+francinum@ users.noreply.github.com> * Updates message for HREF Dock Exploit --------- Co-authored-by: san7890 <the@san7890.com> Co-authored-by: Gallyus <5572280+francinum@ users.noreply.github.com>
249 lines
10 KiB
Plaintext
249 lines
10 KiB
Plaintext
#define SHUTTLE_CONSOLE_ACCESSDENIED "accessdenied"
|
|
#define SHUTTLE_CONSOLE_ENDGAME "endgame"
|
|
#define SHUTTLE_CONSOLE_RECHARGING "recharging"
|
|
#define SHUTTLE_CONSOLE_INTRANSIT "intransit"
|
|
#define SHUTTLE_CONSOLE_DESTINVALID "destinvalid"
|
|
#define SHUTTLE_CONSOLE_SUCCESS "success"
|
|
#define SHUTTLE_CONSOLE_ERROR "error"
|
|
|
|
/obj/machinery/computer/shuttle
|
|
name = "shuttle console"
|
|
desc = "A shuttle control computer."
|
|
icon_screen = "shuttle"
|
|
icon_keyboard = "tech_key"
|
|
light_color = LIGHT_COLOR_CYAN
|
|
req_access = list()
|
|
interaction_flags_machine = INTERACT_MACHINE_ALLOW_SILICON|INTERACT_MACHINE_SET_MACHINE
|
|
/// ID of the attached shuttle
|
|
var/shuttleId
|
|
/// Possible destinations of the attached shuttle
|
|
var/possible_destinations = ""
|
|
/// Variable dictating if the attached shuttle requires authorization from the admin staff to move
|
|
var/admin_controlled = FALSE
|
|
/// Variable dictating if the attached shuttle is forbidden to change destinations mid-flight
|
|
var/no_destination_swap = FALSE
|
|
/// ID of the currently selected destination of the attached shuttle
|
|
var/destination
|
|
/// If the console controls are locked
|
|
var/locked = FALSE
|
|
/// List of head revs who have already clicked through the warning about not using the console
|
|
var/static/list/dumb_rev_heads = list()
|
|
/// Authorization request cooldown to prevent request spam to admin staff
|
|
COOLDOWN_DECLARE(request_cooldown)
|
|
|
|
/obj/machinery/computer/shuttle/Initialize(mapload)
|
|
. = ..()
|
|
connect_to_shuttle(mapload, SSshuttle.get_containing_shuttle(src))
|
|
|
|
/obj/machinery/computer/shuttle/ui_interact(mob/user, datum/tgui/ui)
|
|
. = ..()
|
|
if(is_station_level(user.z) && user.mind && IS_HEAD_REVOLUTIONARY(user) && !(user.mind in dumb_rev_heads)) //Rev heads will get a one-time warning that they shouldn't leave
|
|
to_chat(user, span_warning("You get a feeling that leaving the station might be a REALLY dumb idea..."))
|
|
dumb_rev_heads += user.mind
|
|
return
|
|
if (HAS_TRAIT(user, TRAIT_FORBID_MINING_SHUTTLE_CONSOLE_OUTSIDE_STATION) && !is_station_level(user.z)) //Free golems and other mobs with this trait will not be able to use the shuttle from outside the station Z
|
|
to_chat(user, span_warning("You get the feeling you shouldn't mess with this."))
|
|
return
|
|
if(!user.can_read(src, reading_check_flags = READING_CHECK_LITERACY)) //Illiterate mobs which aren't otherwise blocked from using computers will send the shuttle to a random valid destination
|
|
to_chat(user, span_warning("You start mashing buttons at random!"))
|
|
if(do_after(user, 10 SECONDS, target = src))
|
|
var/list/dest_list = get_valid_destinations()
|
|
if(!dest_list.len) //No valid destinations
|
|
to_chat(user, span_warning("The console shows a flashing error message, but you can't comprehend it."))
|
|
return
|
|
var/list/destination = pick(dest_list)
|
|
switch (send_shuttle(destination["id"], user))
|
|
if (SHUTTLE_CONSOLE_SUCCESS)
|
|
return
|
|
else
|
|
to_chat(user, span_warning("The console shows a flashing error message, but you can't comprehend it."))
|
|
return
|
|
return
|
|
ui = SStgui.try_update_ui(user, src, ui)
|
|
if(!ui)
|
|
ui = new(user, src, "ShuttleConsole", name)
|
|
ui.open()
|
|
|
|
/obj/machinery/computer/shuttle/ui_data(mob/user)
|
|
var/list/data = list()
|
|
var/obj/docking_port/mobile/mobile_docking_port = SSshuttle.getShuttle(shuttleId)
|
|
data["docked_location"] = mobile_docking_port ? mobile_docking_port.get_status_text_tgui() : "Unknown"
|
|
data["locations"] = list()
|
|
data["locked"] = locked
|
|
data["authorization_required"] = admin_controlled
|
|
data["timer_str"] = mobile_docking_port ? mobile_docking_port.getTimerStr() : "00:00"
|
|
data["destination"] = destination
|
|
if(!mobile_docking_port)
|
|
data["status"] = "Missing"
|
|
return data
|
|
if(admin_controlled)
|
|
data["status"] = "Unauthorized Access"
|
|
else if(locked)
|
|
data["status"] = "Locked"
|
|
else
|
|
switch(mobile_docking_port.mode)
|
|
if(SHUTTLE_IGNITING)
|
|
data["status"] = "Igniting"
|
|
if(SHUTTLE_IDLE)
|
|
data["status"] = "Idle"
|
|
if(SHUTTLE_RECHARGING)
|
|
data["status"] = "Recharging"
|
|
else
|
|
data["status"] = "In Transit"
|
|
data["locations"] = get_valid_destinations()
|
|
if(length(data["locations"]) == 1)
|
|
for(var/location in data["locations"])
|
|
destination = location["id"]
|
|
data["destination"] = destination
|
|
if(!length(data["locations"]))
|
|
data["locked"] = TRUE
|
|
data["status"] = "Locked"
|
|
return data
|
|
|
|
/**
|
|
* Checks if we are allowed to launch the shuttle
|
|
*
|
|
* Arguments:
|
|
* * user - The mob trying to initiate the launch
|
|
*/
|
|
/obj/machinery/computer/shuttle/proc/launch_check(mob/user)
|
|
if(!allowed(user)) //Normally this is already checked via interaction code but some cases may skip that so check it explicitly here (illiterates launching randomly)
|
|
return FALSE
|
|
return TRUE
|
|
|
|
/**
|
|
* Returns a list of currently valid destinations for this shuttle console,
|
|
* taking into account its list of allowed destinations, their current state, and the shuttle's current location
|
|
**/
|
|
/obj/machinery/computer/shuttle/proc/get_valid_destinations()
|
|
var/list/destination_list = params2list(possible_destinations)
|
|
var/obj/docking_port/mobile/mobile_docking_port = SSshuttle.getShuttle(shuttleId)
|
|
var/obj/docking_port/stationary/current_destination = mobile_docking_port.destination
|
|
var/list/valid_destinations = list()
|
|
for(var/obj/docking_port/stationary/stationary_docking_port in SSshuttle.stationary_docking_ports)
|
|
if(!destination_list.Find(stationary_docking_port.port_destinations))
|
|
continue
|
|
if(!mobile_docking_port.check_dock(stationary_docking_port, silent = TRUE))
|
|
continue
|
|
if(stationary_docking_port == current_destination)
|
|
continue
|
|
var/list/location_data = list(
|
|
id = stationary_docking_port.shuttle_id,
|
|
name = stationary_docking_port.name
|
|
)
|
|
valid_destinations += list(location_data)
|
|
return valid_destinations
|
|
|
|
/**
|
|
* Attempts to send the linked shuttle to dest_id, checking various sanity checks to see if it can move or not
|
|
*
|
|
* Arguments:
|
|
* * dest_id - The ID of the stationary docking port to send the shuttle to
|
|
* * user - The mob that used the console
|
|
*/
|
|
/obj/machinery/computer/shuttle/proc/send_shuttle(dest_id, mob/user)
|
|
if(!launch_check(user))
|
|
return SHUTTLE_CONSOLE_ACCESSDENIED
|
|
var/obj/docking_port/mobile/shuttle_port = SSshuttle.getShuttle(shuttleId)
|
|
if(shuttle_port.launch_status == ENDGAME_LAUNCHED)
|
|
return SHUTTLE_CONSOLE_ENDGAME
|
|
if(no_destination_swap)
|
|
if(shuttle_port.mode == SHUTTLE_RECHARGING)
|
|
return SHUTTLE_CONSOLE_RECHARGING
|
|
if(shuttle_port.mode != SHUTTLE_IDLE)
|
|
return SHUTTLE_CONSOLE_INTRANSIT
|
|
//check to see if the dest_id passed from tgui is actually a valid destination
|
|
var/list/dest_list = get_valid_destinations()
|
|
var/validdest = FALSE
|
|
for(var/list/dest_data in dest_list)
|
|
if(dest_data["id"] == dest_id)
|
|
validdest = TRUE //Found our destination, we can skip ahead now
|
|
break
|
|
if(!validdest) //Didn't find our destination in the list of valid destinations, something bad happening
|
|
if(!isnull(user.client))
|
|
log_admin("Warning: possible href exploit by [key_name(user)] - Attempted to dock [src] to illegal target location \"[url_encode(dest_id)]\"")
|
|
message_admins("Warning: possible href exploit by [key_name_admin(user)] [ADMIN_FLW(user)] - Attempted to dock [src] to illegal target location \"[url_encode(dest_id)]\"")
|
|
else
|
|
stack_trace("[user] ([user.type]) tried to send the shuttle [src] to the target location [dest_id], but the target location was not found in the list of valid destinations.")
|
|
return SHUTTLE_CONSOLE_DESTINVALID
|
|
switch(SSshuttle.moveShuttle(shuttleId, dest_id, TRUE))
|
|
if(DOCKING_SUCCESS)
|
|
say("Shuttle departing. Please stand away from the doors.")
|
|
log_shuttle("[key_name(user)] has sent shuttle \"[shuttleId]\" towards \"[dest_id]\", using [src].")
|
|
return SHUTTLE_CONSOLE_SUCCESS
|
|
else
|
|
return SHUTTLE_CONSOLE_ERROR
|
|
|
|
/obj/machinery/computer/shuttle/ui_act(action, params)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
if(!allowed(usr))
|
|
to_chat(usr, span_danger("Access denied."))
|
|
return
|
|
|
|
switch(action)
|
|
if("move")
|
|
switch (send_shuttle(params["shuttle_id"], usr)) //Try to send the shuttle, tell the user what happened
|
|
if (SHUTTLE_CONSOLE_ACCESSDENIED)
|
|
to_chat(usr, span_warning("Access denied."))
|
|
return
|
|
if (SHUTTLE_CONSOLE_ENDGAME)
|
|
to_chat(usr, span_warning("You've already escaped. Never going back to that place again!"))
|
|
return
|
|
if (SHUTTLE_CONSOLE_RECHARGING)
|
|
to_chat(usr, span_warning("Shuttle engines are not ready for use."))
|
|
return
|
|
if (SHUTTLE_CONSOLE_INTRANSIT)
|
|
to_chat(usr, span_warning("Shuttle already in transit."))
|
|
return
|
|
if (SHUTTLE_CONSOLE_DESTINVALID)
|
|
to_chat(usr, span_warning("Invalid destination."))
|
|
return
|
|
if (SHUTTLE_CONSOLE_ERROR)
|
|
to_chat(usr, span_warning("Unable to comply."))
|
|
return
|
|
if (SHUTTLE_CONSOLE_SUCCESS)
|
|
return TRUE //No chat message here because the send_shuttle proc makes the console itself speak
|
|
if("set_destination")
|
|
var/target_destination = params["destination"]
|
|
if(target_destination)
|
|
destination = target_destination
|
|
return TRUE
|
|
if("request")
|
|
if(!COOLDOWN_FINISHED(src, request_cooldown))
|
|
to_chat(usr, span_warning("CentCom is still processing last authorization request!"))
|
|
return
|
|
COOLDOWN_START(src, request_cooldown, 1 MINUTES)
|
|
to_chat(usr, span_notice("Your request has been received by CentCom."))
|
|
to_chat(GLOB.admins, "<b>SHUTTLE: <font color='#3d5bc3'>[ADMIN_LOOKUPFLW(usr)] (<A HREF='?_src_=holder;[HrefToken()];move_shuttle=[shuttleId]'>Move Shuttle</a>)(<A HREF='?_src_=holder;[HrefToken()];unlock_shuttle=[REF(src)]'>Lock/Unlock Shuttle</a>)</b> is requesting to move or unlock the shuttle.</font>")
|
|
return TRUE
|
|
|
|
/obj/machinery/computer/shuttle/emag_act(mob/user, obj/item/card/emag/emag_card)
|
|
if(obj_flags & EMAGGED)
|
|
return FALSE
|
|
req_access = list()
|
|
obj_flags |= EMAGGED
|
|
balloon_alert(user, "id checking system fried")
|
|
return TRUE
|
|
|
|
/obj/machinery/computer/shuttle/connect_to_shuttle(mapload, obj/docking_port/mobile/port, obj/docking_port/stationary/dock)
|
|
if(!mapload)
|
|
return
|
|
if(!port)
|
|
return
|
|
//Remove old custom port id and ";;"
|
|
var/find_old = findtextEx(possible_destinations, "[shuttleId]_custom")
|
|
if(find_old)
|
|
possible_destinations = replacetext(replacetextEx(possible_destinations, "[shuttleId]_custom", ""), ";;", ";")
|
|
shuttleId = port.shuttle_id
|
|
possible_destinations += ";[port.shuttle_id]_custom"
|
|
|
|
#undef SHUTTLE_CONSOLE_ACCESSDENIED
|
|
#undef SHUTTLE_CONSOLE_ENDGAME
|
|
#undef SHUTTLE_CONSOLE_RECHARGING
|
|
#undef SHUTTLE_CONSOLE_INTRANSIT
|
|
#undef SHUTTLE_CONSOLE_DESTINVALID
|
|
#undef SHUTTLE_CONSOLE_SUCCESS
|
|
#undef SHUTTLE_CONSOLE_ERROR
|