cyberpresidentvanellope/Bubberstation
1
0
Fork 0
mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-02-09 15:59:24 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
c49e0959c9532b1cd0454ab2aa8639b53d448cd7
Bubberstation/code/datums/elements
History
SkyratBot 4927d33e27 [MIRROR] Fixes a footsteps runtime [MDB IGNORE] (#25240) 
* Fixes a footsteps runtime (#79903)

## About The Pull Request

Tin. Fixes the following runtime:

![image](https://github.com/tgstation/tgstation/assets/13398309/e4cd087f-3c6e-49f7-aaa4-2a91ca1b9a79)

Which happened because `barefoot_type` can potentially be null if
`turf.barefootstep` is null.

![Code_KnExLVOSD4](https://github.com/tgstation/tgstation/assets/13398309/1b3c97d5-500b-4d3d-a104-8dac7071fae0)

This results in trying to access `GLOB.barefootstep[null]`, which
results in a runtime, which prevents the `play_fov_effect()` from
executing.

## Why It's Good For The Game

Less CI failures, and fixes a bug.

## Changelog

🆑
fix: fixes a runtime in footstep code that would prevent the fov effect
from playing to nearby mobs
/🆑

* Fixes a footsteps runtime

---------

Co-authored-by: Bloop <13398309+vinylspiders@users.noreply.github.com>
2023-11-25 13:17:29 -05:00
..
decals
[MIRROR] Adds a unit test to stop elements from using identical lists for their arguments. [MDB IGNORE] (#22732)
2023-07-27 20:08:55 -04:00
food
[MIRROR] Fixes some fried food exploits [MDB IGNORE] (#25083)
2023-11-18 02:03:18 -05:00
screentips
[MIRROR] Clarifies some silicon interactions via screentips, also converts some stuff to balloon alerts [MDB IGNORE] (#22417)
2023-07-12 21:55:58 -04:00
_element.dm
[MIRROR] Adds a unit test to stop elements from using identical lists for their arguments. [MDB IGNORE] (#22732)
2023-07-27 20:08:55 -04:00
ai_control_examine.dm
…
ai_flee_while_injured.dm
[MIRROR] Goats will randomly attack you [MDB IGNORE] (#24312)
2023-10-13 00:30:01 -07:00
ai_held_item.dm
[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)
2023-07-18 22:10:59 -04:00
ai_retaliate.dm
[MIRROR] Unit Tests for AI Planning Subtrees not having required element/component [MDB IGNORE] (#23047)
2023-08-12 18:34:53 -04:00
ai_swap_combat_mode.dm
[MIRROR] Converts traders to basic mobs [MDB IGNORE] (#24673)
2023-10-31 02:16:50 -04:00
ai_target_damagesource.dm
…
amputating_limbs.dm
[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)
2023-10-16 12:37:49 -04:00
animal_variety.dm
…
art.dm
[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)
2023-07-18 22:10:59 -04:00
atmos_requirements.dm
[MIRROR] Simple and basic mobs can breath pluoxium [MDB IGNORE] (#22347)
2023-07-11 14:59:15 -05:00
atmos_sensitive.dm
[MIRROR] Optimization pass focused on foam code (saves about 30% of cpu usage I think) [MDB IGNORE] (#22530)
2023-07-18 16:49:51 -04:00
attack_equip.dm
…
backblast.dm
…
bane.dm
[MIRROR] Assistants get a liver trait + Officer's sabre banes against them [MDB IGNORE] (#21763)
2023-06-10 19:43:38 -07:00
basic_body_temp_sensitive.dm
…
basic_eating.dm
[MIRROR] Basic skeletons [MDB IGNORE] (#24545)
2023-10-24 11:14:35 -07:00
beauty.dm
…
bed_tucking.dm
[MIRROR] Renames COMSIG_ITEM_ATTACK_OBJ to COMSIG_ITEM_ATTACK_ATOM [MDB IGNORE] (#21916)
2023-06-18 14:51:14 +00:00
befriend_petting.dm
[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)
2023-07-18 22:10:59 -04:00
blocks_explosives.dm
[MIRROR] block_explosives remove remnants when detached. [MDB IGNORE] (#21656)
2023-06-07 15:43:16 +02:00
bombable_turf.dm
[MIRROR] Replace wall/indestructible/destructible typepath with mapping helper [MDB IGNORE] (#23735)
2023-09-17 14:41:05 -04:00
bonus_damage.dm
[MIRROR] Spider Evolution - Young Spiders [Ready] [MDB IGNORE] (#22972)
2023-08-09 17:59:34 -04:00
bsa_blocker.dm
…
bugkiller_reagent.dm
[MIRROR] Adds Roach Infusion to the DNA infuser [MDB IGNORE] (#22190)
2023-07-14 23:11:18 -04:00
bump_click.dm
…
can_barricade.dm
[MIRROR] [NO GBP] Fix barricade description element spam [MDB IGNORE] (#23783)
2023-09-18 14:42:59 -04:00
caseless.dm
[MIRROR] Different pen types have unique behavior when used in foam darts. [MDB IGNORE] (#25183)
2023-11-21 22:54:35 -05:00
chemical_transfer.dm
[MIRROR] Code compression for reagent holder. Lowers plumbing reaction chamber tick usage [MDB IGNORE] (#25050)
2023-11-16 18:27:20 -05:00
chewable.dm
…
cleaning.dm
…
cliff_walker.dm
[MIRROR] Adds cliffs to icebox [MDB IGNORE] (#22744)
2023-07-28 14:31:06 -04:00
climbable.dm
[MIRROR] Hands management element [MDB IGNORE] (#24257)
2023-10-10 23:02:36 -04:00
connect_loc.dm
[MIRROR] Adds a unit test to stop elements from using identical lists for their arguments. [MDB IGNORE] (#22732)
2023-07-27 20:08:55 -04:00
content_barfer.dm
[MIRROR] Synchronise AI and Player basic mob melee behaviours [MDB IGNORE] (#23780)
2023-09-18 15:23:14 -04:00
crackable.dm
…
crusher_loot.dm
Adds ability for Ashwalkers to get trophies from non-megafauna mobs that drop crusher loot (#22225)
2023-07-04 03:46:42 -07:00
cuffsnapping.dm
[MIRROR] Removes final remnants of 'targetted' [MDB IGNORE] (#24927)
2023-11-11 08:11:32 -05:00
cult_eyes.dm
…
cult_halo.dm
…
curse_announcement.dm
…
cursed.dm
…
damage_threshold.dm
[MIRROR] Mob attackedby / check_block refactor, plus some minor cleanup of attack_x procs [MDB IGNORE] (#25079)
2023-11-18 02:19:31 -05:00
dangerous_surgical_removal.dm
[MIRROR] Bargain bin organ quirks: Prosthetic organ and Tin Man [MDB IGNORE] (#22297)
2023-07-20 16:37:43 -04:00
death_drops.dm
…
death_explosion.dm
…
death_gases.dm
…
delete_on_drop.dm
…
deliver_first.dm
[MIRROR] Pulls apart the vestiges of components still hanging onto signals [MDB IGNORE] (#21738)
2023-06-18 13:18:23 +00:00
dextrous.dm
[MIRROR] Basic Guardians/Holoparasites [MDB IGNORE] (#24921)
2023-11-11 07:07:34 -05:00
diggable.dm
…
digitalcamo.dm
[MIRROR] Pulls apart the vestiges of components still hanging onto signals [MDB IGNORE] (#21738)
2023-06-18 13:18:23 +00:00
door_pryer.dm
[MIRROR] Targeting Datums Renamed (and global) [MDB IGNORE] (#24885)
2023-11-09 16:37:48 -05:00
drag_pickup.dm
…
dryable.dm
[MIRROR] Removes some food initialize arguments [MDB IGNORE] (#23712)
2023-09-15 12:30:43 -04:00
earhealing.dm
[MANUAL MIRROR] Robotic organ and disease improvements (#22631)
2023-08-04 15:07:07 -04:00
easily_fragmented.dm
…
effect_trail.dm
[MIRROR] transform the paper wizard from a simple to a basic [MDB IGNORE] (#22452)
2023-07-14 13:10:55 -04:00
ELEMENT_TEMPLATE.md
…
embed.dm
[MIRROR] Heretic Knock Path [MDB IGNORE] (#23810)
2023-09-19 13:28:35 -07:00
empprotection.dm
[MIRROR] Refactors chameleon actions, Adds chameleon outfit saving, Adds chameleon scanner [MDB IGNORE] (#22773)
2023-07-29 21:09:06 -04:00
envenomable_casing.dm
[MIRROR] [NO GBP] Fixes the venomous element for projectiles, invisible arrows and something off with envenomable casings. [MDB IGNORE] (#22339)
2023-07-11 19:15:35 -04:00
eyestab.dm
…
falling_hazard.dm
…
firestacker.dm
…
floorloving.dm
…
footstep_override.dm
[MIRROR] [NO GBP] Fixes catwalks over open space not making a sound when walked over. [MDB IGNORE] (#25036)
2023-11-15 21:29:11 -05:00
footstep.dm
[MIRROR] Fixes a footsteps runtime [MDB IGNORE] (#25240)
2023-11-25 13:17:29 -05:00
forced_gravity.dm
[MIRROR] Attempts to fix an issue with gravity generators triggering CI failures [MDB IGNORE] (#22588)
2023-07-19 15:26:25 -04:00
frozen.dm
…
gags_recolorable.dm
[MIRROR] GAGS, recolorable and actually glowing glow shoes. [MDB IGNORE] (#23568)
2023-09-07 20:25:08 -04:00
give_turf_traits.dm
[MIRROR] Removes two redundant components [MDB IGNORE] (#22613)
2023-07-21 13:27:45 -04:00
haunted.dm
[MIRROR] Adds hauntium as a reagent with new fun uses. [MDB IGNORE] (#23027)
2023-08-11 23:49:29 -04:00
high_fiver.dm
[MIRROR] Fix Too Slowing people with high fives [MDB IGNORE] (#22086)
2023-07-12 15:22:07 -04:00
honkspam.dm
…
human_biter.dm
[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)
2023-10-16 12:37:49 -04:00
immerse.dm
[MIRROR] Adds UPSIDE_DOWN movetype for negative gravity / makes Atrocinator affected by less things [MDB IGNORE] (#25155)
2023-11-20 17:10:59 -05:00
item_fov.dm
…
item_scaling.dm
…
kneecapping.dm
[MIRROR] Removes final remnants of 'targetted' [MDB IGNORE] (#24927)
2023-11-11 08:11:32 -05:00
kneejerk.dm
…
knockback.dm
[MIRROR] Implements usage of the REVERSE_DIR macro throughout the code. [MDB IGNORE] (#22743)
2023-07-28 14:32:01 -04:00
lazy_fishing_spot.dm
[MIRROR] Miscellaneous fishing code changes. [MDB IGNORE] (#23237)
2023-08-21 11:39:47 -04:00
lifesteal.dm
…
light_blocking.dm
…
light_eaten.dm
[MIRROR] Light-Eaten objects can no longer emit light after being turned off and then back on [MDB IGNORE] (#24644)
2023-10-29 08:19:56 -04:00
light_eater.dm
[MIRROR] Fix light eater affecting lava, space, openspace, and transparent turfs [MDB IGNORE] (#24826)
2023-11-06 21:21:31 -05:00
loomable.dm
[MIRROR] loopable looms [MDB IGNORE] (#25013)
2023-11-14 17:11:49 -05:00
mirage_border.dm
[MIRROR] Optimize mirage_border by converting it to an element and a movable [MDB IGNORE] (#22913)
2023-08-07 09:41:46 -04:00
mob_grabber.dm
[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)
2023-10-16 12:37:49 -04:00
mob_killed_tally.dm
…
move_force_on_death.dm
[MIRROR] [no gbp] fixes not being able to walk over mook corpses and turns it all to a element [MDB IGNORE] (#24497)
2023-10-21 18:18:44 -04:00
movement_turf_changer.dm
[MIRROR] Splits placeontop proc [MDB IGNORE] (#25103)
2023-11-19 10:28:18 -05:00
movetype_handler.dm
…
nerfed_pulling.dm
…
noisy_movement.dm
[MIRROR] Adds an element for noisy movement (wheelchairs, office chairs, trashcarts etc. etc.) [MDB IGNORE] (#22172)
2023-07-01 14:15:34 -04:00
noticable_organ.dm
[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)
2023-07-18 22:10:59 -04:00
obj_regen.dm
…
openspace_item_click_handler.dm
[MIRROR] Multi-Z Support for Lazy Templates | Cleans up some turf flag misuse [MDB IGNORE] (#23794)
2023-09-19 13:26:14 -04:00
ore_collecting.dm
[MIRROR] basic gutlunchers and ashwalker ranching [MDB IGNORE] (#24970)
2023-11-13 09:42:16 -05:00
organ_set_bonus.dm
[MIRROR] Pulls apart the vestiges of components still hanging onto signals [MDB IGNORE] (#21738)
2023-06-18 13:18:23 +00:00
pet_bonus.dm
[MIRROR] Refactors Parrots into Basic Mobs (ft. Ben10Omintrix/Kobsamobsa) [MDB IGNORE] (#25100)
2023-11-20 09:57:34 -05:00
plant_backfire.dm
…
point_of_interest.dm
…
prevent_attacking_of_types.dm
…
projectile_drop.dm
[MIRROR] Fixing embedding for projectiles. [MDB IGNORE] (#23217)
2023-08-20 20:11:26 -04:00
projectile_shield.dm
…
radiation_protected_clothing.dm
[MIRROR] Pulls apart the vestiges of components still hanging onto signals [MDB IGNORE] (#21738)
2023-06-18 13:18:23 +00:00
radioactive.dm
[MIRROR] [NO-GBP] Optimizes rad nebula [MDB IGNORE] (#22675)
2023-07-25 13:26:22 -04:00
ranged_armour.dm
[MIRROR] Elementises mining mob resistance to being attacked from off screen [MDB IGNORE] (#22362)
2023-07-13 12:49:39 -04:00
relay_attackers.dm
[MIRROR] Fixes Relay Attackers Misfire [MDB IGNORE] (#25039)
2023-11-15 21:28:10 -05:00
ridable.dm
…
rust.dm
[MIRROR] Standardize Welder Fuel Usage [MDB IGNORE] (#21943)
2023-06-20 09:39:49 -07:00
selfknockback.dm
…
series.dm
[MIRROR] Pulls apart the vestiges of components still hanging onto signals [MDB IGNORE] (#21738)
2023-06-18 13:18:23 +00:00
shatters_when_thrown.dm
…
sideway_movement.dm
[MIRROR] [NO GBP] fixes crab walking [MDB IGNORE] (#24000)
2023-09-28 19:57:20 -04:00
simple_flying.dm
…
skill_reward.dm
[MIRROR] Fixes greyscale colors not updating when changing their colors via VV, and fixes some issues with accessories [MDB IGNORE] (#23346)
2023-08-26 16:38:29 -04:00
skittish.dm
[MIRROR] minor changes to living and mob vars [MDB IGNORE] (#23330)
2023-08-26 04:21:42 -04:00
snail_crawl.dm
…
soft_landing.dm
…
spooky.dm
…
squish.dm
…
sticker.dm
[MIRROR] Adds Source Count Macro [MDB IGNORE] (#23017)
2023-08-11 15:18:06 -04:00
strippable.dm
[MIRROR] Fixes some heretic bugs (?) [MDB IGNORE] (#23386)
2023-08-28 14:32:05 -07:00
structure_repair.dm
[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)
2023-10-16 12:37:49 -04:00
swabbable.dm
…
temporary_atom.dm
[MISSED MIRROR] Various spider fixes (#76528) (#22395)
2023-07-12 10:16:55 -07:00
tenacious.dm
…
tiny_mob_hunter.dm
…
tool_flash.dm
…
turf_transparency.dm
[MIRROR] Multi-Z Support for Lazy Templates | Cleans up some turf flag misuse [MDB IGNORE] (#23794)
2023-09-19 13:26:14 -04:00
undertile.dm
[MIRROR] Invisibility refactor [MDB IGNORE] (#24405)
2023-10-18 00:36:09 -04:00
unfriend_attacker.dm
…
update_icon_blocker.dm
…
update_icon_updates_onmob.dm
…
uplink_reimburse.dm
[MIRROR] Holo para refund fix [MDB IGNORE] (#23823)
2023-09-20 19:20:21 -04:00
venomous.dm
…
volatile_gas_storage.dm
…
waddling.dm
[MIRROR] Basic Mob Raw Prophet [MDB IGNORE] (#24099)
2023-10-03 19:59:50 -04:00
wall_engraver.dm
[MIRROR] Pulls apart the vestiges of components still hanging onto signals [MDB IGNORE] (#21738)
2023-06-18 13:18:23 +00:00
wall_smasher.dm
[MIRROR] Refactors UnarmedAttack so we don't have like 4 Unarmed Attack signals, kills two more snowflake species procs [MDB IGNORE] (#24356)
2023-10-16 12:37:49 -04:00
wall_tearer.dm
[MIRROR] basic gutlunchers and ashwalker ranching [MDB IGNORE] (#24970)
2023-11-13 09:42:16 -05:00
wall_walker.dm
[MIRROR] Basic Constructs: parent type + Harvester [MDB IGNORE] (#24258)
2023-10-10 18:37:00 -04:00
weapon_description.dm
[MIRROR] Adds p_They (and friends) for capitalized pronoun helpers [MDB IGNORE] (#22555)
2023-07-18 22:10:59 -04:00
weather_listener.dm
[MIRROR] Shapechange health transfer tweaks [MDB IGNORE] (#24590)
2023-10-26 06:16:19 -04:00
web_walker.dm
…
wheel.dm
[MIRROR] Basic Mob Raw Prophet [MDB IGNORE] (#24099)
2023-10-03 19:59:50 -04:00