mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-30 11:32:20 +00:00
41bba9931f
## About The Pull Request As the title says, you can no longer become an antagonist if you can't qualify for a role beforehand. How this works is that it runs job assignment before antagonist roles are handed out to see which players can qualify for a job role. It then undoes job assignments and then runs antagonist assignment. This is to prevent players from setting a highly contested role to low priority so that they have a 0% chance of ever getting it, whilst still being eligible for every antag role. It's not completely foolproof as it's not really possible to account for the fact that some players may become antagonists, thereby freeing up some job slots. Since it's an approximation, it means that players who put themselves at a high chance of returning back to lobby due to their preference choices have an overall lower chance of becoming an antagonist as they can be excluded from the antagonist roll due to the random nature of job selection. If players want to prevent this from happening, simply set a lot of jobs to low/medium priority or adjust the "Return back to lobby" preference to any other preference. ## Why It's Good For The Game Prevents players from rolling antag without ever intending to play the game as a non-antagonist. ## Changelog 🆑 fix: Fixed players being able to roll antagonist without ever being eligible to play any role. Players who have their preferences set up so that they're likely to return to lobby when the round starts have a lowered chance of becoming antagonist. /🆑 --------- Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>