mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 17:52:36 +00:00
cb3b675bae
* Tablets don't close their UI when changing program (and some fixes) (#73635) ## About The Pull Request - Tablets now refresh their page when changing programs, this means the UI will no longer close and reopen itself several times (or even have several UIs open if shit broke hard enough). - Removed tablet's attack self because interact already does everything it had to do. - Header programs now close when minimized (as there's no button to close them in the main menu. - Removed a lot of program UI stuff, it's now handled by the PC itself, such as header data and ui host. - Cut off asset sending from TGUI into it's own proc so I can re-send assets when changing programs - Added an ejection button for machine computers - Fixed ID not ejecting into the user's hand when using 'Eject ID' - Fixes a minor runtime when opening the MODsuit application without a MODsuit already connected. ## Why It's Good For The Game Fixes some bugs that I found with tablets UIS now won't be flickering as bad in front of them, or have inconsistent placement (like when you move your main menu UI, go to Messenger, then it's back to the center of the screen). Video of it in action https://user-images.githubusercontent.com/53777086/221301417-78321149-0c10-475e-bd29-79f5a4ba0597.mp4 ## Changelog 🆑 fix: Being in an application now properly uses the tablet's battery. fix: Messenger and Themify apps now close when minimized, so don't count towards the running app limit. fix: Tablet UIs will now no longer spam open/close the UI when changing applications fix: Using the Eject ID button on tablets now ejects into your hand. fix: Computers now have an Eject ID button refactor: Cut down a lot of copy paste in tablet & program code, now it's mostly done by the tablet. /🆑 * Tablets don't close their UI when changing program (and some fixes) * Update contractor_tablet.dm * wew --------- Co-authored-by: John Willard <53777086+JohnFulpWillard@users.noreply.github.com> Co-authored-by: Zonespace <41448081+Zonespace27@users.noreply.github.com> Co-authored-by: Gandalf <9026500+Gandalf2k15@users.noreply.github.com>
49 lines
1.6 KiB
Plaintext
49 lines
1.6 KiB
Plaintext
/datum/computer_file/program/maintenance/modsuit_control
|
|
filename = "modsuit_control"
|
|
filedesc = "MODsuit Control"
|
|
program_icon_state = "modsuit_control"
|
|
category = PROGRAM_CATEGORY_SCI
|
|
extended_desc = "This program allows people to connect a MODsuit to it, allowing remote control."
|
|
size = 2
|
|
tgui_id = "NtosMODsuit"
|
|
program_icon = "user-astronaut"
|
|
|
|
///The suit we have control over.
|
|
var/obj/item/mod/control/controlled_suit
|
|
|
|
/datum/computer_file/program/maintenance/modsuit_control/Destroy()
|
|
if(controlled_suit)
|
|
unsync_modsuit()
|
|
return ..()
|
|
|
|
/datum/computer_file/program/maintenance/modsuit_control/application_attackby(obj/item/attacking_item, mob/living/user)
|
|
. = ..()
|
|
if(!istype(attacking_item, /obj/item/mod/control))
|
|
return FALSE
|
|
if(controlled_suit)
|
|
unsync_modsuit()
|
|
controlled_suit = attacking_item
|
|
RegisterSignal(controlled_suit, COMSIG_PARENT_QDELETING, PROC_REF(unsync_modsuit))
|
|
user.balloon_alert(user, "suit updated")
|
|
return TRUE
|
|
|
|
/datum/computer_file/program/maintenance/modsuit_control/proc/unsync_modsuit(atom/source)
|
|
UnregisterSignal(controlled_suit, COMSIG_PARENT_QDELETING)
|
|
controlled_suit = null
|
|
|
|
/datum/computer_file/program/maintenance/modsuit_control/ui_data(mob/user)
|
|
var/list/data = list()
|
|
data["has_suit"] = !!controlled_suit
|
|
if(controlled_suit)
|
|
data += controlled_suit.ui_data()
|
|
return data
|
|
|
|
/datum/computer_file/program/maintenance/modsuit_control/ui_static_data(mob/user)
|
|
return controlled_suit?.ui_static_data()
|
|
|
|
/datum/computer_file/program/maintenance/modsuit_control/ui_act(action, list/params, datum/tgui/ui, datum/ui_state/state)
|
|
. = ..()
|
|
if(.)
|
|
return
|
|
controlled_suit.ui_act(action, params, ui, state)
|