mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-16 12:07:48 +00:00
5ddfd035e6
# About The Pull Request Around 4 years ago an overriding proc in carbons, `take_overall_damage`, dropped a positional argument for stamina, but the calls to it were not adjusted. This PR fixes a 4 year old bug wherein the `adjustBruteLoss` and `adjustFireLoss` functions were not working as expected for robotic bodyparts, and in most cases leads to robotic limbs being invulnerable to spread damage/healing. The bug also affected the Var Viewer and any admin-heals. In downstream repositories such as Skyrat-tg, where there are fully robotic characters, some severe impact was seen such as the inability to revive/heal players without fully respawning them. The bug was caused by out-of-order positional arguments in the calls to `/mob/living/carbon/take_overall_damage` and `/obj/item/bodypart/proc/receive_damage` within `adjustBruteLoss` and `adjustFireLoss`, which caused its `updating_health` argument to wind up in the wrong position, occupying the same position as `required_status` which is then interpreted by the proc to mean bitflag `BODYTYPE_ORGANIC`. Furthermore, the default argument for `required_status` and `heal_overall_damage` is currently also `BODYTYPE_ORGANIC`, which would cause the issue to persist and prevent most forms of spread-healing and spread-damage to robotic/surplus limbs. I also found that, after fixing the bug, robotic limbs were suddenly vulnerable to space/pressure damage. @Fikou has requested that I re-add this mechanic, as it is now a feature of the game. To implement it, I made a small change to `/datum/species/proc/handle_environment_pressure` so pressure damage only damages organic bodyparts. I also found that any limbs which do not set a `max_damage` simply do not show up in the list returned by `get_damageable_bodyparts`, which could stop them from being damaged/healed, which I think may be intentional. I didn't think this was a bug, but I can change this too if it's asked of me. ## Why It's Good For The Game The PR includes a bugfix which allows non-organic bodyparts to be damaged by spread damage again. An out-of-order argument to the ubiquitous `take_overall_damage` and `receive_damage` functions was causing an argument to shift one position over to the right, and those functions receive a default `required_status` argument of `BODYTYPE_ORGANIC`; both issues combined caused the functions to almost completely ignore non-organic bodyparts, and only deal/heal damage to organic bodyparts. The PR should allow more admin-heals to work as expected, and more sources of damage will now work as expected for non-organic bodyparts. ## Changelog 🆑 A.C.M.O. fix: Fixed robotic/surplus limbs not taking damage/healing as expected; including via the Var Viewer, Player Panel, and from sources of spread-damage. /🆑 Co-authored-by: tattle <66640614+dragomagol@users.noreply.github.com>