mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-08-23 13:10:02 +01:00
TastyfishandGitHub
bca463316b
About The Pull Request
Separated compiling the integration tests and running them as separate steps for organization purposes.
Added a TEST_ASSERT_NULL(value, reason) and TEST_ASSERT_NOTNULL(value, reason) because those are conceptually simple tests.
Makes the PASS and FAIL prefixes in the integration test log be green and red for better readability.
Failure reasons now display the file and line number.
In order to achieve this, direct calls to Fail() are now wrapped in a macro, TEST_FAIL(), as Fail() itself needs preprocessor stuff passed to it.
In the midst of updating it, I noticed multiple cases of tests directly calling Fail() and returning when they should have used a better macro, so those were updated. There was at least one case where it appeared that the code assumed that the test ended at Fail(), but made no attempt to do so, such as with the RCD test.
Feel free to double check all of the changed unit tests in case I made a functional behavior change, but they currently pass.
To take advantage of the previous change, failures are now marked as annotations. Note that outside of github, this creates an ugly-looking line but the primary environment is as a github action.
Examples with intentionally botched unit test:
image
image
image
Why It's Good For The Game
Makes inspecting failed unit tests significantly easier.
Changelog
N/A
63 lines
2.6 KiB
Plaintext
63 lines
2.6 KiB
Plaintext
#define CHECK_OUTFIT_SLOT(outfit_key, slot_name) if (outfit.##outfit_key) { \
|
|
H.equip_to_slot_or_del(new outfit.##outfit_key(H), ##slot_name, TRUE); \
|
|
/* We don't check the result of equip_to_slot_or_del because it returns false for random jumpsuits, as they delete themselves on init */ \
|
|
var/obj/item/outfit_item = H.get_item_by_slot(##slot_name); \
|
|
if (!outfit_item) { \
|
|
TEST_FAIL("[outfit.name]'s [#outfit_key] is invalid! Could not equip a [outfit.##outfit_key] into that slot."); \
|
|
} \
|
|
outfit_item.on_outfit_equip(H, FALSE, ##slot_name); \
|
|
}
|
|
|
|
/// See #66313 and #60901. outfit_sanity used to runtime whenever you had two mergable sheets in either hand. Previously, this only had a 3% chance of occuring. Now 100%.
|
|
/datum/outfit/stacks_in_hands
|
|
name = "Mr. Runtime"
|
|
|
|
uniform = /obj/item/clothing/under/suit/tuxedo
|
|
glasses = /obj/item/clothing/glasses/sunglasses
|
|
mask = /obj/item/clothing/mask/cigarette/cigar/havana
|
|
shoes = /obj/item/clothing/shoes/laceup
|
|
l_hand = /obj/item/stack/spacecash/c1000
|
|
r_hand = /obj/item/stack/spacecash/c1000
|
|
|
|
/datum/unit_test/outfit_sanity/Run()
|
|
var/mob/living/carbon/human/H = allocate(/mob/living/carbon/human)
|
|
|
|
for (var/outfit_type in subtypesof(/datum/outfit))
|
|
// Only make one human and keep undressing it because it's much faster
|
|
for (var/obj/item/I in H.get_equipped_items(include_pockets = TRUE))
|
|
qdel(I)
|
|
|
|
var/datum/outfit/outfit = new outfit_type
|
|
outfit.pre_equip(H, TRUE)
|
|
|
|
CHECK_OUTFIT_SLOT(uniform, ITEM_SLOT_ICLOTHING)
|
|
CHECK_OUTFIT_SLOT(suit, ITEM_SLOT_OCLOTHING)
|
|
CHECK_OUTFIT_SLOT(belt, ITEM_SLOT_BELT)
|
|
CHECK_OUTFIT_SLOT(gloves, ITEM_SLOT_GLOVES)
|
|
CHECK_OUTFIT_SLOT(shoes, ITEM_SLOT_FEET)
|
|
CHECK_OUTFIT_SLOT(head, ITEM_SLOT_HEAD)
|
|
CHECK_OUTFIT_SLOT(mask, ITEM_SLOT_MASK)
|
|
CHECK_OUTFIT_SLOT(neck, ITEM_SLOT_NECK)
|
|
CHECK_OUTFIT_SLOT(ears, ITEM_SLOT_EARS)
|
|
CHECK_OUTFIT_SLOT(glasses, ITEM_SLOT_EYES)
|
|
CHECK_OUTFIT_SLOT(back, ITEM_SLOT_BACK)
|
|
CHECK_OUTFIT_SLOT(id, ITEM_SLOT_ID)
|
|
CHECK_OUTFIT_SLOT(l_pocket, ITEM_SLOT_LPOCKET)
|
|
CHECK_OUTFIT_SLOT(r_pocket, ITEM_SLOT_RPOCKET)
|
|
CHECK_OUTFIT_SLOT(suit_store, ITEM_SLOT_SUITSTORE)
|
|
if (outfit.backpack_contents || outfit.box)
|
|
var/list/backpack_contents = outfit.backpack_contents?.Copy()
|
|
if (outfit.box)
|
|
if (!backpack_contents)
|
|
backpack_contents = list()
|
|
backpack_contents.Insert(1, outfit.box)
|
|
backpack_contents[outfit.box] = 1
|
|
|
|
for (var/path in backpack_contents)
|
|
var/number = backpack_contents[path] || 1
|
|
for (var/_ in 1 to number)
|
|
if (!H.equip_to_slot_or_del(new path(H), ITEM_SLOT_BACKPACK, TRUE))
|
|
TEST_FAIL("[outfit.name]'s backpack_contents are invalid! Couldn't add [path] to backpack.")
|
|
|
|
#undef CHECK_OUTFIT_SLOT
|