Files
Bubberstation/code/controllers/subsystem/traitor.dm
Jacquerel 55cee5dc8e Increases midround traitor starting reputation (#78189)
## About The Pull Request

Reputation for traitors serves two goals:
_Primarily_ it is a timelock. Secondarily, it can drive interaction with
secondary objectives by giving you a little reward.

The way that progression traitors work is that reputation is earned
every minute, so that when a developer is adding a new item for the rep
cost they can just write "30 MINUTES" and it means that the item will be
available when 30 minutes have passed, or a little earlier if the
traitor does some secondary objectives.

_Currently_ when traitors arrive on the station they get reputation
equal to _60%_ of the reputation that they would have had if they became
a traitor at the start of the round and then had hidden in a locker
until the current time.
This PR increases that to 100%, so if you are activated as a sleeper
agent 30 minutes into the round you will immediately have 30 minutes of
reputation. With this and your standard 20TC you can buy almost anything
in the uplink, such as a syndicate bomb.

## Why It's Good For The Game

Given that it is primarily supposed to be a time lock to prevent people
from immediately accessing items which can rapidly pivot the round, it
doesn't make sense that late joining traitors are "penalised" in this
way. If we're ok with a roundstart traitor having a bomb right now, we
should be ok with a latejoin one having one too.
As far as I am concerned secondary objectives should be something you do
for a _bonus_, and anything which can drag people away from being 100%
mechanically focused in order to chase the increasing number in favour
of just being able to do their damn gimmick is a good thing.

## Changelog

🆑
balance: Traitors who are activated as sleeper agents or arrive late on
the arrivals shuttle will begin with more reputation and likely be able
to immediately access most of the uplink catalogue.
/🆑
2023-09-08 20:10:28 +02:00

119 lines
5.5 KiB
Plaintext

SUBSYSTEM_DEF(traitor)
name = "Traitor"
flags = SS_KEEP_TIMING
wait = 10 SECONDS
runlevels = RUNLEVEL_GAME | RUNLEVEL_POSTGAME
/// A list of all uplink items mapped by type
var/list/uplink_items_by_type = list()
/// A list of all uplink items
var/list/uplink_items = list()
/// File to load configurations from.
var/configuration_path = "config/traitor_objective.json"
/// Global configuration data that gets applied to each objective when it is created.
/// Basic objective format
/// '/datum/traitor_objective/path/to/objective': {
/// "global_progression_influence_intensity": 0
/// }
var/configuration_data = list()
/// The coefficient multiplied by the current_global_progression for new joining traitors to calculate their progression
var/newjoin_progression_coeff = 1
/// The current progression that all traitors should be at in the round
var/current_global_progression = 0
/// The amount of deviance from the current global progression before you start getting 2x the current scaling or no scaling at all
/// Also affects objectives, so -50% progress reduction or 50% progress boost.
var/progression_scaling_deviance = 20 MINUTES
/// The current uplink handlers being managed
var/list/datum/uplink_handler/uplink_handlers = list()
/// The current scaling per minute of progression. Has a maximum value of 1 MINUTES.
var/current_progression_scaling = 1 MINUTES
/// Used to handle the probability of getting an objective.
var/datum/traitor_category_handler/category_handler
/// The current debug handler for objectives. Used for debugging objectives
var/datum/traitor_objective_debug/traitor_debug_panel
/// Used by the debug menu, decides whether newly created objectives should generate progression and telecrystals. Do not modify for non-debug purposes.
var/generate_objectives = TRUE
/// Objectives that have been completed by type. Used for limiting objectives.
var/list/taken_objectives_by_type = list()
/// A list of all existing objectives by type
var/list/all_objectives_by_type = list()
/datum/controller/subsystem/traitor/Initialize()
category_handler = new()
traitor_debug_panel = new(category_handler)
for(var/theft_item in subtypesof(/datum/objective_item/steal))
new theft_item
if(fexists(configuration_path))
var/list/data = json_decode(file2text(file(configuration_path)))
for(var/typepath in data)
var/actual_typepath = text2path(typepath)
if(!actual_typepath)
log_world("[configuration_path] has an invalid type ([typepath]) that doesn't exist in the codebase! Please correct or remove [typepath]")
configuration_data[actual_typepath] = data[typepath]
return SS_INIT_SUCCESS
/datum/controller/subsystem/traitor/fire(resumed)
var/player_count = length(GLOB.alive_player_list)
// Has a maximum of 1 minute, however the value can be lower if there are lower players than the ideal
// player count for a traitor to be threatening. Rounds to the nearest 10% of a minute to prevent weird
// values from appearing in the UI. Traitor scaling multiplier bypasses the limit and only multiplies the end value.
// from all of our calculations.
current_progression_scaling = max(min(
(player_count / CONFIG_GET(number/traitor_ideal_player_count)) * 1 MINUTES,
1 MINUTES
), 0.1 MINUTES) * CONFIG_GET(number/traitor_scaling_multiplier)
var/progression_scaling_delta = (wait / (1 MINUTES)) * current_progression_scaling
var/previous_global_progression = current_global_progression
current_global_progression += progression_scaling_delta
for(var/datum/uplink_handler/handler in uplink_handlers)
if(!handler.has_progression || QDELETED(handler))
uplink_handlers -= handler
var/deviance = (previous_global_progression - handler.progression_points) / progression_scaling_deviance
if(abs(deviance) < 0.01)
// If deviance is less than 1%, just set them to the current global progression
// Prevents problems with precision errors.
handler.progression_points = current_global_progression
else
var/amount_to_give = progression_scaling_delta + (progression_scaling_delta * deviance)
amount_to_give = clamp(amount_to_give, 0, progression_scaling_delta * 2)
handler.progression_points += amount_to_give
handler.update_objectives()
handler.on_update()
/datum/controller/subsystem/traitor/proc/register_uplink_handler(datum/uplink_handler/uplink_handler)
if(!uplink_handler.has_progression)
return
uplink_handlers |= uplink_handler
// An uplink handler can be registered multiple times if they get assigned to new uplinks, so
// override is set to TRUE here because it is intentional that they could get added multiple times.
RegisterSignal(uplink_handler, COMSIG_QDELETING, PROC_REF(uplink_handler_deleted), override = TRUE)
/datum/controller/subsystem/traitor/proc/uplink_handler_deleted(datum/uplink_handler/uplink_handler)
SIGNAL_HANDLER
uplink_handlers -= uplink_handler
/datum/controller/subsystem/traitor/proc/on_objective_taken(datum/traitor_objective/objective)
if(!istype(objective))
return
add_objective_to_list(objective, taken_objectives_by_type)
/datum/controller/subsystem/traitor/proc/get_taken_count(datum/traitor_objective/objective_type)
return length(taken_objectives_by_type[objective_type])
/datum/controller/subsystem/traitor/proc/add_objective_to_list(datum/traitor_objective/objective, list/objective_list)
var/datum/traitor_objective/current_type = objective.type
while(current_type != /datum/traitor_objective)
if(!objective_list[current_type])
objective_list[current_type] = list(objective)
else
objective_list[current_type] += objective
current_type = type2parent(current_type)