mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-25 08:34:23 +00:00
d51d6c0de3
* Fixes up multiz atmos connection, cleans some things up in general (#63270) About The Pull Request ALLLRIGHT so Multiz atmos was letting gas flow down into things that should be well, not flowable into Like say doors, or windows. This is weird. Let's get into some context on why yeah? First, how do things work currently? atoms have a can_atmos_pass var defined on them. This points to a define that describes how they interact with flow. ATMOS_PASS_NO means well, if we're asked, block any attempts at flow. This is what walls use. ATMOS_PASS_YES means the inverse ATMOS_PASS_DENSITY means check our current density ATMOS_PASS_PROC means call can_atmos_pass, we need some more details about this attempt These are effectively optimizations. That var, can_atmos_pass is accessed by CANATMOSPASS() the macro It's used for 3 things. 1: Can this turf share at all? 2: Can this turf share with another turf 3: Does this atom block a share to another turf All of this logic is bundled together to weed out the weak. Anyway, so when we added multiz atmos, we effectively made a second version of this system, but for vertical checks. Issue here, we don't actually need to. The only time we care if a check is vertical or not is if we're talking to another turf, it's not like you'll have an object that only wants to block vertical atmos. And even if you did, that's what ATMOS_PASS_PROC is for. As it stands we need to either ignore any object behavior, or just duplicate can_atmos_pass but again. Silly. So I've merged the two, and added an arg to mark if this is a verical attempt. This'll fix things that really should block up/down but don't, like windows and doors and such. Past that, I've cleaned can_atmos_pass up a bit so it's easier for people to understand in future. Oh and I removed the second CANATMOSPASS from immediate_calculate_adjacent_turfs. It isn't a huge optimization, and it's just not functional. It ties into zAirOut and zAirIn, both of which expect to be called with a valid direction. So if say, you open a door that's currently blocking space from leaking in from above, you end up with the door just not asking the space above if it wants to share, since the door can't zAirOut with itself. Let's just wipe it out. This makes the other code much cleaner too, heals the soul. Anyway yadeyada old as ass bug, peace is restored to the kingdom, none noticed this somehow you'd think people would notice window plasma, etc etc. Why It's Good For The Game MUH SIMULATION Also fuck window gas Changelog cl fix: Fixed gas flowing into windows from above, I am.... so tired fix: Fixes gas sometimes not moving up from below after a structure change, see above /cl * Fixes up multiz atmos connection, cleans some things up in general * Update large_doors.dm Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com> Co-authored-by: Gandalf <jzo123@hotmail.com>