Bubberstation

mirror of https://github.com/Bubberstation/Bubberstation.git synced 2026-01-25 00:22:39 +00:00

Files

SkyratBot a44fe4492e [MIRROR] Don't call update_gravity on nullspace when being qdelled [MDB IGNORE] (#21107 )

* Don't call `update_gravity` on nullspace when being qdelled (#75333)

## About The Pull Request

There is a check in `Moved` that calls `update_gravity` if the mob is
being nullspaced or de-nullspaced.

However mobs are nullspaced when being qdeleted.

This causes runtimes because mobs that have gone through Destroy and
have cleaned up vars (such as DNA and species) are having their gravity
updated, and most gravity update logic assumes the mob is in a valid,
not qdelling state.

![image](https://github.com/tgstation/tgstation/assets/51863163/36a14209-68cf-4280-b197-9a7b5818f417)

So, `update_gravity` is not called if the mob is being qdelled when
moving into nullspace.

## Why It's Good For The Game

Runtimes

## Changelog

🆑 Melbert
fix: Runtimes when deleting humans relating to gravity
/🆑

Co-authored-by: san7890 <the@ san7890.com>

* Don't call `update_gravity` on nullspace when being qdelled

---------

Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
Co-authored-by: san7890 <the@ san7890.com>

2023-05-12 00:44:18 -07:00

camera

[MANUAL MIRROR] Nightvision Rework (In the name of color) (#19608 )

2023-03-10 04:17:22 +00:00

dead

[MIRROR] The ghost verb no longer tries to succumb first if you are conscious [MDB IGNORE] (#21060 )

2023-05-10 22:51:02 -07:00

living

[MIRROR] Don't call update_gravity on nullspace when being qdelled [MDB IGNORE] (#21107 )

2023-05-12 00:44:18 -07:00

emote.dm

…