mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-01-28 10:01:58 +00:00
7fd97ede74
## About The Pull Request This mostly just refactors the pdapainter `attackby(...)` into our modern item interaction system, and adds screentips for such. On the side it does a minor amount of cleanup/improvements. Notable changes include: - It felt odd that almost all id cards could be put in here, despite them not really being traditionally changeable. Like, the cargo departmental budget card probably shouldn't be able to get a trim put on it, and neither should pretty much all non-advanced IDs with preset trims and no visual nor explained ability to change them. Hence, this limits it to advanced cards. - I didn't remove the `to_chat(...)` upon id insertion failure, as I felt the balloon alert wouldn't actually communicate the problem sufficiently, but leaving _just_ the `to_chat(...)` felt like it didn't give enough direct feedback on click. Hence, it uses both. ## Why It's Good For The Game Less jank, more screentips, more feedback, less use of `attackby(...)` when we shouldn't. ## Changelog 🆑 refactor: Refactored tablet/ID painter item interactions. Please report any issues. fix: You can no longer circumvent the block on inserting chameleon IDs into tablet/ID painters by inserting them via the UI. fix: You can no longer insert non-advanced IDs into the tablet/ID painter and change their trims. sound: Inserting IDs into tablet/ID painters is no longer silent. qol: You can repair tablet/ID painters when they're damaged, instead of just when they're broken. qol: Improved feedback for tablet/ID painter interactions. qol: Added screentips to tablet/ID painters. /🆑 --------- Co-authored-by: san7890 <the@san7890.com>