mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2026-02-08 23:39:32 +00:00
e7dce7f6fe
## About The Pull Request I saw cameras still had `attackby(...)`, so I decided to refactor it to the new interaction system. In the process, I reorganized and commented most of the vars, made the examine use the right item name, added screentips, added balloon alerts, added disk insert/eject and click sounds, and fixed a few bugs with it that I found in the process. First bug being that `default_picture_name` would only get applied if `can_customise` is `TRUE` and we deny customization, while the only occurrence of this has `can_customise` set to `FALSE`. So we instead just move it down a bit and make it set the picture name to `default_picture_name` if we haven't manually set one either way. The second bug was that we keep a hard reference to the holorecord disk but don't clear it if the disk ever leaves us, meaning that if we manage to remove the disk without ejecting it the camera can still record to it regardless of where it is. So we just make it clear the reference on `Exited(...)`. ## Why It's Good For The Game Less jank good 👍 More clicky feedback good ## Changelog 🆑 refactor: Refactored polaroid camera item interactions. Please report any issues. spellcheck: The polaroid camera's description now talks about 'holorecord' disks rather than 'holographic' disks. qol: Added screentips to the polaroid camera. qol: If a polaroid camera already has a holorecord disk, inserting a new one swaps the old one out instead of blocking. qol: Added balloon alerts and sounds to polaroid camera interactions. fix: Polaroid camera can no longer record to holorecord disks outside of it that left it via nonstandard means. fix: Rewind camera actually applies its special picture name. /🆑