Files
Bubberstation/code/modules/modular_computers/computers/item/computer_files.dm
distributivgesetz ebbc45b161 Improved PDA Direct Messenger (#75820)
## About The Pull Request

Fixes #76708, Closes #76729 (sorry Zephyr)

This PR expands the Direct Messenger UI, adding a chat screen for each
available messenger that you can find, and moving message sending over
to TGUI.

This chat screen includes a message log that displays messages sent by
you as well as messages received from the recipient. This gets rid of
the previous chat log, which just had all messages thrown together that
you received or have sent, in one big list.

Furthermore, all messaging is now done inside the UI. This kills all
TGUI popups you would ever need to send messages forever (except for
quick replies). Use the input bar on the bottom, press Enter or the Send
button, and it sends your message. Spam mode is now done in the UI too,
via a text field you can find in the contacts list.

Additionally, because I have a habit of blowing things massively out of
scope, I've also completely refactored how messages and chat logs are
stored in the PDA messenger. I plan on using this in a PR that merges
the chat client with the messenger, sometime in the future. Sorry this
took so long.

Stuff left to do before I open this PR for review:
- [x] Add "recent messages"
- [x] Add "unread messages"
- [x] Add message drafts
- [x] Make photo sending not shit
- [x] Implement the edge cases for automated and rigged messages
- [x] Make sure shit isn't fucked
- [x] Profit

<details>
  <summary>Screenshots</summary>
  

![dreamseeker_HIrEfrap5X](https://github.com/tgstation/tgstation/assets/47710522/97c713b7-dda3-44d3-a8f5-d0ec11c92668)

![qIOWhVld4l](https://github.com/tgstation/tgstation/assets/47710522/3ab4e2c1-a38f-4b20-8e9f-509ea14c0434)

![dreamseeker_LIqwi05i4O](https://github.com/tgstation/tgstation/assets/47710522/c051c791-b595-4166-a4d3-82cb7568411f)

![BIYxNVjGL7](https://github.com/tgstation/tgstation/assets/47710522/b9c97eab-52b5-449f-b00f-a0d8aa5f865c)

![dreamseeker_IWdoSsUinC](https://github.com/tgstation/tgstation/assets/47710522/2a4cd76a-2bdc-4283-b642-09e92476fef5)

![L9DxzFHDEF](https://github.com/tgstation/tgstation/assets/47710522/6a5b0e29-d535-4c7e-a88e-e9b71198719b)

![rAuDgqBLNE](https://github.com/tgstation/tgstation/assets/47710522/128a0291-91da-4f9e-9bc5-a65cf411ea6d)

![dreamseeker_voui6S8MUf](https://github.com/tgstation/tgstation/assets/47710522/6e3ba044-b8df-492d-b58d-6c73ab07233d)

![image](https://github.com/tgstation/tgstation/assets/47710522/522c1d85-b9cf-4e0e-9588-9d3993eea03f)

</details>

## Why It's Good For The Game

The UI has largely stayed the same since modular tablets were added a
year ago. Even better, direct messaging has been the same since PDAs
were first added *more than a decade ago*. Imagine that.

Now we finally actually (!) make use of those brand new features that we
got from the TGUI switch in this regard.
## Changelog
🆑 distributivgesetz
add: Updated Direct Messenger to v6.5.3. Now including brand new
individual chat rooms, proper image attachments and a revolutionary
message input field!
add: Added a "Reset Imprint" option to the PDA painter.
refactor: Refactored PDA imprinting code just a bit.
fix: PDAs should now properly respond to rigged messages.
/🆑

---------

Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
2023-08-03 14:43:31 -07:00

109 lines
3.4 KiB
Plaintext

/**
* store_file
*
* Adds an already initialized file to the computer, checking if one already exists.
* Returns TRUE if successfully stored, FALSE otherwise.
*/
/obj/item/modular_computer/proc/store_file(datum/computer_file/file_storing)
if(!file_storing || !istype(file_storing))
return FALSE
if(!can_store_file(file_storing))
return FALSE
// This file is already stored. Don't store it again.
if(file_storing in stored_files)
return FALSE
file_storing.computer = src
used_capacity += file_storing.size
SEND_SIGNAL(file_storing, COMSIG_COMPUTER_FILE_STORE, src)
SEND_SIGNAL(src, COMSIG_MODULAR_COMPUTER_FILE_STORE, file_storing)
return TRUE
/**
* remove_file
*
* Removes a given file from the computer, if possible.
* Properly checking if the file even exists and is in the computer.
* Returns TRUE if successfully completed, FALSE otherwise
*/
/obj/item/modular_computer/proc/remove_file(datum/computer_file/file_removing)
if(!file_removing || !istype(file_removing))
return FALSE
if(!(file_removing in stored_files))
return FALSE
if(istype(file_removing, /datum/computer_file/program))
var/datum/computer_file/program/program_file = file_removing
program_file.kill_program()
stored_files.Remove(file_removing)
used_capacity -= file_removing.size
SEND_SIGNAL(src, COMSIG_MODULAR_COMPUTER_FILE_DELETE, file_removing)
SEND_SIGNAL(file_removing, COMSIG_COMPUTER_FILE_DELETE)
qdel(file_removing)
return TRUE
/**
* can_store_file
*
* Checks if a computer can store a file, as computers can only store unique files.
* returns TRUE if possible, FALSE otherwise.
*/
/obj/item/modular_computer/proc/can_store_file(datum/computer_file/file)
if(!file || !istype(file))
return FALSE
if(file in stored_files)
return FALSE
if(find_file_by_name(file.filename))
return FALSE
// In the unlikely event someone manages to create that many files.
// BYOND is acting weird with numbers above 999 in loops (infinite loop prevention)
if(stored_files.len >= 999)
return FALSE
if((used_capacity + file.size) > max_capacity)
return FALSE
if(!file.can_store_file(src))
return FALSE
return TRUE
/**
* find_file_by_name
*
* Will check all applications in a tablet for files and, if they have \
* the same filename (disregarding extension), will return it.
* If a computer disk is passed instead, it will check the disk over the computer.
*/
/obj/item/modular_computer/proc/find_file_by_name(filename, obj/item/computer_disk/target_disk)
if(!istext(filename))
return null
if(isnull(target_disk))
for(var/datum/computer_file/file as anything in stored_files)
if(file.filename == filename)
return file
else
for(var/datum/computer_file/file as anything in target_disk.stored_files)
if(file.filename == filename)
return file
return null
/**
* find_file_by_uid
*
* Will check all files in this computer and returns the file with the matching uid.
* A file's uid is always unique to them, so this proc is sometimes preferable over find_file_by_name.
* If a computer disk is passed instead, it will check the disk over the computer.
*/
/obj/item/modular_computer/proc/find_file_by_uid(uid, obj/item/computer_disk/target_disk)
if(!isnum(uid))
return null
if(isnull(target_disk))
for(var/datum/computer_file/file as anything in stored_files)
if(file.uid == uid)
return file
else
for(var/datum/computer_file/file as anything in target_disk.stored_files)
if(file.uid == uid)
return file
return null