nevimer 07bfaeca8b Fixes radio emotes runechat visibility for /mob/dead/observer and reuse is_custom_emote variable in living_say (#95082) ...

## About The Pull Request

During message hearing, mobs are displayed two versions of the message
they hear, determined by the languages they understand, their mob type
(AI's and ghosts get follow buttons, for example), and special handling
for runechat.

It's a bit of a deep drive, but this bug's been present since #62130.
This implements a check for the flag being sent down, so that when the
runechat is generated, we don't get the cleared placeholder string set
in `/mob/proc/check_for_custom_say_emote()` - set because the message is
never meant to be parsed as a chat message.

Before, the message string sent down `/mob/dead/observer/Hear()` did not
know the message was an emote, so the message passed to the function
that generates the runechat receives the placeholder string. With this
PR, that function now receives the correct string, the same as living
would handle it.

While searching for this bug, I found that a variable was set, but never
used more than once in `/mob/living/Hear()` - I changed the code that
accesses this variable to access the saved inline version instead
(hopefully saving some cpu!!).
## Why It's Good For The Game
## Changelog
🆑
fix: fixed runechat's for radio emotes appearing incorrectly for
observers
code: reuse the emote check from living's hearing function
/🆑

2026-02-25 17:04:18 -05:00

..

new_player

Makes some more lists lazy (#94388)

2025-12-28 19:57:42 +01:00

observer

Fixes radio emotes runechat visibility for /mob/dead/observer and reuse is_custom_emote variable in living_say (#95082)

2026-02-25 17:04:18 -05:00

dead.dm

Refactors faction lists to use getters and setters and be cached (#94490)

2026-01-19 04:12:35 +01:00