mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 09:42:29 +00:00
b67a0901f2
## About The Pull Request Fixes issues with var typing and proc arguments, discovered using OpenDream's WIP TypeMaker feature (using improvements I haven't PR'd upstream yet). ## Why It's Good For The Game Codebase maintenance.
25 lines
1.1 KiB
Plaintext
25 lines
1.1 KiB
Plaintext
/// Makes sure that no orderable items have dynamic descriptions, if they
|
|
/// don't explicitly set a description.
|
|
/// Also makes sure 2 orderable items don't sell the same thing.
|
|
/datum/unit_test/orderable_items
|
|
|
|
/datum/unit_test/orderable_items/Run()
|
|
var/list/all_paths = list()
|
|
for (var/datum/orderable_item/orderable_item as anything in subtypesof(/datum/orderable_item))
|
|
if(isnull(initial(orderable_item.purchase_path))) // don't check if they're not actual orderable items
|
|
continue
|
|
if (!isnull(initial(orderable_item.desc))) //don't check if they have a custom description
|
|
continue
|
|
|
|
var/purchase_path = initial(orderable_item.purchase_path)
|
|
|
|
var/obj/item/item_instance = allocate(purchase_path)
|
|
var/initial_desc = initial(item_instance.desc)
|
|
|
|
if(purchase_path in all_paths)
|
|
TEST_FAIL("[orderable_item] is purchasable under two different orderable_item types,")
|
|
all_paths += purchase_path
|
|
|
|
if (item_instance.desc != initial_desc)
|
|
TEST_FAIL("[orderable_item] has a product ([purchase_path]) that has a dynamic description. [item_instance.desc] (dynamic description) != [initial_desc] (initial description)")
|