mirror of
https://github.com/Bubberstation/Bubberstation.git
synced 2025-12-10 01:34:01 +00:00
93a2b723da
## About The Pull Request Offloads GAGS generation to rust-g IconForge. **Key Notes** - The builtin GAGS editor still uses the 'legacy' generation to allow for debugging. - Does not support `color_matrix` layer type, which is currently not used by any GAGS configs. Will do nothing if used. - Does not support `or` blending mode, which is currently not used by any GAGS configs. Will error if used. - Has some 'quirks' compared to BYOND when it comes to mixing icon states with different dir/frame amounts. BYOND will just silently handle these and it's basically undefined behavior because what should you expect BYOND to do? IconForge will spit errors out instead. So this PR also fixes a few of those cases. Functions by writing output to `tmp/gags/gags-[...].dmi`, copying that output into the RSC and assigning the file object to `icon`. Saves ~1.7s init by reducing worst-case GAGS icon generation from 250ms to 1ms. Also optimizes `icon_exists` by using `rustg_dmi_icon_states` for file icons, saving ~60ms. Would have more savings if not for json_decode as well as DMI parsing in rust being somewhat slow. Perhaps having `rustg_dmi_icon_states` share a cache with IconForge could reduce this cost, however I'd still recommend limiting these tests to unit tests (https://github.com/tgstation/dev-cycles-initiative/issues/34), especially for GAGS configs. I'm not sure they're worth 700ms. Saves another ~400ms by replacing `md5asfile` with `rustg_hash_file` in `/datum/greyscale_config/proc/Refresh` Savings are likely even higher when combined with #89478, due to spritesheets sharing a parsed DMI cache with GAGS. This means GAGS will spend less time parsing icons synchronously and can generate output faster. Tracy tests with this combo seem to yield ~2sec savings instead of ~1.7sec Total savings: ~2.16sec to ~2.46sec - Ports https://github.com/BeeStation/BeeStation-Hornet/pull/10455 - Resolves https://github.com/tgstation/dev-cycles-initiative/issues/9 ## Why It's Good For The Game GAGS go zoooom <details> <summary>GAGS Working Ingame</summary>   </details> <details> <summary>GetColoredIconByType</summary>  </details> <details> <summary>icon_exists</summary>  </details> <details> <summary>Refresh</summary>  </details> ## Changelog 🆑 tweak: Optimized GAGS using rust-g IconForge, reducing worst-case generation time to 1ms /🆑
45 lines
1.1 KiB
Bash
Executable File
45 lines
1.1 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
#Run this in the repo root after compiling
|
|
#First arg is path to where you want to deploy
|
|
#creates a work tree free of everything except what's necessary to run the game
|
|
|
|
#second arg is working directory if necessary
|
|
if [[ $# -eq 2 ]] ; then
|
|
cd $2
|
|
fi
|
|
|
|
mkdir -p \
|
|
$1/_maps \
|
|
$1/code/datums/greyscale/json_configs \
|
|
$1/data/spritesheets \
|
|
$1/icons \
|
|
$1/sound/runtime \
|
|
$1/strings \
|
|
$1/tgui/public \
|
|
$1/tgui/packages/tgfont/dist
|
|
|
|
if [ -d ".git" ]; then
|
|
mkdir -p $1/.git/logs
|
|
cp -r .git/logs/* $1/.git/logs/
|
|
fi
|
|
|
|
cp tgstation.dmb tgstation.rsc $1/
|
|
cp -r _maps/* $1/_maps/
|
|
cp -r code/datums/greyscale/json_configs/* $1/code/datums/greyscale/json_configs/
|
|
cp -r icons/* $1/icons/
|
|
cp -r sound/runtime/* $1/sound/runtime/
|
|
cp -r strings/* $1/strings/
|
|
cp -r tgui/public/* $1/tgui/public/
|
|
cp -r tgui/packages/tgfont/dist/* $1/tgui/packages/tgfont/dist/
|
|
|
|
#remove .dm files from _maps
|
|
|
|
#this regrettably doesn't work with windows find
|
|
#find $1/_maps -name "*.dm" -type f -delete
|
|
|
|
#dlls on windows
|
|
if [ "$(uname -o)" = "Msys" ]; then
|
|
cp ./*.dll $1/
|
|
fi
|